[GitHub] [lucene] uschindler commented on pull request #12066: Retire/deprecate per-instance MMapDirectory#setUseUnmap

uschindler commented on PR #12066: URL: https://github.com/apache/lucene/pull/12066#issuecomment-1370980047 I cleaned up the code more: - removed the useless doPrivileged block around the actual unmapping. We just call a MethodHandle and the Java 9+ version has no security checks. - pu

[GitHub] [lucene] ErikPelli commented on a diff in pull request #12034: Avoid possible NullPointerException in BlendedTermQuery

ErikPelli commented on code in PR #12034: URL: https://github.com/apache/lucene/pull/12034#discussion_r1061649853 ## lucene/core/src/java/org/apache/lucene/search/BlendedTermQuery.java: ## @@ -314,19 +314,15 @@ private static TermStates adjustFrequencies( IndexReaderConte

[GitHub] [lucene] ErikPelli commented on a diff in pull request #12034: Remove null check in IndexReaderContext#leaves() usages

ErikPelli commented on code in PR #12034: URL: https://github.com/apache/lucene/pull/12034#discussion_r1061673383 ## lucene/core/src/java/org/apache/lucene/search/BlendedTermQuery.java: ## @@ -314,19 +314,15 @@ private static TermStates adjustFrequencies( IndexReaderConte

[GitHub] [lucene] jpountz commented on pull request #12054: Introduce a new `KeywordField`.

jpountz commented on PR #12054: URL: https://github.com/apache/lucene/pull/12054#issuecomment-1371192608 Thanks for looking @gsmiller. The test that fails is because this PR relies on behavior introduced by https://github.com/apache/lucene/pull/12053. I'll rebase when this other PR is merge

[GitHub] [lucene] jpountz commented on pull request #12053: Allow reusing indexed binary fields.

jpountz commented on PR #12053: URL: https://github.com/apache/lucene/pull/12053#issuecomment-1371197803 I pushed a new commit that also disallows term vector offsets on binary fields. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene] vstrout opened a new issue, #12067: Getting exception on search after upgrading to Lucene 9.4

vstrout opened a new issue, #12067: URL: https://github.com/apache/lucene/issues/12067 ### Description After upgrading from Lucene 9.3.0 to Lucene 9.4.2 the index search with sorting by description throws the following exception: Caused by: java.lang.IllegalStateException: Term

[GitHub] [lucene] jpountz commented on a diff in pull request #12064: Create new KnnByteVectorField and KnnVectorsReader#getByteVectorValues(String)

jpountz commented on code in PR #12064: URL: https://github.com/apache/lucene/pull/12064#discussion_r1061739690 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/Lucene94HnswVectorsReader.java: ## @@ -233,12 +234,19 @@ public void checkIntegrity() thr

[GitHub] [lucene] uschindler merged pull request #12066: Retire/deprecate per-instance MMapDirectory#setUseUnmap

uschindler merged PR #12066: URL: https://github.com/apache/lucene/pull/12066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] benwtrent commented on pull request #12064: Create new KnnByteVectorField and KnnVectorsReader#getByteVectorValues(String)

benwtrent commented on PR #12064: URL: https://github.com/apache/lucene/pull/12064#issuecomment-1371336800 @jpountz > One thing I'd like to see is whether we can avoid making AbstractVectorValues public and duplicate logic for byte and float vector values in e.g. VectorScorer and Ch

[GitHub] [lucene] jmazanec15 commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge

jmazanec15 commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1061902120 ## lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsWriter.java: ## @@ -461,6 +467,126 @@ public void mergeOneField(FieldInfo fieldInfo, Me

[GitHub] [lucene] jmazanec15 commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge

jmazanec15 commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1061902422 ## lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsWriter.java: ## @@ -461,6 +467,126 @@ public void mergeOneField(FieldInfo fieldInfo, Me

[GitHub] [lucene] jmazanec15 commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge

jmazanec15 commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1061902971 ## lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsWriter.java: ## @@ -461,6 +467,126 @@ public void mergeOneField(FieldInfo fieldInfo, Me

[GitHub] [lucene] jmazanec15 commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge

jmazanec15 commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1061905607 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java: ## @@ -143,10 +148,64 @@ public OnHeapHnswGraph build(RandomAccessVectorValues vectorsTo

[GitHub] [lucene] jmazanec15 commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge

jmazanec15 commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1061916872 ## lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java: ## @@ -94,36 +93,83 @@ public int size() { } /** - * Add node on the given level

[GitHub] [lucene] zhaih commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge

zhaih commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1061955216 ## lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java: ## @@ -94,36 +93,83 @@ public int size() { } /** - * Add node on the given level +

[GitHub] [lucene] zhaih commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge

zhaih commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1061976538 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java: ## @@ -143,10 +148,64 @@ public OnHeapHnswGraph build(RandomAccessVectorValues vectorsToAdd)

[GitHub] [lucene] jmazanec15 commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge

jmazanec15 commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1061991840 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java: ## @@ -143,10 +148,64 @@ public OnHeapHnswGraph build(RandomAccessVectorValues vectorsTo