[GitHub] [lucene] rmuir commented on issue #11996: Replace custom String constructor from codepoints with constructor within java.lang.String class.

2022-12-04 Thread GitBox
rmuir commented on issue #11996: URL: https://github.com/apache/lucene/issues/11996#issuecomment-1336386270 It's obvious you are a troll and don't know what you are talking about. We add such workarounds because we have to, not for fun. If youd like to be productive on this matter go write

[GitHub] [lucene] rmuir closed issue #11996: Replace custom String constructor from codepoints with constructor within java.lang.String class.

2022-12-04 Thread GitBox
rmuir closed issue #11996: Replace custom String constructor from codepoints with constructor within java.lang.String class. URL: https://github.com/apache/lucene/issues/11996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [lucene] uschindler commented on pull request #11987: Make Decompressor release memory buffer

2022-12-04 Thread GitBox
uschindler commented on PR #11987: URL: https://github.com/apache/lucene/pull/11987#issuecomment-1336395938 Hi, another idea about the threadlocals: Why do we need thread locals "per" indexreader. A single thread local cannot be used from multiple threads, so it does not matter if multip

[GitHub] [lucene] rmuir commented on pull request #11987: Make Decompressor release memory buffer

2022-12-04 Thread GitBox
rmuir commented on PR #11987: URL: https://github.com/apache/lucene/pull/11987#issuecomment-1336397936 The threadlocals (closeable or not, i want them out here) only exist because the api is dumb and stateless: `indexreader.document(i)`. So there's no place to store any state to reuse acros

[GitHub] [lucene] rmuir commented on pull request #11987: Make Decompressor release memory buffer

2022-12-04 Thread GitBox
rmuir commented on PR #11987: URL: https://github.com/apache/lucene/pull/11987#issuecomment-1336398355 > Hi, another idea about the threadlocals: Why do we need thread locals "per" indexreader. A single thread local cannot be used from multiple threads, so it does not matter if multiple ind

[GitHub] [lucene] xtonik commented on issue #11996: Replace custom String constructor from codepoints with constructor within java.lang.String class.

2022-12-04 Thread GitBox
xtonik commented on issue #11996: URL: https://github.com/apache/lucene/issues/11996#issuecomment-1336413434 It's obvious you are completely out of reality. Do you think I spend my free time to do such things? If you are so clever, explain what is wrong with original implementation, I have