jpountz opened a new pull request, #11972:
URL: https://github.com/apache/lucene/pull/11972
This generalizes #687 to indexes that are sorted in descending order. The
main challenge with descending sorts is that they require being able to compute
the last doc ID that matches a value, which w
jpountz commented on PR #11942:
URL: https://github.com/apache/lucene/pull/11942#issuecomment-1326206507
`gradlew precommit` fails for me due to imports, can you run `gradlew tidy`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
thecoop commented on PR #11942:
URL: https://github.com/apache/lucene/pull/11942#issuecomment-1326208762
Ah yes, oops, sorry about that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
jpountz commented on PR #11942:
URL: https://github.com/apache/lucene/pull/11942#issuecomment-1326243950
Thanks @thecoop !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
jpountz merged PR #11942:
URL: https://github.com/apache/lucene/pull/11942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
rmuir commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1326477135
I think its enough for this issue. Majority of the error-prone checks we had
enabled were just slowing down the build and providing no benefit :(
And the majority of the ones that co
rmuir commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1326503365
i'm happy if we disable more of the currently-enabled checks in followup
issues. It starts to become subjective, but honestly most of the checks we have
enabled are useless.
If we h
shubhamvishu commented on PR #11954:
URL: https://github.com/apache/lucene/pull/11954#issuecomment-1326530333
> Add entry in CHANGES.txt
Thanks for reviewing @jpountz 😀 .. I have added the entry under 9.5.0.
--
This is an automated message from the Apache Git Service.
To respond
rmuir opened a new issue, #11973:
URL: https://github.com/apache/lucene/issues/11973
### Description
Found by error-prone, looks rather serious to me since it impacts how the
shape is serialized to disk. How come no tests fail?
```
/home/rmuir/workspace/lucene/lucene/core/s
rmuir opened a new pull request, #11974:
URL: https://github.com/apache/lucene/pull/11974
Here's a fix, and also enabling the error-prone check. But I feel like some
sort of testcase should have been failing here all along?
Closes #11973
--
This is an automated message from the Apa
jpountz closed issue #11914: Remove QueryTimeout#isTimeoutEnabled?
URL: https://github.com/apache/lucene/issues/11914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
jpountz merged PR #11954:
URL: https://github.com/apache/lucene/pull/11954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz commented on PR #11880:
URL: https://github.com/apache/lucene/pull/11880#issuecomment-1326605382
@gf2121 Let's merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dweiss commented on PR #11974:
URL: https://github.com/apache/lucene/pull/11974#issuecomment-1326621733
Wow. Nice catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
javanna opened a new pull request, #11975:
URL: https://github.com/apache/lucene/pull/11975
9x is not compiling due to a bad cherry pick I believe. This should fix it.
I tried to push the fix directly but something is missing because I don't
have permissions, or have I dreamed that I
rmuir merged PR #11975:
URL: https://github.com/apache/lucene/pull/11975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on PR #11975:
URL: https://github.com/apache/lucene/pull/11975#issuecomment-1326849454
I thought you were a committer too... something isn't right, thank you for
the fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
rmuir commented on PR #11975:
URL: https://github.com/apache/lucene/pull/11975#issuecomment-1326850910
@javanna did you try to push to
https://gitbox.apache.org/repos/asf/lucene.git ? This should work, it is what i
set as `upstream` in my git. As far as github goes, in order to be able to
javanna commented on PR #11975:
URL: https://github.com/apache/lucene/pull/11975#issuecomment-1326853480
Thanks Robert! id.apache.org is correctly set up but that still does not
help. I tried to push to the github repo and not gitbox, I will change that
then.
--
This is an automated mess
rmuir commented on PR #11975:
URL: https://github.com/apache/lucene/pull/11975#issuecomment-1326861409
@javanna try to push to the gitbox first. if you want to do a test commit
you can add yourself to whoweare page on the website repository:
https://github.com/apache/lucene-site. It is a si
maomao905 opened a new issue, #11976:
URL: https://github.com/apache/lucene/issues/11976
### Description
This issue comes from https://github.com/elastic/elasticsearch/issues/50008.
When tokenizing combining characters (ex. `ã‹€`) after applying the char
filter `icu_normalizer`, end
maomao905 commented on issue #11976:
URL: https://github.com/apache/lucene/issues/11976#issuecomment-1326943642
https://github.com/apache/lucene/issues/9820 issue could be related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
22 matches
Mail list logo
