[GitHub] [lucene] donnerpeter merged pull request #11909: hunspell: introduce FragmentChecker to speed up ModifyingSuggester

donnerpeter merged PR #11909: URL: https://github.com/apache/lucene/pull/11909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

[GitHub] [lucene] uschindler commented on a diff in pull request #11909: hunspell: introduce FragmentChecker to speed up ModifyingSuggester

uschindler commented on code in PR #11909: URL: https://github.com/apache/lucene/pull/11909#discussion_r1020151061 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/FragmentChecker.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] uschindler commented on pull request #11918: Port generic exception handling from MemorySegmentIndexInput to ByteBufferIndexInput

uschindler commented on PR #11918: URL: https://github.com/apache/lucene/pull/11918#issuecomment-1311649830 @jpountz Do you want to do a review, otherwise I will merge this later this afternoon? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene] LuXugang opened a new issue, #11920: Test testDeleteUnusedFiles() failed in TestIndexWriter

LuXugang opened a new issue, #11920: URL: https://github.com/apache/lucene/issues/11920 ### Description Hi, when I try to run `./gradlew check` on my new PC (Windows11), I got this failure below: > java.lang.AssertionError > at __randomizedtesting.SeedInfo

[GitHub] [lucene] dweiss commented on a diff in pull request #11909: hunspell: introduce FragmentChecker to speed up ModifyingSuggester

dweiss commented on code in PR #11909: URL: https://github.com/apache/lucene/pull/11909#discussion_r1020253325 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/FragmentChecker.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [lucene] jpountz commented on a diff in pull request #11917: Automatically preload index files that are both tiny and very hot.

jpountz commented on code in PR #11917: URL: https://github.com/apache/lucene/pull/11917#discussion_r1020267346 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -235,7 +235,7 @@ public IndexInput openInput(String name, IOContext context) throws IOExcept

[GitHub] [lucene] jpountz commented on a diff in pull request #11880: Use ByteArrayComparator to replace Arrays#compareUnsigned in some other places

jpountz commented on code in PR #11880: URL: https://github.com/apache/lucene/pull/11880#discussion_r1020272878 ## lucene/core/src/java/org/apache/lucene/index/CheckIndex.java: ## @@ -65,17 +65,8 @@ import org.apache.lucene.store.FSDirectory; import org.apache.lucene.store.IOC

[GitHub] [lucene] msokolov commented on issue #11702: Multi-Value Support for Binary DocValues [LUCENE-10666]

msokolov commented on issue #11702: URL: https://github.com/apache/lucene/issues/11702#issuecomment-1311770941 just want to point out that objects exist in many different places in space-time -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [lucene] uschindler closed issue #11912: Can we improve MMapDir's exceptions for invalid offsets?

uschindler closed issue #11912: Can we improve MMapDir's exceptions for invalid offsets? URL: https://github.com/apache/lucene/issues/11912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [lucene] uschindler merged pull request #11918: Port generic exception handling from MemorySegmentIndexInput to ByteBufferIndexInput

uschindler merged PR #11918: URL: https://github.com/apache/lucene/pull/11918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] rmuir commented on issue #11912: Can we improve MMapDir's exceptions for invalid offsets?

rmuir commented on issue #11912: URL: https://github.com/apache/lucene/issues/11912#issuecomment-1311903736 Thanks @uschindler ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [lucene] nknize commented on issue #11702: Multi-Value Support for Binary DocValues [LUCENE-10666]

nknize commented on issue #11702: URL: https://github.com/apache/lucene/issues/11702#issuecomment-1311921916 > our implementation is based on the Elasticsearch framework (on the BinaryFieldMapper.CustomBinaryDocValuesField to be exact) @rendel I haven't looked at that implementati

[GitHub] [lucene] uschindler commented on a diff in pull request #11917: Automatically preload index files that are both tiny and very hot.

uschindler commented on code in PR #11917: URL: https://github.com/apache/lucene/pull/11917#discussion_r1020403519 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -235,7 +235,7 @@ public IndexInput openInput(String name, IOContext context) throws IOExc

[GitHub] [lucene] uschindler commented on a diff in pull request #11917: Automatically preload index files that are both tiny and very hot.

uschindler commented on code in PR #11917: URL: https://github.com/apache/lucene/pull/11917#discussion_r1020403519 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -235,7 +235,7 @@ public IndexInput openInput(String name, IOContext context) throws IOExc

[GitHub] [lucene] uschindler commented on a diff in pull request #11917: Automatically preload index files that are both tiny and very hot.

uschindler commented on code in PR #11917: URL: https://github.com/apache/lucene/pull/11917#discussion_r1020409331 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -235,7 +235,7 @@ public IndexInput openInput(String name, IOContext context) throws IOExc

[GitHub] [lucene] uschindler commented on a diff in pull request #11917: Automatically preload index files that are both tiny and very hot.

uschindler commented on code in PR #11917: URL: https://github.com/apache/lucene/pull/11917#discussion_r1020410114 ## lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java: ## @@ -235,7 +235,7 @@ public IndexInput openInput(String name, IOContext context) throws IOExc

[GitHub] [lucene] rmuir commented on issue #11910: improve error-prone configuration for int-overflow bugs

rmuir commented on issue #11910: URL: https://github.com/apache/lucene/issues/11910#issuecomment-1311960933 I'm not looking into `IntLongMath` check but instead a couple targeted checks: * [NarrowingCompoundAssignment](https://errorprone.info/bugpattern/NarrowingCompoundAssignment): thi

[GitHub] [lucene] risdenk commented on issue #11910: improve error-prone configuration for int-overflow bugs

risdenk commented on issue #11910: URL: https://github.com/apache/lucene/issues/11910#issuecomment-1311964746 > I wish i knew a way to make error-prone show all the failures (like javac would). Instead the plugin fails on the first error and I have to fix that one and run it again (slowly)

[GitHub] [lucene] dweiss commented on issue #11910: improve error-prone configuration for int-overflow bugs

dweiss commented on issue #11910: URL: https://github.com/apache/lucene/issues/11910#issuecomment-1311968455 -Pjavac.failOnWarnings=false should do it. Look at javac.gradle, we specifically enable -Werror: ``` if (propertyOrDefault("javac.failOnWarnings", true).toBoolea

[GitHub] [lucene] risdenk opened a new pull request, #11921: errorprone WIP

risdenk opened a new pull request, #11921: URL: https://github.com/apache/lucene/pull/11921 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [lucene] risdenk commented on issue #11910: improve error-prone configuration for int-overflow bugs

risdenk commented on issue #11910: URL: https://github.com/apache/lucene/issues/11910#issuecomment-1311973642 https://github.com/apache/lucene/pull/11921 run with: ``` ./gradlew check -x test -Pvalidation.errorprone=true -Pjavac.failOnWarnings=false -Pvalidation.git.failOnMo

[GitHub] [lucene] risdenk commented on pull request #11921: errorprone WIP

risdenk commented on PR #11921: URL: https://github.com/apache/lucene/pull/11921#issuecomment-1311974711 I have not looked at fixing anything just showing its possible to run this without failing and get all the findings at once. FYI @rmuir -- This is an automated message from the Apache

[GitHub] [lucene] risdenk commented on pull request #11921: errorprone WIP

risdenk commented on PR #11921: URL: https://github.com/apache/lucene/pull/11921#issuecomment-1311978301 Output from run enabling `IntLogMath` rule: ``` ➜ lucene git:(github-11910) ./gradlew check -x test -Pvalidation.errorprone=true -Pjavac.failOnWarnings=false -Pvalidation.git.

[GitHub] [lucene] risdenk commented on issue #11910: improve error-prone configuration for int-overflow bugs

risdenk commented on issue #11910: URL: https://github.com/apache/lucene/issues/11910#issuecomment-1311978932 I put the output for enabling `IntLongMath` in the PR comment: https://github.com/apache/lucene/pull/11921#issuecomment-1311978301 -- This is an automated message from the Apache

[GitHub] [lucene] rmuir commented on pull request #11921: errorprone WIP

rmuir commented on PR #11921: URL: https://github.com/apache/lucene/pull/11921#issuecomment-1311983115 This is awesome, thank you for investigating @risdenk !!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [lucene] risdenk commented on a diff in pull request #11921: errorprone WIP

risdenk commented on code in PR #11921: URL: https://github.com/apache/lucene/pull/11921#discussion_r1020443200 ## gradle/validation/error-prone.gradle: ## @@ -68,6 +68,7 @@ allprojects { prj -> options.errorprone.disableWarningsInGeneratedCode = true options

[GitHub] [lucene] rmuir commented on pull request #11921: errorprone WIP

rmuir commented on PR #11921: URL: https://github.com/apache/lucene/pull/11921#issuecomment-1312000223 Yeah I would have never got thru the issues the old way i was trying to do it. Now i can just do: `/gradlew assemble -Pvalidation.errorprone=true -Pjavac.failOnWarnings=false > ~/overfl

[GitHub] [lucene] shubhamvishu commented on issue #11914: Remove QueryTimeout#isTimeoutEnabled?

shubhamvishu commented on issue #11914: URL: https://github.com/apache/lucene/issues/11914#issuecomment-1312012201 I can work on it. But to understand better, I see this being used in `ExitableDirectoryReader` where conditionally the `ExitableXYZ` wrapper is returned for `XYZ` class. Could

[GitHub] [lucene] rmuir commented on issue #11910: improve error-prone configuration for int-overflow bugs

rmuir commented on issue #11910: URL: https://github.com/apache/lucene/issues/11910#issuecomment-1312078209 OK i checked out old git hash before #11905 commit, seems like "NarrowCalculation" is the best one? I think i made a mistake trying to turn on too many checks at once. I enable

[GitHub] [lucene] gsmiller opened a new issue, #11922: DisjunctionDISIApproximation / DisjunctionScorer can short-circuit

gsmiller opened a new issue, #11922: URL: https://github.com/apache/lucene/issues/11922 ### Description I believe we have an opportunity to improve disjunction evaluation by "short circuiting" within DisjunctionDISIApproximation / DisjunctionScorer. When a disjunction clause _does no

[GitHub] [lucene] rmuir commented on issue #11910: improve error-prone configuration for int-overflow bugs

rmuir commented on issue #11910: URL: https://github.com/apache/lucene/issues/11910#issuecomment-1312171394 i've worked thru src/java and now i gotta deal with src/test, then ill make a PR so we can see what it looks like -- This is an automated message from the Apache Git Service. To res

[GitHub] [lucene] rmuir opened a new pull request, #11923: enable error-prone "narrow calculation" check

rmuir opened a new pull request, #11923: URL: https://github.com/apache/lucene/pull/11923 This check finds bugs such as https://github.com/apache/lucene/pull/11916. For that particular bug, the error messages look like this: ``` /home/rmuir/workspace/lucene/lucene/core/src/java/

[GitHub] [lucene] risdenk commented on a diff in pull request #11923: enable error-prone "narrow calculation" check

risdenk commented on code in PR #11923: URL: https://github.com/apache/lucene/pull/11923#discussion_r1020579969 ## lucene/core/src/java/org/apache/lucene/util/BytesRefHash.java: ## @@ -414,7 +414,7 @@ private void rehash(final int newSize, boolean hashOnData) { } has

[GitHub] [lucene] risdenk commented on a diff in pull request #11923: enable error-prone "narrow calculation" check

risdenk commented on code in PR #11923: URL: https://github.com/apache/lucene/pull/11923#discussion_r1020580110 ## lucene/core/src/java/org/apache/lucene/util/BytesRefHash.java: ## @@ -414,7 +414,7 @@ private void rehash(final int newSize, boolean hashOnData) { } has

[GitHub] [lucene] rmuir commented on pull request #11923: enable error-prone "narrow calculation" check

rmuir commented on PR #11923: URL: https://github.com/apache/lucene/pull/11923#issuecomment-1312221930 This NarrowCalculation is specific to multiplication, which was the issue for #11905. It would not have detected the multiplication issue for the bug before that (#11861), as that one neve

[GitHub] [lucene] uschindler commented on a diff in pull request #11923: enable error-prone "narrow calculation" check

uschindler commented on code in PR #11923: URL: https://github.com/apache/lucene/pull/11923#discussion_r1020582330 ## lucene/core/src/java/org/apache/lucene/util/BytesRefHash.java: ## @@ -414,7 +414,7 @@ private void rehash(final int newSize, boolean hashOnData) { }

[GitHub] [lucene] rmuir commented on a diff in pull request #11923: enable error-prone "narrow calculation" check

rmuir commented on code in PR #11923: URL: https://github.com/apache/lucene/pull/11923#discussion_r1020582937 ## lucene/core/src/java/org/apache/lucene/util/BytesRefHash.java: ## @@ -414,7 +414,7 @@ private void rehash(final int newSize, boolean hashOnData) { } hashM

[GitHub] [lucene] vsop-479 commented on pull request #11888: [Fix] Binary search the entries when all suffixes have the same length in a leaf block.

vsop-479 commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1312341594 @jpountz I added a test case for this bug, but it only works for TestLucene90PostingsFormat which's DEFAULT_MIN_BLOCK_SIZE is 25, add build the first block with 25 entries. It not w