rmuir commented on issue #11910: URL: https://github.com/apache/lucene/issues/11910#issuecomment-1311960933
I'm not looking into `IntLongMath` check but instead a couple targeted checks: * [NarrowingCompoundAssignment](https://errorprone.info/bugpattern/NarrowingCompoundAssignment): this is surprising behavior if you don't know what happens behind the scenes in java here. I know they are adding a check to `javac` for this, so we can disable it later and use that one: https://bugs.openjdk.org/browse/JDK-8244681 * [BadShiftAmount](https://errorprone.info/bugpattern/BadShiftAmount): doesn't find anything in our codebase but another sneaky java thing. FixedBitSet used to have an issue here. * [NarrowCalculation](https://errorprone.info/bugpattern/NarrowCalculation): seems relevant and specific to multiplication and division. These checks are finding some interesting stuff. I wish i knew a way to make error-prone show all the failures (like javac would). Instead the plugin fails on the first error and I have to fix that one and run it again (slowly) to see the next. Its brutally painful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
