[GitHub] [lucene] uschindler commented on pull request #11834: Upgrade forbiddenapis to 3.4

2022-10-05 Thread GitBox
uschindler commented on PR #11834: URL: https://github.com/apache/lucene/pull/11834#issuecomment-1264657879 I added a issue link as TODO: https://github.com/policeman-tools/forbidden-apis/issues/207 (the problem is that parsing the Java 19 classes leads to warnings about the same mis

[GitHub] [lucene] uschindler merged pull request #11834: Upgrade forbiddenapis to 3.4

2022-10-05 Thread GitBox
uschindler merged PR #11834: URL: https://github.com/apache/lucene/pull/11834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] uschindler opened a new pull request, #11835: Clean up MR-JAR build, so we do not have hardcoded "19" everywhere in validation tasks

2022-10-05 Thread GitBox
uschindler opened a new pull request, #11835: URL: https://github.com/apache/lucene/pull/11835 This is mostly a cleanup after we added a MR-JAR. The problem was some hacks in the validation tasks, As long as soureSets are named "mainXX", with XX a feature version, we check everything automa

[GitHub] [lucene] uschindler merged pull request #11835: Clean up MR-JAR build, so we do not have hardcoded "19" everywhere in validation tasks

2022-10-05 Thread GitBox
uschindler merged PR #11835: URL: https://github.com/apache/lucene/pull/11835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] dsmiley commented on pull request #11807: No need to rewrite queries in unified highlighter

2022-10-05 Thread GitBox
dsmiley commented on PR #11807: URL: https://github.com/apache/lucene/pull/11807#issuecomment-1264749687 +1 works for me; this change is the right thing to do, even if it surfaces issues that can be separately fixed. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene] uschindler commented on issue #11819: Fix Java 19 MR-JAR compilation in IDEs

2022-10-05 Thread GitBox
uschindler commented on issue #11819: URL: https://github.com/apache/lucene/issues/11819#issuecomment-1264782928 I have a solution for Intellij Idea: #11836 This variant disables compilation of the MR-JAR sourceSets (like in Eclipse). -- This is an automated message from the Apache Git

[GitHub] [lucene] uschindler opened a new pull request, #11836: GH-11819: Exclude MR-JAR sourceSet and folders from Idea Sync

2022-10-05 Thread GitBox
uschindler opened a new pull request, #11836: URL: https://github.com/apache/lucene/pull/11836 This closes #11819. This is a bit of hack, but after trying a few times with Intellij Idea: When Gradle is running in ideaSync mode, we do some late evaluation: - remove all source folder

[GitHub] [lucene] romseygeek merged pull request #11807: No need to rewrite queries in unified highlighter

2022-10-05 Thread GitBox
romseygeek merged PR #11807: URL: https://github.com/apache/lucene/pull/11807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] romseygeek closed issue #11490: UnifiedHighlighter can miss terms because of query rewrites [LUCENE-10454]

2022-10-05 Thread GitBox
romseygeek closed issue #11490: UnifiedHighlighter can miss terms because of query rewrites [LUCENE-10454] URL: https://github.com/apache/lucene/issues/11490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene-solr] risdenk merged pull request #2671: Add sts support

2022-10-05 Thread GitBox
risdenk merged PR #2671: URL: https://github.com/apache/lucene-solr/pull/2671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] uschindler commented on a diff in pull request #11836: GH-11819: Exclude MR-JAR sourceSet and folders from Idea Sync

2022-10-05 Thread GitBox
uschindler commented on code in PR #11836: URL: https://github.com/apache/lucene/pull/11836#discussion_r986079639 ## gradle/ide/intellij-idea.gradle: ## @@ -37,6 +37,22 @@ if (isIdea) { } } +if (isIdeaSync) { + allprojects { +// disable all MR-JAR folders by hiding th

[GitHub] [lucene] mdmarshmallow commented on issue #11761: Expand TieredMergePolicy deletePctAllowed limits

2022-10-05 Thread GitBox
mdmarshmallow commented on issue #11761: URL: https://github.com/apache/lucene/issues/11761#issuecomment-1269018833 I updated the PR to change the default as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene] zhaih opened a new issue, #11838: Adding concurrency to query rewrite?

2022-10-05 Thread GitBox
zhaih opened a new issue, #11838: URL: https://github.com/apache/lucene/issues/11838 ### Description There're several queries relying on rewrite to do the most heavy work, such as KnnVectorQuery and AutomatonQuery, should we make rewrite step being able to run under multi-threading?

[GitHub] [lucene] zhaih merged pull request #11831: GITHUB-11761: Move minimum TieredMergePolicy delete percentage from 2…

2022-10-05 Thread GitBox
zhaih merged PR #11831: URL: https://github.com/apache/lucene/pull/11831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[GitHub] [lucene] zhaih commented on pull request #11831: GITHUB-11761: Move minimum TieredMergePolicy delete percentage from 2…

2022-10-05 Thread GitBox
zhaih commented on PR #11831: URL: https://github.com/apache/lucene/pull/11831#issuecomment-1269059590 Thanks @mdmarshmallow! I merged and backported it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene] stefanvodita commented on pull request #11780: GH#11601: Add ability to compute reader states after refresh

2022-10-05 Thread GitBox
stefanvodita commented on PR #11780: URL: https://github.com/apache/lucene/pull/11780#issuecomment-1269159465 Thinking some more about this change in light of the comments, I see 3 ways it could go: 1. Do nothing. The user can already instantiate new reader states after a refresh if they

[GitHub] [lucene] rmuir merged pull request #11837: make 'gradle coverage' print test coverage summaries.

2022-10-05 Thread GitBox
rmuir merged PR #11837: URL: https://github.com/apache/lucene/pull/11837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[GitHub] [lucene] rmuir opened a new issue, #11839: gradle aggregate coverage report

2022-10-05 Thread GitBox
rmuir opened a new issue, #11839: URL: https://github.com/apache/lucene/issues/11839 ### Description Currently, when running the build (e.g. `gradlew coverage`) you get a per-module report. Ideally we'd produce an aggregate report (similar to what black magic jenkins is doing:

[GitHub] [lucene] zhaih commented on issue #11750: Why we don't drop changes in pendingDVUpdates here?

2022-10-05 Thread GitBox
zhaih commented on issue #11750: URL: https://github.com/apache/lucene/issues/11750#issuecomment-1269218912 I **think** this looks like a bug (but probably not hurting a lot? Because the segment is dropping anyway?) but I'm not 100% sure. @mikemccand do you have any ideas? -- This is an

[GitHub] [lucene] zhaih commented on issue #11839: gradle aggregate coverage report

2022-10-05 Thread GitBox
zhaih commented on issue #11839: URL: https://github.com/apache/lucene/issues/11839#issuecomment-1269234855 @rmuir I can work on it if you don't want to do it right now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use