[GitHub] [lucene-jira-archive] dweiss commented on issue #137: Consider spreading attachment folders to subfolders to avoid 10000+ folders under a single root

2022-08-08 Thread GitBox
dweiss commented on issue #137: URL: https://github.com/apache/lucene-jira-archive/issues/137#issuecomment-1207750381 Ok, fair enough. But for non-inlined links we'd still show the un-obfuscated URL, right? I honestly don't think the number of files in a folder matters much here but feel f

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #136: Embed attachments' text data for known file types

2022-08-08 Thread GitBox
mocobeta commented on PR #136: URL: https://github.com/apache/lucene-jira-archive/pull/136#issuecomment-1207813822 @mikemccand I'll merge this tomorrow if there is no further feedback/suggestion. Let me know if we need some more time. -- This is an automated message from the Apache Git S

[GitHub] [lucene-jira-archive] mocobeta commented on issue #137: Consider spreading attachment folders to subfolders to avoid 10000+ folders under a single root

2022-08-08 Thread GitBox
mocobeta commented on issue #137: URL: https://github.com/apache/lucene-jira-archive/issues/137#issuecomment-1207823613 We have other tasks and realistically speaking, there is only one developer (me). I'd like to save implementation effort if the current directory structure causes any

[GitHub] [lucene-jira-archive] mocobeta commented on issue #112: Numbered list item is not correctly converted if it follows TAB character

2022-08-08 Thread GitBox
mocobeta commented on issue #112: URL: https://github.com/apache/lucene-jira-archive/issues/112#issuecomment-1207886395 I tried this, and I'd conclude it's difficult to investigate (while it should be possible). -- This is an automated message from the Apache Git Service. To respond to t

[jira] [Created] (LUCENE-10676) FieldInfo#name contributes significantly to heap usage at scale

2022-08-08 Thread David Turner (Jira)
David Turner created LUCENE-10676: - Summary: FieldInfo#name contributes significantly to heap usage at scale Key: LUCENE-10676 URL: https://issues.apache.org/jira/browse/LUCENE-10676 Project: Lucene -

[GitHub] [lucene-jira-archive] mocobeta commented on issue #112: Numbered list item is not correctly converted if it follows TAB character

2022-08-08 Thread GitBox
mocobeta commented on issue #112: URL: https://github.com/apache/lucene-jira-archive/issues/112#issuecomment-1207910795 Or, we could just convert `\t` to space characters (2 or 4 whitespaces maybe)? -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #136: Embed attachments' text data for known file types

2022-08-08 Thread GitBox
mikemccand commented on PR #136: URL: https://github.com/apache/lucene-jira-archive/pull/136#issuecomment-1207916082 Wow, these inlined attachments for known extensions look beautiful! +1 to merge. But I noticed [comments like this one](https://github.com/mocobeta/migration-test-3/

[GitHub] [lucene-jira-archive] mocobeta commented on issue #112: Numbered list item is not correctly converted if it follows TAB character

2022-08-08 Thread GitBox
mocobeta commented on issue #112: URL: https://github.com/apache/lucene-jira-archive/issues/112#issuecomment-1207916338 > Or, we could just convert `\t` to space characters (2 or 4 whitespaces maybe)? But I can't estimate whether there are no side effects. -- This is an automated

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #136: Embed attachments' text data for known file types

2022-08-08 Thread GitBox
mocobeta commented on PR #136: URL: https://github.com/apache/lucene-jira-archive/pull/136#issuecomment-1207918120 > But I noticed [comments like this one](https://github.com/mocobeta/migration-test-3/issues/570#issuecomment-1207401771) that seem to have failed to even turn text like `LUCE

[GitHub] [lucene-jira-archive] mikemccand merged pull request #136: Embed attachments' text data for known file types

2022-08-08 Thread GitBox
mikemccand merged PR #136: URL: https://github.com/apache/lucene-jira-archive/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10676) FieldInfo#name contributes significantly to heap usage at scale

2022-08-08 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576678#comment-17576678 ] Michael McCandless commented on LUCENE-10676: - Is each field name exoticall

[GitHub] [lucene-jira-archive] mocobeta commented on issue #115: Code block is sometimes not properly converted

2022-08-08 Thread GitBox
mocobeta commented on issue #115: URL: https://github.com/apache/lucene-jira-archive/issues/115#issuecomment-1207993420 > I think the cause is that the author inserted no line feed before/after `{code}`. `{code}` is a block element but Jira leniently handles this like inline markup.

[jira] [Updated] (LUCENE-10676) FieldInfo#name contributes significantly to heap usage at scale

2022-08-08 Thread Armin Braun (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Armin Braun updated LUCENE-10676: - Attachment: image-2022-08-08-13-23-37-050.png > FieldInfo#name contributes significantly to hea

[jira] [Commented] (LUCENE-10676) FieldInfo#name contributes significantly to heap usage at scale

2022-08-08 Thread Armin Braun (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576713#comment-17576713 ] Armin Braun commented on LUCENE-10676: -- The field names in the particular case tha

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #138: Insert linefeeds before/after a code block

2022-08-08 Thread GitBox
mocobeta opened a new pull request, #138: URL: https://github.com/apache/lucene-jira-archive/pull/138 Close #115 Line feeds are needed before/after a code block; otherwise, the converted code block is broken in Markdown when the author didn't insert them in the original Jira comment

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #138: Insert linefeeds before/after a code block

2022-08-08 Thread GitBox
mocobeta commented on PR #138: URL: https://github.com/apache/lucene-jira-archive/pull/138#issuecomment-1208013719 Confirmed that this does not affect already properly converted code blocs. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [lucene-jira-archive] mocobeta closed issue #115: Code block is sometimes not properly converted

2022-08-08 Thread GitBox
mocobeta closed issue #115: Code block is sometimes not properly converted URL: https://github.com/apache/lucene-jira-archive/issues/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [lucene-jira-archive] mocobeta merged pull request #138: Insert linefeeds before/after a code block

2022-08-08 Thread GitBox
mocobeta merged PR #138: URL: https://github.com/apache/lucene-jira-archive/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene-jira-archive] mocobeta closed issue #126: Show small attachments and images inline

2022-08-08 Thread GitBox
mocobeta closed issue #126: Show small attachments and images inline URL: https://github.com/apache/lucene-jira-archive/issues/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [lucene-jira-archive] mocobeta commented on issue #126: Show small attachments and images inline

2022-08-08 Thread GitBox
mocobeta commented on issue #126: URL: https://github.com/apache/lucene-jira-archive/issues/126#issuecomment-1208016526 I think this can be closed. Will take a look at #127 soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #139: Enable GitHub Pages for hosting attachment files.

2022-08-08 Thread GitBox
mocobeta opened a new pull request, #139: URL: https://github.com/apache/lucene-jira-archive/pull/139 #127 Following https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features, this enables GitHub pages. The document root is `gh-pages` branch (we don't want to place

[GitHub] [lucene-jira-archive] mocobeta merged pull request #139: Enable GitHub Pages for hosting attachment files.

2022-08-08 Thread GitBox
mocobeta merged PR #139: URL: https://github.com/apache/lucene-jira-archive/pull/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Created] (LUCENE-10677) Duplicate strings in FieldInfo#attributes contribute significantly to heap usage at scale

2022-08-08 Thread Armin Braun (Jira)
Armin Braun created LUCENE-10677: Summary: Duplicate strings in FieldInfo#attributes contribute significantly to heap usage at scale Key: LUCENE-10677 URL: https://issues.apache.org/jira/browse/LUCENE-10677

[jira] [Comment Edited] (LUCENE-10676) FieldInfo#name contributes significantly to heap usage at scale

2022-08-08 Thread Armin Braun (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576713#comment-17576713 ] Armin Braun edited comment on LUCENE-10676 at 8/8/22 12:05 PM: --

[GitHub] [lucene] gsmiller commented on a diff in pull request #1058: LUCENE-10207: TermInSetQuery now provides a ScoreSupplier with cost estimation for use in TermInSetQuery

2022-08-08 Thread GitBox
gsmiller commented on code in PR #1058: URL: https://github.com/apache/lucene/pull/1058#discussion_r940164398 ## lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java: ## @@ -345,15 +345,62 @@ public BulkScorer bulkScorer(LeafReaderContext context) throws IOExceptio

[GitHub] [lucene] msokolov commented on a diff in pull request #1054: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-08-08 Thread GitBox
msokolov commented on code in PR #1054: URL: https://github.com/apache/lucene/pull/1054#discussion_r940165941 ## lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java: ## @@ -248,7 +269,9 @@ private void run(String... args) throws Exception { if (docVec

[GitHub] [lucene-jira-archive] msokolov commented on issue #112: Numbered list item is not correctly converted if it follows TAB character

2022-08-08 Thread GitBox
msokolov commented on issue #112: URL: https://github.com/apache/lucene-jira-archive/issues/112#issuecomment-1208055161 Maybe a no-break-space ( ) would be safer (less likely to have some special meaning to github markdown parser) than a regular space? -- This is an automated message fro

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #139: Enable GitHub Pages for hosting attachment files.

2022-08-08 Thread GitBox
mocobeta commented on PR #139: URL: https://github.com/apache/lucene-jira-archive/pull/139#issuecomment-1208060536 Looks like it still does not work; something goes wrong. https://apache.github.io/lucene-jira-archive/attachments/LUCENE-10006/mypatch.patch -- This is an automated m

[GitHub] [lucene-jira-archive] mocobeta commented on issue #112: Numbered list item is not correctly converted if it follows TAB character

2022-08-08 Thread GitBox
mocobeta commented on issue #112: URL: https://github.com/apache/lucene-jira-archive/issues/112#issuecomment-1208093000 I think in most cases it's fine to replace `\t` to whitespace or ` `, but noformat or code block can also contain `\t`; modifying any characters can break a code block (I

[GitHub] [lucene] yugushihuang commented on pull request #1057: LUCENE-10670: Add a codec class to track merge time of each index part

2022-08-08 Thread GitBox
yugushihuang commented on PR #1057: URL: https://github.com/apache/lucene/pull/1057#issuecomment-1208231388 > The idea seems good - we want to track merge times separately for each format, right? I wonder if the Filter classes belong in a monitoring package though. It's also a confusing nam

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #140: Support tab for list item separator

2022-08-08 Thread GitBox
mocobeta opened a new pull request, #140: URL: https://github.com/apache/lucene-jira-archive/pull/140 Close #112 The parser expects a list item to be `# ` but it occasionally to be `#` (especially commitbot's comment). This supports `\t` as the list item separator as well

[GitHub] [lucene-jira-archive] mocobeta commented on issue #112: Numbered list item is not correctly converted if it follows TAB character

2022-08-08 Thread GitBox
mocobeta commented on issue #112: URL: https://github.com/apache/lucene-jira-archive/issues/112#issuecomment-1208234971 I finally figured out a solution in #140. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #140: Support tab for list item separator

2022-08-08 Thread GitBox
mocobeta commented on PR #140: URL: https://github.com/apache/lucene-jira-archive/pull/140#issuecomment-1208236502 also confirmed this does not affect the usual list item with whitespace (`# `). -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [lucene-jira-archive] mocobeta closed issue #112: Numbered list item is not correctly converted if it follows TAB character

2022-08-08 Thread GitBox
mocobeta closed issue #112: Numbered list item is not correctly converted if it follows TAB character URL: https://github.com/apache/lucene-jira-archive/issues/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [lucene-jira-archive] mocobeta merged pull request #140: Support tab for list item separator

2022-08-08 Thread GitBox
mocobeta merged PR #140: URL: https://github.com/apache/lucene-jira-archive/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #140: Support tab for list item separator

2022-08-08 Thread GitBox
mocobeta commented on PR #140: URL: https://github.com/apache/lucene-jira-archive/pull/140#issuecomment-1208242695 I'm merging this. I don't think it's reviewable anyway... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [lucene] gsmiller opened a new pull request, #1062: Optimize TermInSetQuery for terms that match all docs in a segment

2022-08-08 Thread GitBox
gsmiller opened a new pull request, #1062: URL: https://github.com/apache/lucene/pull/1062 ### Description (or a Jira issue link if you have one) This change introduces an optimization to `TermInSetQuery` when a term is present that matches all docs in a segment. -- This is an auto

[GitHub] [lucene] kaivalnp commented on a diff in pull request #1054: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-08-08 Thread GitBox
kaivalnp commented on code in PR #1054: URL: https://github.com/apache/lucene/pull/1054#discussion_r940501321 ## lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java: ## @@ -248,7 +269,9 @@ private void run(String... args) throws Exception { if (docVec

[GitHub] [lucene] nknize commented on pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-08-08 Thread GitBox
nknize commented on PR #1017: URL: https://github.com/apache/lucene/pull/1017#issuecomment-1208452593 This PR is fairly large, all issues have been addressed with passing tests, so I plan to merge this tomorrow so I can add the visitor pattern in a follow up PR. Multi geometries will be exp

[GitHub] [lucene] zacharymorn commented on a diff in pull request #1039: LUCENE-10635: Ensure test coverage for WANDScorer by using a test query

2022-08-08 Thread GitBox
zacharymorn commented on code in PR #1039: URL: https://github.com/apache/lucene/pull/1039#discussion_r940876636 ## lucene/core/src/test/org/apache/lucene/search/TestWANDScorer.java: ## @@ -815,7 +856,7 @@ private void doTestRandomSpecialMaxScore(float maxScore) throws IOExcept

[GitHub] [lucene] zacharymorn commented on a diff in pull request #1039: LUCENE-10635: Ensure test coverage for WANDScorer by using a test query

2022-08-08 Thread GitBox
zacharymorn commented on code in PR #1039: URL: https://github.com/apache/lucene/pull/1039#discussion_r940877761 ## lucene/core/src/test/org/apache/lucene/search/TestWANDScorer.java: ## @@ -947,4 +988,82 @@ public long cost() { }; } } + + private static class WAN

[GitHub] [lucene] mocobeta commented on issue #1060: Increase the default value of MAX_DIMENSIONS for Vector Values

2022-08-08 Thread GitBox
mocobeta commented on issue #1060: URL: https://github.com/apache/lucene/issues/1060#issuecomment-1208963638 Issues should be raised in Jira. Please do not use GitHub issue until the migration will have done. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene] mocobeta closed issue #1060: Increase the default value of MAX_DIMENSIONS for Vector Values

2022-08-08 Thread GitBox
mocobeta closed issue #1060: Increase the default value of MAX_DIMENSIONS for Vector Values URL: https://github.com/apache/lucene/issues/1060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec