[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #131: Create hyperlinks to other ASF projects for PRJ-XXXX style cross-issue links.

2022-08-06 Thread GitBox
mocobeta opened a new pull request, #131: URL: https://github.com/apache/lucene-jira-archive/pull/131 Close #129. This captures all Jira issue keys like `{PRJ}-{NUMBER}` in issue descriptions/comments and generates hyperlinks to the issues if the `{PRJ}` is known ASF projects. --

[GitHub] [lucene-jira-archive] mikemccand commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mikemccand commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207235773 Yeah I'm not proposing we change this approach now. I am proposing we mark both GitHub and Jira read-only during the migration. I think the community would agree, si

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #131: Create hyperlinks to other ASF projects for PRJ-XXXX style cross-issue links.

2022-08-06 Thread GitBox
mocobeta commented on PR #131: URL: https://github.com/apache/lucene-jira-archive/pull/131#issuecomment-1207235784 For example, this contains lots of links to SOLR. https://github.com/mocobeta/migration-test-3/issues/560 And this contains a few links to INFRA. https://github.com

[GitHub] [lucene-jira-archive] mocobeta commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207235887 Addressed in #131. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [lucene-jira-archive] mocobeta commented on issue #122: Consider removing "Legacy Jira: by" prefix from comments

2022-08-06 Thread GitBox
mocobeta commented on issue #122: URL: https://github.com/apache/lucene-jira-archive/issues/122#issuecomment-1207236845 #128 was merged - I'm closing this. Thanks @vlsi and @mikemccand for your suggestions. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [lucene-jira-archive] mocobeta closed issue #122: Consider removing "Legacy Jira: by" prefix from comments

2022-08-06 Thread GitBox
mocobeta closed issue #122: Consider removing "Legacy Jira: by" prefix from comments URL: https://github.com/apache/lucene-jira-archive/issues/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene-jira-archive] mocobeta closed issue #123: Consider removing "Legacy JIRA" from the issue descriptions

2022-08-06 Thread GitBox
mocobeta closed issue #123: Consider removing "Legacy JIRA" from the issue descriptions URL: https://github.com/apache/lucene-jira-archive/issues/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene-jira-archive] mocobeta commented on issue #123: Consider removing "Legacy JIRA" from the issue descriptions

2022-08-06 Thread GitBox
mocobeta commented on issue #123: URL: https://github.com/apache/lucene-jira-archive/issues/123#issuecomment-1207236874 #128 was merged - I'm closing this. Thanks @vlsi and @mikemccand for your suggestions. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #131: Create hyperlinks to other ASF projects for PRJ-XXXX style cross-issue links.

2022-08-06 Thread GitBox
mikemccand commented on PR #131: URL: https://github.com/apache/lucene-jira-archive/pull/131#issuecomment-1207237084 Hi, did you test on a few issues? Hard to parse these regexps! But the change looks good to me. I wonder if any of these projects that we may link to have also migra

[GitHub] [lucene-jira-archive] mocobeta commented on issue #126: Show small attachments and images inline

2022-08-06 Thread GitBox
mocobeta commented on issue #126: URL: https://github.com/apache/lucene-jira-archive/issues/126#issuecomment-1207237106 I think I'll open two PRs against this issue - one for patches and one for orphaned images that are not mentioned in any comments. -- This is an automated message from

[GitHub] [lucene-jira-archive] mikemccand commented on issue #91: Can we strike-through issues that were resolved on migration?

2022-08-06 Thread GitBox
mikemccand commented on issue #91: URL: https://github.com/apache/lucene-jira-archive/issues/91#issuecomment-1207238066 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207238227 Maybe I should have strongly argued we should allow some downtime (no new issues, PRs and comments for one or two days) so that we make the migration plan more simple.

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #131: Create hyperlinks to other ASF projects for PRJ-XXXX style cross-issue links.

2022-08-06 Thread GitBox
mocobeta commented on PR #131: URL: https://github.com/apache/lucene-jira-archive/pull/131#issuecomment-1207239340 I think it'd be difficult to ensure the coverage. There might be false negatives since this regex is rather strict. At least we can log the detected links and check them. --

[GitHub] [lucene-jira-archive] vlsi commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
vlsi commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207241887 Does the second pass generate GitHub notifications for the users mentioned in the issues? I think those notifications would be too much -- This is an automated message from

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207242420 > Does the second pass generate GitHub notifications for the users mentioned in the issues? We confirmed the second pass does not cause any notifications. It seems Git

[GitHub] [lucene-jira-archive] mikemccand commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mikemccand commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207243404 Have we confirmed with INFRA that we can quickly make Jira read-only for just our project (Lucene)? -- This is an automated message from the Apache Git Service. To respon

[GitHub] [lucene-jira-archive] mikemccand commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mikemccand commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207243538 > But if we follow the two-pass migration plan written in #7, we do not need any downtime. OK, as long as we feel the risks are all contained (because you had planned

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207244201 > Have we confirmed with INFRA that we can quickly make Jira read-only for just our project (Lucene)? We need to update all Jira issues at the last step. If we want Jir

[GitHub] [lucene-jira-archive] mocobeta commented on issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style

2022-08-06 Thread GitBox
mocobeta commented on issue #124: URL: https://github.com/apache/lucene-jira-archive/issues/124#issuecomment-1207252369 Merged #130 - I'm closing this. Thanks @vlsi and @mikemccand for your suggestions. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene-jira-archive] mocobeta closed issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style

2022-08-06 Thread GitBox
mocobeta closed issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style URL: https://github.com/apache/lucene-jira-archive/issues/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #132: Replace LUCENE issue links (URLs like https://issues.apache.org/jira/browse/LUCENE-XXXX) with GitHub mentions #NN

2022-08-06 Thread GitBox
mocobeta opened a new issue, #132: URL: https://github.com/apache/lucene-jira-archive/issues/132 Spin-off from #129. There could be multiple URLs to one issue. I suppose this regex would work? ``` https://issues\.apache\.org/jira/.+/LUCENE-\d+ ``` -- This is an automated me

[GitHub] [lucene-jira-archive] uschindler commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
uschindler commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207258917 Just do this live with the Infra team on Slack. They are very cooperative and fix stuff in realtime. Just make some appointment with them and you can work together with the

[GitHub] [lucene-jira-archive] mocobeta commented on issue #132: Replace LUCENE issue links (URLs like https://issues.apache.org/jira/browse/LUCENE-XXXX) with GitHub mentions #NN

2022-08-06 Thread GitBox
mocobeta commented on issue #132: URL: https://github.com/apache/lucene-jira-archive/issues/132#issuecomment-1207259951 I just did a quick-check with grep command. Estimated # of issues that contain urls to LUCENE issues. ``` $ cat github-import-data/*.json | jq '.issue.body' |

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207260905 Yes, but - making a Jira project would not be a quick fix I think? I'm missing something maybe? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207262101 I'll reach INFRA, but If possible, I would like to proceed with the whole process in async-style without real-time conversation using Slack - there is a time difference betwe

[GitHub] [lucene] msokolov commented on pull request #1054: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-08-06 Thread GitBox
msokolov commented on PR #1054: URL: https://github.com/apache/lucene/pull/1054#issuecomment-1207262818 I made the needed changes to KnnGraphTester and ran several tests with different datasets. I believe this version of the PR addresses all the previous comments, and I'd like to move ahead

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207273658 Don't get me wrong - I appreciate suggestions from all of you. However, there are many things you can easily control but I can't due to several differences (timezone, languag

[GitHub] [lucene-jira-archive] uschindler commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
uschindler commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207288675 Hi mocobeta, I can also look into stuff if it is going on. On whcih machine do you want to start the meigration? I'd suggest to do this on some server at ASF (like the J

[GitHub] [lucene-jira-archive] uschindler commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
uschindler commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207288810 And doing something like changing permission scheme can be done with communication on Slack. That's all. I did this several times. -- This is an automated message from th

[GitHub] [lucene] msokolov commented on a diff in pull request #1058: LUCENE-10207: TermInSetQuery now provides a ScoreSupplier with cost estimation for use in TermInSetQuery

2022-08-06 Thread GitBox
msokolov commented on code in PR #1058: URL: https://github.com/apache/lucene/pull/1058#discussion_r939587786 ## lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java: ## @@ -345,15 +345,62 @@ public BulkScorer bulkScorer(LeafReaderContext context) throws IOExceptio

[GitHub] [lucene] msokolov commented on pull request #1040: LUCENE-10404: use IntIntHashMap to track HNSW visited nodes

2022-08-06 Thread GitBox
msokolov commented on PR #1040: URL: https://github.com/apache/lucene/pull/1040#issuecomment-1207305068 I'm going to close this since it was sometimes better and sometimes worse than what we have now, and we should probably not bother with this, and instead try some kind of hybrid adaptive

[GitHub] [lucene] msokolov closed pull request #1040: LUCENE-10404: use IntIntHashMap to track HNSW visited nodes

2022-08-06 Thread GitBox
msokolov closed pull request #1040: LUCENE-10404: use IntIntHashMap to track HNSW visited nodes URL: https://github.com/apache/lucene/pull/1040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [lucene] msokolov commented on pull request #955: LUCENE-10612: Introduced Lucene93CodecParameters for Lucene93Codec

2022-08-06 Thread GitBox
msokolov commented on PR #955: URL: https://github.com/apache/lucene/pull/955#issuecomment-1207305478 I'm not sure why this is easier or cleaner. To me it seems to create an unneccessary intermediate class, just for the purpose of passing parameters. Perhaps if we were trying to load parame

[GitHub] [lucene] msokolov commented on pull request #948: Fix typo in PostingsReaderBase docstring

2022-08-06 Thread GitBox
msokolov commented on PR #948: URL: https://github.com/apache/lucene/pull/948#issuecomment-1207305547 @vigyasharma did you forget about this one ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (LUCENE-10386) Add BOM module for ease of dependency management in dependent projects

2022-08-06 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576301#comment-17576301 ] Michael Sokolov commented on LUCENE-10386: -- It seems we're not going to do thi

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #131: Create hyperlinks to other ASF projects for PRJ-XXXX style cross-issue links.

2022-08-06 Thread GitBox
mocobeta commented on PR #131: URL: https://github.com/apache/lucene-jira-archive/pull/131#issuecomment-1207313857 I run this on ~8000 issues; here are the generated issue links (sampled). ``` https://issues.apache.org/jira/browse/SOLR-15 https://issues.apache.org/jira/browse/SOLR-8

[GitHub] [lucene-jira-archive] mocobeta closed issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta closed issue #129: Should we create links to Jira issues other than Lucene? URL: https://github.com/apache/lucene-jira-archive/issues/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene-jira-archive] mocobeta merged pull request #131: Create hyperlinks to other ASF projects for PRJ-XXXX style cross-issue links.

2022-08-06 Thread GitBox
mocobeta merged PR #131: URL: https://github.com/apache/lucene-jira-archive/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene-jira-archive] mocobeta commented on issue #129: Should we create links to Jira issues other than Lucene?

2022-08-06 Thread GitBox
mocobeta commented on issue #129: URL: https://github.com/apache/lucene-jira-archive/issues/129#issuecomment-1207316046 #131 seems to work - I'm closing this. Internal issue links (URLs) to LUCENE Jira will be addressed in #132. -- This is an automated message from the Apache Git S

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207320713 > I can also look into stuff if it is going on. On whcih machine do you want to start the meigration? I'd suggest to do this on some server at ASF (like the Jenkins Slave luc

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207323500 I recognize strong suggestions to make both Jira and GitHub non-writable during migration. Generally, I agree with it - stopping all activities for two or three days would no

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207334349 I sent an email on the dev@ list to share the change in the migration (~72 hours downtime for issues/PRs). I'd be glad if you give further suggestions there. If there are

[GitHub] [lucene-jira-archive] vlsi commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
vlsi commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207335068 >This wad moved to GitHub  Are you going to include the link to GitHub issue? Would that trigger JIRA notifications? -- This is an automated message from the Apache Gi

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-08-06 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1207335431 > Are you going to include the link to GitHub issue? Yes, this is the main purpose of leaving a comment to each Jira. The message will be something like `This was moved

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #133: Drop jira link from linked-issues

2022-08-06 Thread GitBox
mocobeta opened a new pull request, #133: URL: https://github.com/apache/lucene-jira-archive/pull/133 We use GitHub issue link `#NN` for the first place; then I think there would be no need for creating links to Jira anymore (a fallback link to the original Jira is available in each GitHub

[GitHub] [lucene-jira-archive] mocobeta commented on issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style

2022-08-06 Thread GitBox
mocobeta commented on issue #124: URL: https://github.com/apache/lucene-jira-archive/issues/124#issuecomment-1207342271 I wonder if we no longer need links to Jira issue: #133. We already dropped the original Jira issue link for short form by replacing `LUCENE-` with `#NN` for succin

[GitHub] [lucene-jira-archive] mocobeta merged pull request #133: Drop jira link from linked-issues

2022-08-06 Thread GitBox
mocobeta merged PR #133: URL: https://github.com/apache/lucene-jira-archive/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene-jira-archive] vlsi commented on issue #124: Consider using "GitHub link ( JIRA link )" cross-reference style

2022-08-06 Thread GitBox
vlsi commented on issue #124: URL: https://github.com/apache/lucene-jira-archive/issues/124#issuecomment-1207344183 Looks reasonable to me. Then, the question is whether "migrated from jira" link is needed for every comment -- This is an automated message from the Apache Git Service. To

<    1   2