[GitHub] [lucene] stefanvodita commented on pull request #1001: LUCENE-10629: Add fastMatchQuery to MatchingFacetSetCounts

2022-07-14 Thread GitBox
stefanvodita commented on PR #1001: URL: https://github.com/apache/lucene/pull/1001#issuecomment-1184142975 [PR 1015](https://github.com/apache/lucene/pull/1015) incorporates and improves the ideas here. I'll close this PR. -- This is an automated message from the Apache Git Service. To r

[GitHub] [lucene] stefanvodita closed pull request #1001: LUCENE-10629: Add fastMatchQuery to MatchingFacetSetCounts

2022-07-14 Thread GitBox
stefanvodita closed pull request #1001: LUCENE-10629: Add fastMatchQuery to MatchingFacetSetCounts URL: https://github.com/apache/lucene/pull/1001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-14 Thread Nathan Meisels (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566715#comment-17566715 ] Nathan Meisels commented on LUCENE-10650: - Thanks for the tip. I will go the re

[jira] [Comment Edited] (LUCENE-10650) "after_effect": "no" was removed what replaces it?

2022-07-14 Thread Nathan Meisels (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566715#comment-17566715 ] Nathan Meisels edited comment on LUCENE-10650 at 7/14/22 8:41 AM: ---

[GitHub] [lucene] JoeHF commented on a diff in pull request #1003: LUCENE-10616: optimizing decompress when only retrieving some fields

2022-07-14 Thread GitBox
JoeHF commented on code in PR #1003: URL: https://github.com/apache/lucene/pull/1003#discussion_r921030029 ## lucene/core/src/java/org/apache/lucene/codecs/compressing/Decompressor.java: ## @@ -42,6 +44,13 @@ protected Decompressor() {} public abstract void decompress(

[GitHub] [lucene] JoeHF commented on a diff in pull request #1003: LUCENE-10616: optimizing decompress when only retrieving some fields

2022-07-14 Thread GitBox
JoeHF commented on code in PR #1003: URL: https://github.com/apache/lucene/pull/1003#discussion_r921034917 ## lucene/core/src/java/org/apache/lucene/document/DocumentStoredFieldVisitor.java: ## @@ -98,6 +100,16 @@ public void doubleField(FieldInfo fieldInfo, double value) {

[GitHub] [lucene] JoeHF commented on pull request #1003: LUCENE-10616: optimizing decompress when only retrieving some fields

2022-07-14 Thread GitBox
JoeHF commented on PR #1003: URL: https://github.com/apache/lucene/pull/1003#issuecomment-1184329447 thanks @jpountz for reviewing and advice, this [commit](https://github.com/apache/lucene/pull/1003/commits/e40d3d05022a27f4ade27ebb897d091ab5563b66) forks codes to `Lucene90` and left only o

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #34: Add a tool to generate account mapping

2022-07-14 Thread GitBox
mikemccand commented on PR #34: URL: https://github.com/apache/lucene-jira-archive/pull/34#issuecomment-1184340452 Thanks @mocobeta! I was wondering what to pass as the account mapping as I ran the tooling ;) Today all of my migrated issues are all commented / opened by `mikemccand` lol.

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #34: Add a tool to generate account mapping

2022-07-14 Thread GitBox
mocobeta commented on PR #34: URL: https://github.com/apache/lucene-jira-archive/pull/34#issuecomment-1184353206 > Today all of my migrated issues are all commented / opened by mikemccand lol. As for the "author" of each GitHub issue/comments, we won't be able to preserve it. The a

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #34: Add a tool to generate account mapping

2022-07-14 Thread GitBox
mikemccand commented on PR #34: URL: https://github.com/apache/lucene-jira-archive/pull/34#issuecomment-1184361866 > As for the "author" of each GitHub issue/comments, we won't be able to preserve/migrate the original Jira author. The author will be the caller's account. Please see #4 for

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #34: Add a tool to generate account mapping

2022-07-14 Thread GitBox
mocobeta commented on PR #34: URL: https://github.com/apache/lucene-jira-archive/pull/34#issuecomment-1184363900 Yes I'll run the tool and commit a result file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-14 Thread GitBox
mayya-sharipova commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r921175386 ## lucene/core/src/java/org/apache/lucene/index/VectorValuesWriter.java: ## @@ -26,233 +26,153 @@ import org.apache.lucene.codecs.KnnVectorsWriter; import org.apa

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-14 Thread GitBox
mayya-sharipova commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r921176546 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java: ## @@ -24,28 +24,40 @@ import org.apache.lucene.index.DocIDMerger; import org.apache.lucen

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-14 Thread GitBox
mayya-sharipova commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r921175386 ## lucene/core/src/java/org/apache/lucene/index/VectorValuesWriter.java: ## @@ -26,233 +26,153 @@ import org.apache.lucene.codecs.KnnVectorsWriter; import org.apa

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-14 Thread GitBox
mayya-sharipova commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r921175386 ## lucene/core/src/java/org/apache/lucene/index/VectorValuesWriter.java: ## @@ -26,233 +26,153 @@ import org.apache.lucene.codecs.KnnVectorsWriter; import org.apa

[jira] [Commented] (LUCENE-10592) Should we build HNSW graph on the fly during indexing

2022-07-14 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566853#comment-17566853 ] Mayya Sharipova commented on LUCENE-10592: -- [~julietibs] Thanks for studying t

[GitHub] [lucene] gsmiller opened a new pull request, #1022: LUCENE-10653: Heapify in BMMScorer

2022-07-14 Thread GitBox
gsmiller opened a new pull request, #1022: URL: https://github.com/apache/lucene/pull/1022 ### Description (or a Jira issue link if you have one) Small optimization to use a heapify algorithm in `BMMScorer` when maintaining the heap instead of incremental adds. -- This is an automa

[jira] [Commented] (LUCENE-10471) Increase the number of dims for KNN vectors to 2048

2022-07-14 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566868#comment-17566868 ] Mayya Sharipova commented on LUCENE-10471: -- Sorry, may be I should have provid

[jira] [Commented] (LUCENE-10471) Increase the number of dims for KNN vectors to 2048

2022-07-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566874#comment-17566874 ] Robert Muir commented on LUCENE-10471: -- The problem is that nobody will ever want

[GitHub] [lucene-jira-archive] mikemccand commented on issue #37: Why are some Jira issues completely missing?

2022-07-14 Thread GitBox
mikemccand commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1184566701 Egads that is wild ;) It seems like the use case is to start all issues from a bigger number than 1? Yet, we started at 1, but then have the occasional hole! Maybe INF

[GitHub] [lucene-jira-archive] msokolov commented on issue #37: Why are some Jira issues completely missing?

2022-07-14 Thread GitBox
msokolov commented on issue #37: URL: https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1184593659 I mean it seems unlikely -- why would anyone ever do that? But I guess it demonstrates that there is some mechanism for arbitrarily repositioning the "next issue number", s

[jira] [Commented] (LUCENE-10471) Increase the number of dims for KNN vectors to 2048

2022-07-14 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566962#comment-17566962 ] Mayya Sharipova commented on LUCENE-10471: -- Got it, thanks, I will not rush, a

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #34: Add a tool to generate account mapping

2022-07-14 Thread GitBox
mocobeta commented on PR #34: URL: https://github.com/apache/lucene-jira-archive/pull/34#issuecomment-1185056362 I committed a candidate mapping file (without any manual checks/editing). https://github.com/apache/lucene-jira-archive/pull/34/commits/e336bdce6bf5eff7404c465e495a094f2b8f066f

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #34: Add a tool to generate account mapping

2022-07-14 Thread GitBox
mocobeta commented on PR #34: URL: https://github.com/apache/lucene-jira-archive/pull/34#issuecomment-1185079513 As other possible clues, we could - list ASF organization members and infer committers' accounts that cannot be detected by display/full names - 18 committers still do n

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #34: Add a tool to generate account mapping

2022-07-14 Thread GitBox
mocobeta commented on PR #34: URL: https://github.com/apache/lucene-jira-archive/pull/34#issuecomment-1185194467 This is the list of accounts that have push access to apache/lucene (i.e., committers' accounts) https://github.com/apache/lucene-jira-archive/pull/34/commits/b04318ef5daf443

[GitHub] [lucene] LuXugang commented on a diff in pull request #1021: LUCENE-10603: Remove SSDV#NO_MORE_ORDS definition

2022-07-14 Thread GitBox
LuXugang commented on code in PR #1021: URL: https://github.com/apache/lucene/pull/1021#discussion_r921847372 ## lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java: ## @@ -391,11 +386,7 @@ public boolean advanceExact(int target) throws IOException {

[GitHub] [lucene] LuXugang commented on a diff in pull request #1021: LUCENE-10603: Remove SSDV#NO_MORE_ORDS definition

2022-07-14 Thread GitBox
LuXugang commented on code in PR #1021: URL: https://github.com/apache/lucene/pull/1021#discussion_r921847372 ## lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java: ## @@ -391,11 +386,7 @@ public boolean advanceExact(int target) throws IOException {