jpountz commented on PR #972:
URL: https://github.com/apache/lucene/pull/972#issuecomment-1164220705
The fact that queries perform slower in general in your first benchmark run
makes me wonder if this could be due to insufficient warmup time. The default
task repeat count of 20 might be too
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558029#comment-17558029
]
Michael McCandless commented on LUCENE-10557:
-
Finally catching up over her
gsmiller commented on PR #964:
URL: https://github.com/apache/lucene/pull/964#issuecomment-1164336774
@jpountz ah right. No, I don’t think it makes sense for users to have to
deal with creating weights on their own (and having to consider query rewriting
as well before doing so). Your appro
[
https://issues.apache.org/jira/browse/LUCENE-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558093#comment-17558093
]
Alessandro Benedetti commented on LUCENE-10593:
---
Hi @msokolov @mayya-shar
[
https://issues.apache.org/jira/browse/LUCENE-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558093#comment-17558093
]
Alessandro Benedetti edited comment on LUCENE-10593 at 6/23/22 1:34 PM:
-
msokolov commented on PR #926:
URL: https://github.com/apache/lucene/pull/926#issuecomment-1164418508
Hi Alessandro, thank you for running the tests. I'm suspicious of the
results though -- they just look too good to be true! I know from profiling
that we spend most of the time in similarit
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558097#comment-17558097
]
Tomoko Uchida commented on LUCENE-10557:
I'm still not fully sure if we can/sho
msokolov commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r905035144
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##
@@ -246,7 +246,7 @@ private boolean diversityCheck(
for (int i = 0; i < neighbors.size()
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r905042674
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##
@@ -246,7 +246,7 @@ private boolean diversityCheck(
for (int i = 0; i < neigh
jpountz commented on PR #972:
URL: https://github.com/apache/lucene/pull/972#issuecomment-1164436120
@zacharymorn FYI I played with a slightly different approach that implements
BMM as a bulk scorer instead of a scorer, which I was hoping would help with
making bookkeeping more lightweight:
[
https://issues.apache.org/jira/browse/LUCENE-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558103#comment-17558103
]
Ignacio Vera commented on LUCENE-10396:
---
I have been thinking on the ability if v
kaivalnp commented on code in PR #951:
URL: https://github.com/apache/lucene/pull/951#discussion_r905065952
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -92,20 +91,40 @@ public KnnVectorQuery(String field, float[] target, int k,
Query filter) {
kaivalnp commented on PR #951:
URL: https://github.com/apache/lucene/pull/951#issuecomment-1164455602
Thank you! I have added this approach to the latest commit, and a suggestion
to incorporate deletes above
--
This is an automated message from the Apache Git Service.
To respond to the me
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r905082182
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##
@@ -246,7 +246,7 @@ private boolean diversityCheck(
for (int i = 0; i < neigh
[
https://issues.apache.org/jira/browse/LUCENE-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558103#comment-17558103
]
Ignacio Vera edited comment on LUCENE-10396 at 6/23/22 3:01 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-9580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558127#comment-17558127
]
Hugo Mercier commented on LUCENE-9580:
--
I've encountered the same issue on Elastics
alessandrobenedetti commented on PR #926:
URL: https://github.com/apache/lucene/pull/926#issuecomment-1164571753
@msokolov your input has been invaluable!
I run the tests on the same machine, with the preprocessed files and now the
results are different.
The main and this branch presen
[ https://issues.apache.org/jira/browse/LUCENE-10593 ]
Alessandro Benedetti deleted comment on LUCENE-10593:
---
was (Author: alessandro.benedetti):
Hi @msokolov @mayya-sharipova and @jtibshirani , I have finally finished my
performance
[
https://issues.apache.org/jira/browse/LUCENE-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558141#comment-17558141
]
Alessandro Benedetti commented on LUCENE-10593:
---
Recent performance tests
jpountz commented on PR #964:
URL: https://github.com/apache/lucene/pull/964#issuecomment-1164586245
Thanks for taking the time to think about it @gsmiller, appreciated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jpountz merged PR #964:
URL: https://github.com/apache/lucene/pull/964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
[
https://issues.apache.org/jira/browse/LUCENE-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558151#comment-17558151
]
ASF subversion and git services commented on LUCENE-10620:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10620.
---
Fix Version/s: 9.3
Resolution: Fixed
> Can we pass the Weight to Collector?
> --
jtibshirani commented on code in PR #951:
URL: https://github.com/apache/lucene/pull/951#discussion_r905236130
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -92,20 +91,40 @@ public KnnVectorQuery(String field, float[] target, int k,
Query filter) {
jtibshirani commented on PR #951:
URL: https://github.com/apache/lucene/pull/951#issuecomment-1164628757
The latest approach looks good to me. Are you still seeing a significant
latency improvement in some cases?
--
This is an automated message from the Apache Git Service.
To respond to t
mdmarshmallow commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1164640793
Yeah, I think this change should be completely compatible with 9.30. Most of
our changes are isolated to the new `facetset` package and all other changes
are just adding some functions
Peter Gromov created LUCENE-10626:
-
Summary: Hunspell: add tools to aid dictionary editing: analysis
introspection, stem expansion and stem/flag suggestion
Key: LUCENE-10626
URL: https://issues.apache.org/jira/bro
donnerpeter opened a new pull request, #975:
URL: https://github.com/apache/lucene/pull/975
https://issues.apache.org/jira/browse/LUCENE-10626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
donnerpeter commented on PR #975:
URL: https://github.com/apache/lucene/pull/975#issuecomment-1164800989
Reviewing commits separately might be easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kaivalnp commented on PR #951:
URL: https://github.com/apache/lucene/pull/951#issuecomment-1164860104
Yes, I saw similar improvement for `BitSet` backed queries as the numbers
[here](https://github.com/apache/lucene/pull/932)
--
This is an automated message from the Apache Git Service.
To
shahrs87 commented on code in PR #907:
URL: https://github.com/apache/lucene/pull/907#discussion_r905458119
##
lucene/core/src/java/org/apache/lucene/index/CheckIndex.java:
##
@@ -1378,7 +1378,7 @@ private static Status.TermIndexStatus checkFields(
computedFieldCount++;
shahrs87 commented on code in PR #907:
URL: https://github.com/apache/lucene/pull/907#discussion_r905561688
##
lucene/core/src/java/org/apache/lucene/index/FrozenBufferedUpdates.java:
##
@@ -595,7 +595,7 @@ private void setField(String field) throws IOException {
DocIdSet
[
https://issues.apache.org/jira/browse/LUCENE-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558247#comment-17558247
]
Weiming Wu commented on LUCENE-10624:
-
Hi Adrien. Thanks for your comments!
For
[
https://issues.apache.org/jira/browse/LUCENE-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558247#comment-17558247
]
Weiming Wu edited comment on LUCENE-10624 at 6/23/22 10:46 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558263#comment-17558263
]
Michael McCandless commented on LUCENE-10557:
-
{quote}I'm still not fully s
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558318#comment-17558318
]
Tomoko Uchida commented on LUCENE-10557:
Seems converting Jira "table" markup t
[
https://issues.apache.org/jira/browse/LUCENE-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weiming Wu updated LUCENE-10624:
Attachment: candiate-exponential-searchsparse-sorted.0.log
> Binary Search for Sparse IndexedDISI
zacharymorn commented on PR #968:
URL: https://github.com/apache/lucene/pull/968#issuecomment-1165214328
Hmm I see. I'm actually also wondering if it will be possible to have one of
them simply delegate to the other one (potentially indirectly via some helper
method), and then check the ret
zacharymorn commented on PR #972:
URL: https://github.com/apache/lucene/pull/972#issuecomment-1165218655
Thanks @jpountz for the suggestion and also providing the bulk scorer
implementation! The result looks pretty impressive as well!
I just tried `taskRepeatCount=200` with my implem
dweiss commented on PR #975:
URL: https://github.com/apache/lucene/pull/975#issuecomment-1165237503
Hi Peter! I'll take a look later today - it's end-of-school in Poland today
and it's a bit hectic.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
40 matches
Mail list logo
