[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-18 Thread GitBox
shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1159391170 > I don't think so? `FSD` is currently about decoding the encoded `byte[]` into a `long[]` for `FacetSetMatcher` purposes. Strike that, you're absolutely right! I think tests pass only b

[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-18 Thread GitBox
shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1159392950 > Also, should we add `double` and `float` methods to `FacetSetDecoder`? I thought I answered wrongly but I didn't. To clarify, we encode `double` as sortable longs, and therefore use `d

[GitHub] [lucene] tang-hi opened a new pull request, #966: LUCENE-10619: Optimize the writeBytes in TermsHashPerField

2022-06-18 Thread GitBox
tang-hi opened a new pull request, #966: URL: https://github.com/apache/lucene/pull/966 ### Description (or a Jira issue link if you have one) https://issues.apache.org/jira/projects/LUCENE/issues/LUCENE-10619?filter=allopenissues when bytes length is large, write a block of bytes

[jira] [Commented] (LUCENE-10619) Optimize the writeBytes in TermsHashPerField

2022-06-18 Thread tangdh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555882#comment-17555882 ] tangdh commented on LUCENE-10619: - hi [~jpountz] ,I have raised a [PR|https://github.co

[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-18 Thread GitBox
shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1159454008 I pushed a commit which: 1. Adds demo code for a `TemperatureReading` `FacetSet` and `FacetSetMatcher`. 2. Modifies the existing Exact and Range matcher float/double tests to properl

[GitHub] [lucene] vigyasharma commented on a diff in pull request #966: LUCENE-10619: Optimize the writeBytes in TermsHashPerField

2022-06-18 Thread GitBox
vigyasharma commented on code in PR #966: URL: https://github.com/apache/lucene/pull/966#discussion_r901031392 ## lucene/core/src/java/org/apache/lucene/index/TermsHashPerField.java: ## @@ -230,9 +230,29 @@ final void writeByte(int stream, byte b) { } final void writeByt

[GitHub] [lucene] tang-hi commented on a diff in pull request #966: LUCENE-10619: Optimize the writeBytes in TermsHashPerField

2022-06-18 Thread GitBox
tang-hi commented on code in PR #966: URL: https://github.com/apache/lucene/pull/966#discussion_r901039033 ## lucene/core/src/java/org/apache/lucene/index/TermsHashPerField.java: ## @@ -230,9 +230,29 @@ final void writeByte(int stream, byte b) { } final void writeBytes(i

[GitHub] [lucene] tang-hi commented on a diff in pull request #966: LUCENE-10619: Optimize the writeBytes in TermsHashPerField

2022-06-18 Thread GitBox
tang-hi commented on code in PR #966: URL: https://github.com/apache/lucene/pull/966#discussion_r901039371 ## lucene/core/src/java/org/apache/lucene/index/TermsHashPerField.java: ## @@ -230,9 +230,29 @@ final void writeByte(int stream, byte b) { } final void writeBytes(i

[GitHub] [lucene] vigyasharma commented on a diff in pull request #966: LUCENE-10619: Optimize the writeBytes in TermsHashPerField

2022-06-18 Thread GitBox
vigyasharma commented on code in PR #966: URL: https://github.com/apache/lucene/pull/966#discussion_r901050635 ## lucene/core/src/java/org/apache/lucene/index/TermsHashPerField.java: ## @@ -230,9 +230,29 @@ final void writeByte(int stream, byte b) { } final void writeByt

[GitHub] [lucene] tang-hi commented on a diff in pull request #966: LUCENE-10619: Optimize the writeBytes in TermsHashPerField

2022-06-18 Thread GitBox
tang-hi commented on code in PR #966: URL: https://github.com/apache/lucene/pull/966#discussion_r901054938 ## lucene/core/src/java/org/apache/lucene/index/TermsHashPerField.java: ## @@ -230,9 +230,29 @@ final void writeByte(int stream, byte b) { } final void writeBytes(i