gautamworah96 opened a new pull request, #922:
URL: https://github.com/apache/lucene/pull/922
### Description (or a Jira issue link if you have one)
Change the index option for FacetField to just index the DOCS and not the
frequencies and offsets (we don't use these values). I still n
[
https://issues.apache.org/jira/browse/LUCENE-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-10586.
Fix Version/s: 9.3
Assignee: Tomoko Uchida
Resolution: Fixed
Thank you bo
mocobeta opened a new pull request, #923:
URL: https://github.com/apache/lucene/pull/923
### Description (or a Jira issue link if you have one)
This is a minor update for `demo` module documentation.
I had a chance to run the demo app and noticed that commands in the tutorial
use `
mocobeta commented on PR #923:
URL: https://github.com/apache/lucene/pull/923#issuecomment-1135776812
note: `modules-thirdparty` should be included on the module path since it
depends on `hppc` via `lucene-facet`. Also it seems good to add `--add-modules
jdk.unsupported` when running `Searc
msokolov commented on PR #923:
URL: https://github.com/apache/lucene/pull/923#issuecomment-1135853409
I found a few typos; if you have a moment maybe you could fix while you're
updating?
I'm also curious - is it still possible to use the old way (with CLASSPATH /
-cp)? Also, is MODUL
mocobeta commented on PR #923:
URL: https://github.com/apache/lucene/pull/923#issuecomment-1135877621
> Also, is MODULEPATH an environment variable like CLASSPATH?
Thanks, it's a very good point; to the best of my knowledge, there is no
environment variable to implicitly set module
ywelsch commented on code in PR #910:
URL: https://github.com/apache/lucene/pull/910#discussion_r880463557
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestCombinedFieldQuery.java:
##
@@ -589,4 +589,52 @@ public SimScorer scorer(
return new BM25Similarity()
ywelsch commented on code in PR #910:
URL: https://github.com/apache/lucene/pull/910#discussion_r880465199
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestCombinedFieldQuery.java:
##
@@ -589,4 +589,52 @@ public SimScorer scorer(
return new BM25Similarity()
ywelsch commented on code in PR #910:
URL: https://github.com/apache/lucene/pull/910#discussion_r880465450
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestCombinedFieldQuery.java:
##
@@ -589,4 +589,52 @@ public SimScorer scorer(
return new BM25Similarity()
mocobeta commented on PR #923:
URL: https://github.com/apache/lucene/pull/923#issuecomment-1135898983
> I guess the previous documentation didn't really explain how to set the
CLASSPATH, but given that MODULEPATH is a new thing and many users may be
unfamiliar with it, maybe we should take
mocobeta commented on PR #920:
URL: https://github.com/apache/lucene/pull/920#issuecomment-1135958878
@jtibshirani thanks for reviewing.
> Stepping through what happens, it looks like we just hit a really unlucky
query + data combination where it takes more than 150 steps to conclude
msokolov commented on PR #923:
URL: https://github.com/apache/lucene/pull/923#issuecomment-1136012481
>> I found a few typos; if you have a moment maybe you could fix while
you're updating?
> Sure, could you tell me the lines we should fix?
Hmm I added comments above, but
msokolov commented on code in PR #923:
URL: https://github.com/apache/lucene/pull/923#discussion_r880432441
##
lucene/demo/src/java/overview.html:
##
@@ -49,36 +49,35 @@ About the Demo
demonstrates various functionalities of Lucene and how you can add Lucene to
your applicatio
[
https://issues.apache.org/jira/browse/LUCENE-10385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-10385.
Resolution: Fixed
> Implement Weight#count on IndexSortSortedNumericDocValuesRangeQuery.
[
https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-10229.
Resolution: Fixed
> Match offsets should be consistent for fields with positions and fiel
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541583#comment-17541583
]
Michael Sokolov commented on LUCENE-10577:
--
Question: should I post one commi
[
https://issues.apache.org/jira/browse/LUCENE-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541620#comment-17541620
]
Adrien Grand commented on LUCENE-10590:
---
Does the indexing logic rely on tie brea
msokolov opened a new pull request, #924:
URL: https://github.com/apache/lucene/pull/924
I want to do this in order to enable changes in the HnswVectorsFormat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541621#comment-17541621
]
Michael Sokolov commented on LUCENE-10577:
--
https://github.com/apache/lucene/p
jpountz commented on code in PR #907:
URL: https://github.com/apache/lucene/pull/907#discussion_r880758668
##
lucene/core/src/java/org/apache/lucene/index/MappedMultiFields.java:
##
@@ -43,8 +43,8 @@ public MappedMultiFields(MergeState mergeState, MultiFields
multiFields) {
jpountz commented on code in PR #897:
URL: https://github.com/apache/lucene/pull/897#discussion_r880768892
##
lucene/core/src/java/org/apache/lucene/document/NearestNeighbor.java:
##
@@ -220,7 +216,7 @@ public Relation compare(byte[] minPackedValue, byte[]
maxPackedValue) {
gsmiller commented on PR #922:
URL: https://github.com/apache/lucene/pull/922#issuecomment-1136295588
I'm not actually sure these options are referenced/honored anywhere during
indexing, which might explain why you don't see a difference. Maybe you've dug
into this deeper and know better, b
janhoy opened a new pull request, #2661:
URL: https://github.com/apache/lucene-solr/pull/2661
https://issues.apache.org/jira/browse/SOLR-16213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
msokolov commented on PR #924:
URL: https://github.com/apache/lucene/pull/924#issuecomment-1136470133
In case it wasn't clear this is literally just bumping the version numbers
and doing the requisite copy/paste to get all the symbols to resolve properly,
and tests to pass
--
This is an
jtibshirani commented on code in PR #910:
URL: https://github.com/apache/lucene/pull/910#discussion_r881050412
##
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestCombinedFieldQuery.java:
##
@@ -589,4 +589,97 @@ public SimScorer scorer(
return new BM25Similari
jtibshirani commented on PR #924:
URL: https://github.com/apache/lucene/pull/924#issuecomment-1136525898
I think you may have forgotten to create unit tests for the old format (step
2 here:
https://github.com/apache/lucene/tree/main/lucene/backward-codecs#making-index-format-changes).
Also
madrob commented on PR #2661:
URL: https://github.com/apache/lucene-solr/pull/2661#issuecomment-1136629649
Can we make a changes entry? I think there was already one for a previous
Jackson upgrade in this release (phone commenting so can't easily verify)
--
This is an automated message fr
LuXugang commented on PR #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1136706160
It seems like the core part is how to avoid that all vector values of all
fields loaded into memory during Indexing. IIUC, as @rmuir said, we could
stream vectors to the codec api directly.
gsmiller commented on PR #915:
URL: https://github.com/apache/lucene/pull/915#issuecomment-1136707326
Thanks @Yuti-G for the feedback and benchmark results! I appreciate you
taking a look since I know you're quite familiar with this code. I saw a couple
opportunities to de-dupe some code, b
gsmiller commented on code in PR #915:
URL: https://github.com/apache/lucene/pull/915#discussion_r881201779
##
lucene/facet/src/java/org/apache/lucene/facet/sortedset/AbstractSortedSetDocValueFacetCounts.java:
##
@@ -0,0 +1,333 @@
+/*
+ * Licensed to the Apache Software Foundati
30 matches
Mail list logo
