[jira] [Commented] (LUCENE-10292) AnalyzingInfixSuggester thread safety: lookup() fails during (re)build()

2022-04-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529831#comment-17529831 ] Dawid Weiss commented on LUCENE-10292: -- > All I was really trying to do with these

[GitHub] [lucene] dweiss commented on pull request #850: LUCENE-10541: limit the default length of MockTokenizer tokens to 255.

2022-04-29 Thread GitBox
dweiss commented on PR #850: URL: https://github.com/apache/lucene/pull/850#issuecomment-1112959221 Thanks @mocobeta ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[jira] [Commented] (LUCENE-10541) What to do about massive terms in our Wikipedia EN LineFileDocs?

2022-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529837#comment-17529837 ] ASF subversion and git services commented on LUCENE-10541: -- Co

[jira] [Commented] (LUCENE-10541) What to do about massive terms in our Wikipedia EN LineFileDocs?

2022-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529839#comment-17529839 ] ASF subversion and git services commented on LUCENE-10541: -- Co

[jira] [Commented] (LUCENE-10541) What to do about massive terms in our Wikipedia EN LineFileDocs?

2022-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529844#comment-17529844 ] ASF subversion and git services commented on LUCENE-10541: -- Co

[GitHub] [lucene] dweiss commented on pull request #850: LUCENE-10541: limit the default length of MockTokenizer tokens to 255.

2022-04-29 Thread GitBox
dweiss commented on PR #850: URL: https://github.com/apache/lucene/pull/850#issuecomment-1112986527 I've applied this patch on main, branch_9x and branch_9_1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [lucene] dweiss closed pull request #850: LUCENE-10541: limit the default length of MockTokenizer tokens to 255.

2022-04-29 Thread GitBox
dweiss closed pull request #850: LUCENE-10541: limit the default length of MockTokenizer tokens to 255. URL: https://github.com/apache/lucene/pull/850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (LUCENE-10541) What to do about massive terms in our Wikipedia EN LineFileDocs?

2022-04-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529845#comment-17529845 ] Dawid Weiss commented on LUCENE-10541: -- I've applied the PR - we can close this is

[GitHub] [lucene] iverase opened a new pull request, #855: Use MIN_WIDE_EXTENT for GeoWideDegenerateHorizontalLine

2022-04-29 Thread GitBox
iverase opened a new pull request, #855: URL: https://github.com/apache/lucene/pull/855 Follow up of https://github.com/apache/lucene/pull/845 where I miss GeoWideDegenerateHorizontalLine. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [lucene] iverase merged pull request #855: LUCENE-10508: Use MIN_WIDE_EXTENT for GeoWideDegenerateHorizontalLine

2022-04-29 Thread GitBox
iverase merged PR #855: URL: https://github.com/apache/lucene/pull/855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[jira] [Commented] (LUCENE-10508) GeoArea failure with degenerated latitude

2022-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529853#comment-17529853 ] ASF subversion and git services commented on LUCENE-10508: -- Co

[jira] [Commented] (LUCENE-10508) GeoArea failure with degenerated latitude

2022-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529854#comment-17529854 ] ASF subversion and git services commented on LUCENE-10508: -- Co

[GitHub] [lucene] dweiss commented on pull request #844: LUCENE-10539: Return a stream of completions from FSTCompletion.

2022-04-29 Thread GitBox
dweiss commented on PR #844: URL: https://github.com/apache/lucene/pull/844#issuecomment-1113025766 I plan to commit this in if there are no objections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-10544) Should ExitableTermsEnum wrap postings and impacts?

2022-04-29 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529875#comment-17529875 ] Adrien Grand commented on LUCENE-10544: --- Right, conjunctions of high-frequency cl

[GitHub] [lucene] mikemccand commented on a diff in pull request #853: LUCENE-10524 Add benchmark suite details to CONTRIBUTING.md

2022-04-29 Thread GitBox
mikemccand commented on code in PR #853: URL: https://github.com/apache/lucene/pull/853#discussion_r861733565 ## CONTRIBUTING.md: ## @@ -66,6 +66,16 @@ In case your contribution fixes a bug, please create a new test case that fails - *Eclipse* - Basic support ([help/IDEs.txt

[GitHub] [lucene] mocobeta commented on pull request #854: LUCENE-10545: allow to link github pr from changes

2022-04-29 Thread GitBox
mocobeta commented on PR #854: URL: https://github.com/apache/lucene/pull/854#issuecomment-1113258104 @rmuir Thanks for confirming. I'd love to commit this in and simplify the contribution workflow. I plan to make a post to the dev list to let others know about this change. -- This

[jira] [Commented] (LUCENE-10544) Should ExitableTermsEnum wrap postings and impacts?

2022-04-29 Thread Deepika Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529965#comment-17529965 ] Deepika Sharma commented on LUCENE-10544: - Yeah, I think you’re right [~jpountz

[GitHub] [lucene] dweiss commented on pull request #856: gradle 7.3.3 quick upgrade

2022-04-29 Thread GitBox
dweiss commented on PR #856: URL: https://github.com/apache/lucene/pull/856#issuecomment-1113307043 Thanks. This is a quick try to help Tobias Hartman who gets a very strange exception when running gradlew with (Oracle) Java 17. Doesn't help though. :( Uwe knows more. https://bugs.op

[jira] [Commented] (LUCENE-10544) Should ExitableTermsEnum wrap postings and impacts?

2022-04-29 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1753#comment-1753 ] Greg Miller commented on LUCENE-10544: -- {quote}In my opinion, a better solution th

[GitHub] [lucene] rmuir commented on pull request #856: gradle 7.3.3 quick upgrade

2022-04-29 Thread GitBox
rmuir commented on PR #856: URL: https://github.com/apache/lucene/pull/856#issuecomment-1113334476 yeah, i saw his struggles on the ticket. groovy strikes again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] gsmiller commented on pull request #843: LUCENE-10538: TopN is not being used in getTopChildren in RangeFacetCounts

2022-04-29 Thread GitBox
gsmiller commented on PR #843: URL: https://github.com/apache/lucene/pull/843#issuecomment-1113335265 @Yuti-G thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (LUCENE-10546) Update Faceting user guide

2022-04-29 Thread Greg Miller (Jira)
Greg Miller created LUCENE-10546: Summary: Update Faceting user guide Key: LUCENE-10546 URL: https://issues.apache.org/jira/browse/LUCENE-10546 Project: Lucene - Core Issue Type: Wish

[GitHub] [lucene] janhoy commented on a diff in pull request #854: LUCENE-10545: allow to link github pr from changes

2022-04-29 Thread GitBox
janhoy commented on code in PR #854: URL: https://github.com/apache/lucene/pull/854#discussion_r861861134 ## lucene/CHANGES.txt: ## @@ -53,7 +53,7 @@ Other * LUCENE-10253: The @BadApple annotation has been removed from the test framework. (Adrien Grand) -* LUCENE-10393: Un

[jira] [Created] (LUCENE-10547) Implement "flattened" Facets#getTopChildren

2022-04-29 Thread Greg Miller (Jira)
Greg Miller created LUCENE-10547: Summary: Implement "flattened" Facets#getTopChildren Key: LUCENE-10547 URL: https://issues.apache.org/jira/browse/LUCENE-10547 Project: Lucene - Core Issue T

[GitHub] [lucene] gsmiller commented on pull request #848: LUCENE-10530: Avoid floating point precision bug in TestTaxonomyFacetAssociations

2022-04-29 Thread GitBox
gsmiller commented on PR #848: URL: https://github.com/apache/lucene/pull/848#issuecomment-1113476269 Since it doesn't look like there's any opposition to the approach I took in fixing this, and since this is a test case bug that is occasionally showing up and would be good to address soon,

[GitHub] [lucene] gsmiller merged pull request #848: LUCENE-10530: Avoid floating point precision bug in TestTaxonomyFacetAssociations

2022-04-29 Thread GitBox
gsmiller merged PR #848: URL: https://github.com/apache/lucene/pull/848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[jira] [Commented] (LUCENE-10530) TestTaxonomyFacetAssociations test failure

2022-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530075#comment-17530075 ] ASF subversion and git services commented on LUCENE-10530: -- Co

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #842: LUCENE-10518: Relax field consistency check for old indices

2022-04-29 Thread GitBox
mayya-sharipova commented on code in PR #842: URL: https://github.com/apache/lucene/pull/842#discussion_r861981910 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -178,7 +179,15 @@ public static FieldInfos getMergedFieldInfos(IndexReader reader) {

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #842: LUCENE-10518: Relax field consistency check for old indices

2022-04-29 Thread GitBox
mayya-sharipova commented on code in PR #842: URL: https://github.com/apache/lucene/pull/842#discussion_r861981910 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -178,7 +179,15 @@ public static FieldInfos getMergedFieldInfos(IndexReader reader) {

[GitHub] [lucene] gsmiller commented on pull request #849: LUCENE-10530: Avoid floating point precision bug in TestTaxonomyFacetAssociations

2022-04-29 Thread GitBox
gsmiller commented on PR #849: URL: https://github.com/apache/lucene/pull/849#issuecomment-1113534664 Going ahead and merging since there didn't seem to be any major feedback on the approach and there are occasional test failures due to this. Happy to revisit the solution if anyone has furt

[GitHub] [lucene] gsmiller merged pull request #849: LUCENE-10530: Avoid floating point precision bug in TestTaxonomyFacetAssociations

2022-04-29 Thread GitBox
gsmiller merged PR #849: URL: https://github.com/apache/lucene/pull/849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[jira] [Commented] (LUCENE-10530) TestTaxonomyFacetAssociations test failure

2022-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530133#comment-17530133 ] ASF subversion and git services commented on LUCENE-10530: -- Co

[jira] [Resolved] (LUCENE-10529) TestTaxonomyFacetAssociations may have floating point issues

2022-04-29 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10529. -- Fix Version/s: 10.0 (main) 9.2 Resolution: Fixed > TestTaxonomyFace

[jira] [Resolved] (LUCENE-10530) TestTaxonomyFacetAssociations test failure

2022-04-29 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10530. -- Fix Version/s: 10.0 (main) 9.2 Resolution: Fixed > TestTaxonomyFace

[GitHub] [lucene] msokolov commented on a diff in pull request #854: LUCENE-10545: allow to link github pr from changes

2022-04-29 Thread GitBox
msokolov commented on code in PR #854: URL: https://github.com/apache/lucene/pull/854#discussion_r861995439 ## gradle/documentation/changes-to-html/changes2html.pl: ## @@ -572,7 +572,7 @@ $item =~ s{((LUCENE|SOLR|INFRA)\s+(\d{3,}))} {$1}gi; # Link

[jira] [Updated] (LUCENE-10542) FieldSource exists implementation can avoid value retrieval

2022-04-29 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated LUCENE-10542: -- Description: While looking at LUCENE-10534, found that *FieldSource exists implementation af

[jira] [Comment Edited] (LUCENE-10534) MinFloatFunction / MaxFloatFunction exists check can be slow

2022-04-29 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529572#comment-17529572 ] Kevin Risden edited comment on LUCENE-10534 at 4/29/22 5:15 PM: -

[jira] [Commented] (LUCENE-10542) FieldSource exists implementation can avoid value retrieval

2022-04-29 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530141#comment-17530141 ] Kevin Risden commented on LUCENE-10542: --- Thanks [~rcmuir] thats a good idea. > F

[jira] [Commented] (LUCENE-10541) What to do about massive terms in our Wikipedia EN LineFileDocs?

2022-04-29 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530144#comment-17530144 ] Michael Sokolov commented on LUCENE-10541: -- I think the probability of choosin

[GitHub] [lucene] msokolov commented on a diff in pull request #844: LUCENE-10539: Return a stream of completions from FSTCompletion.

2022-04-29 Thread GitBox
msokolov commented on code in PR #844: URL: https://github.com/apache/lucene/pull/844#discussion_r862001926 ## lucene/suggest/src/java/org/apache/lucene/search/suggest/fst/FSTCompletion.java: ## @@ -184,110 +195,174 @@ public List lookup(CharSequence key, int num) { retu

[GitHub] [lucene-solr] magibney commented on pull request #989: SOLR-12457: improve compatibility/support for sort by field-function

2022-04-29 Thread GitBox
magibney commented on PR #989: URL: https://github.com/apache/lucene-solr/pull/989#issuecomment-1113580029 Superseded by: https://github.com/apache/solr/pull/828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-solr] magibney closed pull request #989: SOLR-12457: improve compatibility/support for sort by field-function

2022-04-29 Thread GitBox
magibney closed pull request #989: SOLR-12457: improve compatibility/support for sort by field-function URL: https://github.com/apache/lucene-solr/pull/989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (LUCENE-10534) MinFloatFunction / MaxFloatFunction calls exists twice

2022-04-29 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated LUCENE-10534: -- Summary: MinFloatFunction / MaxFloatFunction calls exists twice (was: MinFloatFunction / Max

[jira] [Updated] (LUCENE-10534) MinFloatFunction / MaxFloatFunction exists check can be slow

2022-04-29 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated LUCENE-10534: -- Description: MinFloatFunction (https://github.com/apache/lucene/blob/main/lucene/queries/src/

[jira] [Updated] (LUCENE-10534) MinFloatFunction / MaxFloatFunction calls exists twice

2022-04-29 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated LUCENE-10534: -- Description: MinFloatFunction (https://github.com/apache/lucene/blob/main/lucene/queries/src

[jira] [Created] (LUCENE-10548) Weird errors launching gradlew (Caused by: groovy.lang.MissingMethodException: No signature of method: java.lang.Object.clone() is applicable for argument types: () val

2022-04-29 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10548: Summary: Weird errors launching gradlew (Caused by: groovy.lang.MissingMethodException: No signature of method: java.lang.Object.clone() is applicable for argument types: () values: []) Key: LUCE

[jira] [Created] (LUCENE-10549) Upgrade to gradle 7.3.3

2022-04-29 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10549: Summary: Upgrade to gradle 7.3.3 Key: LUCENE-10549 URL: https://issues.apache.org/jira/browse/LUCENE-10549 Project: Lucene - Core Issue Type: Improvement

[GitHub] [lucene] dweiss merged pull request #856: LUCENE-10549: upgrade gradle to 7.3.3

2022-04-29 Thread GitBox
dweiss merged PR #856: URL: https://github.com/apache/lucene/pull/856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.o

[jira] [Resolved] (LUCENE-10549) Upgrade to gradle 7.3.3

2022-04-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10549. -- Fix Version/s: 9.2 Resolution: Fixed > Upgrade to gradle 7.3.3 > -

[jira] [Updated] (LUCENE-10549) Upgrade to gradle 7.3.3

2022-04-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10549: - Fix Version/s: 9.1.1 > Upgrade to gradle 7.3.3 > --- > > Ke

[jira] [Updated] (LUCENE-10549) Upgrade to gradle 7.3.3

2022-04-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10549: - Fix Version/s: 10.0 (main) > Upgrade to gradle 7.3.3 > --- > >

[GitHub] [lucene] dweiss commented on pull request #857: LUCENE-10548: Weird errors launching gradlew

2022-04-29 Thread GitBox
dweiss commented on PR #857: URL: https://github.com/apache/lucene/pull/857#issuecomment-1113654041 I've moved this class to buildSrc so that it's precompiled before the scripts and removed the Cloneable interface. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (LUCENE-10548) Weird errors launching gradlew (Caused by: groovy.lang.MissingMethodException: No signature of method: java.lang.Object.clone() is applicable for argument types: () v

2022-04-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530204#comment-17530204 ] Dawid Weiss commented on LUCENE-10548: -- A PR is here (and on the source branch in

[GitHub] [lucene] dweiss merged pull request #844: LUCENE-10539: Return a stream of completions from FSTCompletion.

2022-04-29 Thread GitBox
dweiss merged PR #844: URL: https://github.com/apache/lucene/pull/844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.o

[GitHub] [lucene] dweiss commented on pull request #844: LUCENE-10539: Return a stream of completions from FSTCompletion.

2022-04-29 Thread GitBox
dweiss commented on PR #844: URL: https://github.com/apache/lucene/pull/844#issuecomment-1113657203 Thanks @msokolov ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[jira] [Commented] (LUCENE-10539) Return a stream of completions from FSTCompletion

2022-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530209#comment-17530209 ] ASF subversion and git services commented on LUCENE-10539: -- Co

[jira] [Resolved] (LUCENE-10539) Return a stream of completions from FSTCompletion

2022-04-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10539. -- Resolution: Fixed > Return a stream of completions from FSTCompletion > -

[jira] [Commented] (LUCENE-10539) Return a stream of completions from FSTCompletion

2022-04-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530211#comment-17530211 ] Dawid Weiss commented on LUCENE-10539: -- I applied to branch_9x and main. > Return

[jira] [Created] (LUCENE-10550) Add getAllChildren functionality to facets

2022-04-29 Thread Yuting Gan (Jira)
Yuting Gan created LUCENE-10550: --- Summary: Add getAllChildren functionality to facets Key: LUCENE-10550 URL: https://issues.apache.org/jira/browse/LUCENE-10550 Project: Lucene - Core Issue Type

[jira] [Commented] (LUCENE-10538) TopN is not being used in getTopChildren()

2022-04-29 Thread Yuting Gan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530229#comment-17530229 ] Yuting Gan commented on LUCENE-10538: - Created a related issue [LUCENE-10550|https

[GitHub] [lucene] vigyasharma commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-04-29 Thread GitBox
vigyasharma commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r862140049 ## lucene/core/src/test/org/apache/lucene/index/TestAddIndexes.java: ## @@ -1014,8 +1304,6 @@ public void testAddIndexesWithRollback() throws Throwable { }

[GitHub] [lucene] vigyasharma commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-04-29 Thread GitBox
vigyasharma commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r862140381 ## lucene/core/src/test/org/apache/lucene/index/TestIndexWriterOnDiskFull.java: ## @@ -352,15 +352,15 @@ public void testAddIndexOnDiskFull() throws IOException {

[GitHub] [lucene] vigyasharma commented on pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-04-29 Thread GitBox
vigyasharma commented on PR #633: URL: https://github.com/apache/lucene/pull/633#issuecomment-1113715276 Updated the `MockRandomMergePolicy` to randomly use the more concurrent version of `findMerges(CodecReaders[])` with a 50% probability. This uncovered some failing tests that were assert

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #792: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-04-29 Thread GitBox
mayya-sharipova commented on code in PR #792: URL: https://github.com/apache/lucene/pull/792#discussion_r862127419 ## lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java: ## @@ -320,13 +323,19 @@ private static class FieldEntry { final int

[jira] [Created] (LUCENE-10551) LowercaseAsciiCompression should return false when it's unable to compress

2022-04-29 Thread Peixin Li (Jira)
Peixin Li created LUCENE-10551: -- Summary: LowercaseAsciiCompression should return false when it's unable to compress Key: LUCENE-10551 URL: https://issues.apache.org/jira/browse/LUCENE-10551 Project: Luc

[GitHub] [lucene] mocobeta commented on a diff in pull request #854: LUCENE-10545: allow to link github pr from changes

2022-04-29 Thread GitBox
mocobeta commented on code in PR #854: URL: https://github.com/apache/lucene/pull/854#discussion_r862272575 ## lucene/CHANGES.txt: ## @@ -53,7 +53,7 @@ Other * LUCENE-10253: The @BadApple annotation has been removed from the test framework. (Adrien Grand) -* LUCENE-10393:

[GitHub] [lucene] mocobeta commented on a diff in pull request #854: LUCENE-10545: allow to link github pr from changes

2022-04-29 Thread GitBox
mocobeta commented on code in PR #854: URL: https://github.com/apache/lucene/pull/854#discussion_r862272691 ## gradle/documentation/changes-to-html/changes2html.pl: ## @@ -572,7 +572,7 @@ $item =~ s{((LUCENE|SOLR|INFRA)\s+(\d{3,}))} {$1}gi; # Link

[GitHub] [lucene] risdenk merged pull request #847: LUCENE-10542: FieldSource exists implementations can avoid value retrieval

2022-04-29 Thread GitBox
risdenk merged PR #847: URL: https://github.com/apache/lucene/pull/847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[jira] [Commented] (LUCENE-10542) FieldSource exists implementation can avoid value retrieval

2022-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530311#comment-17530311 ] ASF subversion and git services commented on LUCENE-10542: -- Co

[jira] [Updated] (LUCENE-10542) FieldSource exists implementations can avoid value retrieval

2022-04-29 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated LUCENE-10542: -- Summary: FieldSource exists implementations can avoid value retrieval (was: FieldSource exis

[jira] [Commented] (LUCENE-10542) FieldSource exists implementations can avoid value retrieval

2022-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530312#comment-17530312 ] ASF subversion and git services commented on LUCENE-10542: -- Co

[jira] [Updated] (LUCENE-10542) FieldSource exists implementations can avoid value retrieval

2022-04-29 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated LUCENE-10542: -- Fix Version/s: 9.2 Resolution: Fixed Status: Resolved (was: Patch Available

[jira] [Updated] (LUCENE-10543) Achieve contribution workflow perfection (with progress)

2022-04-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10543: - Attachment: Screen_Shot_2022-04-30_at_01.15.00.png > Achieve contribution workflow perfection (

[jira] [Commented] (LUCENE-10543) Achieve contribution workflow perfection (with progress)

2022-04-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530339#comment-17530339 ] Robert Muir commented on LUCENE-10543: -- IMO it just creates friction. having to si

[jira] [Commented] (LUCENE-10543) Achieve contribution workflow perfection (with progress)

2022-04-29 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530342#comment-17530342 ] Tomoko Uchida commented on LUCENE-10543: I forgot the sign-up procedure of Jira