Adrien Grand created LUCENE-10487:
-
Summary: Can IndexSearcher enable search concurrency by default?
Key: LUCENE-10487
URL: https://issues.apache.org/jira/browse/LUCENE-10487
Project: Lucene - Core
mocobeta opened a new pull request #772:
URL: https://github.com/apache/lucene/pull/772
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the approach taken
mocobeta commented on a change in pull request #772:
URL: https://github.com/apache/lucene/pull/772#discussion_r836182719
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/DictionaryConstants.java
##
@@ -17,7 +17,7 @@
package org.apache.lucene
mocobeta commented on a change in pull request #772:
URL: https://github.com/apache/lucene/pull/772#discussion_r836183038
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoMorphData.java
##
@@ -26,7 +26,7 @@
import org.apache.lucene.u
mocobeta commented on a change in pull request #772:
URL: https://github.com/apache/lucene/pull/772#discussion_r836183526
##
File path:
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/DictionaryConstants.java
##
@@ -17,7 +17,7 @@
package org.apache.lucene.ana
mocobeta commented on pull request #772:
URL: https://github.com/apache/lucene/pull/772#issuecomment-1080368517
We don't have good tests for dictionary builders (testing them is
difficult), `gradlew regenerate` tasks for kuromoji / nori works, and do not
change generated resources.
--
T
mocobeta commented on pull request #771:
URL: https://github.com/apache/lucene/pull/771#issuecomment-1080405884
would anyone want to review this... i'll wait until tomorrow then merge it
(if there are no objections).
--
This is an automated message from the Apache Git Service.
To respond
mocobeta commented on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1080432882
Just a quick note: I opened #772, which slightly improves the encapsulation
of the dictionary-related internals. The whole refactoring was done by IDE and
I think there wouldn't
mocobeta commented on a change in pull request #772:
URL: https://github.com/apache/lucene/pull/772#discussion_r836244662
##
File path: lucene/analysis/kuromoji/src/java/module-info.java
##
@@ -24,7 +24,6 @@
exports org.apache.lucene.analysis.ja.completion;
exports org.ap
mocobeta commented on a change in pull request #772:
URL: https://github.com/apache/lucene/pull/772#discussion_r836245264
##
File path: lucene/analysis/nori/src/java/module-info.java
##
@@ -23,7 +23,6 @@
exports org.apache.lucene.analysis.ko;
exports org.apache.lucene.ana
romseygeek commented on pull request #679:
URL: https://github.com/apache/lucene/pull/679#issuecomment-1080474711
@mogui there isn't a roadmap for the monitor itself, but please do open
issues and/or PRs if you have ideas for other improvements!
--
This is an automated message from the A
wjp719 commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r836331353
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java
##
@@ -163,6 +165,60 @@ public void visit(QueryVisitor visitor) {
wjp719 commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r836366205
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java
##
@@ -314,6 +370,32 @@ public Scorer scorer(LeafReaderContext co
wjp719 commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r836366764
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java
##
@@ -163,6 +165,60 @@ public void visit(QueryVisitor visitor) {
wjp719 commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r836367709
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestMultiRangeQueries.java
##
@@ -761,4 +764,67 @@ public void testEqualsAndHashCode()
wjp719 commented on pull request #731:
URL: https://github.com/apache/lucene/pull/731#issuecomment-1080600767
@gautamworah96 Hi, I have refactor the code as you suggest, please help to
review it again, thanks.
--
This is an automated message from the Apache Git Service.
To respond to t
[
https://issues.apache.org/jira/browse/LUCENE-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513493#comment-17513493
]
Julie Tibshirani commented on LUCENE-10454:
---
Thanks for looking into this! I
andywebb1975 commented on pull request #2643:
URL: https://github.com/apache/lucene-solr/pull/2643#issuecomment-1080930412
I've given this some more attention:
* found the `getArgs().getAll()` method which means it now works with a flat
list like in my last comment above
* moved m
cpoerschke commented on pull request #2643:
URL: https://github.com/apache/lucene-solr/pull/2643#issuecomment-1080947093
> ... Is there anything similar I could take a lead from?
Perhaps these two:
*
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.11.1/solr/core/
gsmiller commented on a change in pull request #751:
URL: https://github.com/apache/lucene/pull/751#discussion_r836685698
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
##
@@ -348,6 +348,9 @@ private void increment(long value) {
@Ove
gsmiller commented on pull request #747:
URL: https://github.com/apache/lucene/pull/747#issuecomment-1080958647
Thanks for running the benchmarks. The regression to taxo-faceting seems
weird indeed since you didn't touch that code at all (as you point out). Maybe
double-check that the only
[
https://issues.apache.org/jira/browse/LUCENE-10484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10484:
-
Component/s: modules/facet
> Add support for concurrent facets random sampling
> --
[
https://issues.apache.org/jira/browse/LUCENE-10484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513572#comment-17513572
]
Luca Cavanna commented on LUCENE-10484:
---
I am not sure why the PR is not getting
dweiss commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836744402
##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,128 @@
+
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of all,
dweiss commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836744907
##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,128 @@
+
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of all,
dweiss commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r836748820
##
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##
@@ -163,6 +163,43 @@ public void testInsertWithOverflow() {
assertEqu
BaurzhanSakhariev commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r836886681
##
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##
@@ -163,6 +163,43 @@ public void testInsertWithOverflow() {
BaurzhanSakhariev commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r836886681
##
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##
@@ -163,6 +163,43 @@ public void testInsertWithOverflow() {
BaurzhanSakhariev commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r836886681
##
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##
@@ -163,6 +163,43 @@ public void testInsertWithOverflow() {
BaurzhanSakhariev commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r836886681
##
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##
@@ -163,6 +163,43 @@ public void testInsertWithOverflow() {
gsmiller merged pull request #747:
URL: https://github.com/apache/lucene/pull/747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513702#comment-17513702
]
ASF subversion and git services commented on LUCENE-10325:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513703#comment-17513703
]
ASF subversion and git services commented on LUCENE-10325:
--
Co
gsmiller opened a new pull request #773:
URL: https://github.com/apache/lucene/pull/773
Backport
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: is
Greg Miller created LUCENE-10488:
Summary: Optimize Facets#getTopDims across Facets implementations
Key: LUCENE-10488
URL: https://issues.apache.org/jira/browse/LUCENE-10488
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513722#comment-17513722
]
Greg Miller commented on LUCENE-10488:
--
Note that I have an [open PR](https://gith
[
https://issues.apache.org/jira/browse/LUCENE-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513722#comment-17513722
]
Greg Miller edited comment on LUCENE-10488 at 3/28/22, 11:41 PM:
gsmiller merged pull request #773:
URL: https://github.com/apache/lucene/pull/773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513729#comment-17513729
]
ASF subversion and git services commented on LUCENE-10325:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-10325.
--
Fix Version/s: 9.2
Resolution: Fixed
Merged and backported. Thanks again [~yutinggan]!
[
https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513732#comment-17513732
]
Greg Miller commented on LUCENE-10325:
--
Also opened LUCENE-10488 to track other op
[
https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506640#comment-17506640
]
Yuting Gan edited comment on LUCENE-10325 at 3/29/22, 12:17 AM:
-
gautamworah96 commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r836963073
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestMultiRangeQueries.java
##
@@ -761,4 +764,103 @@ public void testEqualsAndHa
mocobeta commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836967094
##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,128 @@
+
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of al
mocobeta commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836967733
##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,128 @@
+
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of al
mocobeta commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836975410
##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,124 @@
+
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of al
gautamworah96 commented on a change in pull request #762:
URL: https://github.com/apache/lucene/pull/762#discussion_r836975590
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java
##
@@ -0,0 +1,95 @@
+/*
+
mocobeta commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836975410
##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,124 @@
+
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of al
mocobeta commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r836975410
##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,124 @@
+
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of al
wjp719 commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r837000418
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java
##
@@ -163,6 +165,69 @@ public void visit(QueryVisitor visitor) {
wjp719 commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r837001367
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java
##
@@ -163,6 +165,69 @@ public void visit(QueryVisitor visitor) {
wjp719 commented on pull request #731:
URL: https://github.com/apache/lucene/pull/731#issuecomment-1081337873
@gautamworah96 I refactor the code again, please review it again, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
wjp719 commented on pull request #687:
URL: https://github.com/apache/lucene/pull/687#issuecomment-1081341226
@jpountz @iverase Hi, is this pr ok now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dweiss commented on a change in pull request #771:
URL: https://github.com/apache/lucene/pull/771#discussion_r837081228
##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,124 @@
+
+
+# Contributing to Lucene Guide
+
+## Working with Code
+
+### Getting the source code
+
+First of all,
dweiss commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r837084866
##
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##
@@ -163,6 +163,43 @@ public void testInsertWithOverflow() {
assertEqu
gautamworah96 commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r837090466
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestMultiRangeQueries.java
##
@@ -761,4 +764,103 @@ public void testEqualsAndHa
56 matches
Mail list logo
