[GitHub] [lucene] uschindler commented on a change in pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on a change in pull request #567: URL: https://github.com/apache/lucene/pull/567#discussion_r775122320 ## File path: lucene/luke/src/java/org/apache/lucene/luke/app/desktop/util/ImageUtils.java ## @@ -19,18 +19,19 @@ import java.awt.Image; import javax

[GitHub] [lucene] uschindler commented on a change in pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on a change in pull request #567: URL: https://github.com/apache/lucene/pull/567#discussion_r775122395 ## File path: lucene/luke/src/java/org/apache/lucene/luke/app/desktop/util/ImageUtils.java ## @@ -19,18 +19,19 @@ import java.awt.Image; import javax

[jira] [Updated] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10335: --- Attachment: Screenshot from 2021-12-25 18-04-55.png > IOUtils.getDecodingReader(Class, Stri

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465157#comment-17465157 ] Tomoko Uchida commented on LUCENE-10335: It is off-topic here, I encountered th

[jira] [Comment Edited] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465157#comment-17465157 ] Tomoko Uchida edited comment on LUCENE-10335 at 12/25/21, 9:16 AM: --

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465159#comment-17465159 ] Uwe Schindler commented on LUCENE-10335: Yes thanks for finding this. But it wo

[GitHub] [lucene] mocobeta commented on a change in pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

mocobeta commented on a change in pull request #567: URL: https://github.com/apache/lucene/pull/567#discussion_r775124417 ## File path: lucene/luke/src/java/org/apache/lucene/luke/app/desktop/util/ImageUtils.java ## @@ -19,18 +19,19 @@ import java.awt.Image; import javax.s

[GitHub] [lucene] uschindler commented on a change in pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on a change in pull request #567: URL: https://github.com/apache/lucene/pull/567#discussion_r775124955 ## File path: lucene/luke/src/java/org/apache/lucene/luke/app/desktop/util/ImageUtils.java ## @@ -19,18 +19,19 @@ import java.awt.Image; import javax

[GitHub] [lucene] uschindler commented on a change in pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on a change in pull request #567: URL: https://github.com/apache/lucene/pull/567#discussion_r775124955 ## File path: lucene/luke/src/java/org/apache/lucene/luke/app/desktop/util/ImageUtils.java ## @@ -19,18 +19,19 @@ import java.awt.Image; import javax

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465160#comment-17465160 ] Tomoko Uchida commented on LUCENE-10335: I think it is needed or mandatory at r

[GitHub] [lucene] uschindler commented on a change in pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

uschindler commented on a change in pull request #567: URL: https://github.com/apache/lucene/pull/567#discussion_r775125157 ## File path: lucene/luke/src/java/org/apache/lucene/luke/app/desktop/util/ImageUtils.java ## @@ -19,18 +19,19 @@ import java.awt.Image; import javax

[GitHub] [lucene] mocobeta commented on a change in pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

mocobeta commented on a change in pull request #567: URL: https://github.com/apache/lucene/pull/567#discussion_r775125610 ## File path: lucene/luke/src/java/org/apache/lucene/luke/app/desktop/util/ImageUtils.java ## @@ -19,18 +19,19 @@ import java.awt.Image; import javax.s

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465162#comment-17465162 ] Dawid Weiss commented on LUCENE-10335: -- optional module requirements can be declar

[GitHub] [lucene] mocobeta commented on a change in pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

mocobeta commented on a change in pull request #567: URL: https://github.com/apache/lucene/pull/567#discussion_r775125610 ## File path: lucene/luke/src/java/org/apache/lucene/luke/app/desktop/util/ImageUtils.java ## @@ -19,18 +19,19 @@ import java.awt.Image; import javax.s

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465189#comment-17465189 ] Uwe Schindler commented on LUCENE-10335: This one was always optional. If we ca

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465190#comment-17465190 ] Tomoko Uchida commented on LUCENE-10335: Let me know if the patch is needed - I

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465191#comment-17465191 ] Tomoko Uchida commented on LUCENE-10335: Okay, I will make a patch - I wrote th

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465192#comment-17465192 ] Uwe Schindler commented on LUCENE-10335: Let's open an issue and decide from th

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465193#comment-17465193 ] Uwe Schindler commented on LUCENE-10335: You also need access to the hotspot be

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465194#comment-17465194 ] Uwe Schindler commented on LUCENE-10335: This again brings the question up: use

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465195#comment-17465195 ] Tomoko Uchida commented on LUCENE-10335: I just added "requires static jdk.mana

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465196#comment-17465196 ] Uwe Schindler commented on LUCENE-10335: Should be fine: https://docs.oracle.c

[jira] [Created] (LUCENE-10339) Add require derective for jdk.management to core's module descriptor.

Tomoko Uchida created LUCENE-10339: -- Summary: Add require derective for jdk.management to core's module descriptor. Key: LUCENE-10339 URL: https://issues.apache.org/jira/browse/LUCENE-10339 Project:

[jira] [Updated] (LUCENE-10339) Add require derective for jdk.management to core's module descriptor.

[ https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10339: --- Description: IntelliJ IDEA warns as follows in o.a.l.u.RamUsageEstimator. !Screenshot fro

[jira] [Commented] (LUCENE-10339) Add require derective for jdk.management to core's module descriptor.

[ https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465197#comment-17465197 ] Tomoko Uchida commented on LUCENE-10339: I have not tested it in module-mode, b

[jira] [Commented] (LUCENE-10339) Add require derective for jdk.management to core's module descriptor.

[ https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465198#comment-17465198 ] Uwe Schindler commented on LUCENE-10339: Based on module graph the jdk.manageme

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465199#comment-17465199 ] Tomoko Uchida commented on LUCENE-10335: Opened an issue - https://issues.apach

[GitHub] [lucene] mocobeta opened a new pull request #568: LUCENE-10339: Add require directive for accessing jdk.management

mocobeta opened a new pull request #568: URL: https://github.com/apache/lucene/pull/568 See https://issues.apache.org/jira/browse/LUCENE-10339. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (LUCENE-10339) Add require derective for jdk.management to core's module descriptor.

[ https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465200#comment-17465200 ] Tomoko Uchida commented on LUCENE-10339: Here is a one-line PR. [https://githu

[jira] [Commented] (LUCENE-10339) Add require derective for jdk.management to core's module descriptor.

[ https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465205#comment-17465205 ] Uwe Schindler commented on LUCENE-10339: Testing is hard, as it's silent (diffe

[jira] [Commented] (LUCENE-10339) Add require derective for jdk.management to core's module descriptor.

[ https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465209#comment-17465209 ] Dawid Weiss commented on LUCENE-10339: -- For now, testing in module mode requires a

[jira] [Commented] (LUCENE-10339) Add require derective for jdk.management to core's module descriptor.

[ https://issues.apache.org/jira/browse/LUCENE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465211#comment-17465211 ] Tomoko Uchida commented on LUCENE-10339: Thanks for your comments. I made a qui

[jira] [Commented] (LUCENE-10316) fix TestLRUQueryCache.testCachingAccountableQuery failure

[ https://issues.apache.org/jira/browse/LUCENE-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465240#comment-17465240 ] ASF subversion and git services commented on LUCENE-10316: -- Co

[jira] [Commented] (LUCENE-10316) fix TestLRUQueryCache.testCachingAccountableQuery failure

[ https://issues.apache.org/jira/browse/LUCENE-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465243#comment-17465243 ] ASF subversion and git services commented on LUCENE-10316: -- Co

[jira] [Created] (LUCENE-10340) Fix image file location (resource path) in luke module

Tomoko Uchida created LUCENE-10340: -- Summary: Fix image file location (resource path) in luke module Key: LUCENE-10340 URL: https://issues.apache.org/jira/browse/LUCENE-10340 Project: Lucene - Core

[GitHub] [lucene] mocobeta opened a new pull request #569: LUCENE-10340: Fix resource path for image files in luke module

mocobeta opened a new pull request #569: URL: https://github.com/apache/lucene/pull/569 https://issues.apache.org/jira/browse/LUCENE-10340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [lucene] mocobeta merged pull request #569: LUCENE-10340: Fix resource path for image files in luke module

mocobeta merged pull request #569: URL: https://github.com/apache/lucene/pull/569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-10340) Fix image file location (resource path) in luke module

[ https://issues.apache.org/jira/browse/LUCENE-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465297#comment-17465297 ] ASF subversion and git services commented on LUCENE-10340: -- Co

[jira] [Commented] (LUCENE-10340) Fix image file location (resource path) in luke module

[ https://issues.apache.org/jira/browse/LUCENE-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465298#comment-17465298 ] ASF subversion and git services commented on LUCENE-10340: -- Co

[GitHub] [lucene] mocobeta commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

mocobeta commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-100158 I merged the main branch to keep this up-to-date and fetch the change in luke module https://issues.apache.org/jira/browse/LUCENE-10340. -- This is an automated message from th

[GitHub] [lucene] mocobeta commented on pull request #567: LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class, String) for removal, as broken with modules

mocobeta commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1001112886 Browsing through this issue, I am wondering if it'd be helpful that we have an entry to forbid Class#getClassLoader() by default. When it is really needed (for example, on tests)

[jira] [Updated] (LUCENE-10340) Fix image file location (resource path) in luke module

[ https://issues.apache.org/jira/browse/LUCENE-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10340: --- Fix Version/s: 9.1 10.0 (main) > Fix image file location (resource path)