[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465189#comment-17465189 ]
Uwe Schindler commented on LUCENE-10335: ---------------------------------------- This one was always optional. If we can't get the module all calculations may be a bit off. I think we get some constants from there like if compressed oops are enabled. So when the module is not available, Object[] arrays size may be calculated off by a factor of 2, because we do not know if the oops are compressed. We can check this and decide how important it is. > IOUtils.getDecodingReader(Class<?>, String) is broken with modules > ------------------------------------------------------------------ > > Key: LUCENE-10335 > URL: https://issues.apache.org/jira/browse/LUCENE-10335 > Project: Lucene - Core > Issue Type: Bug > Reporter: Dawid Weiss > Priority: Major > Attachments: LUCENE-10335-1.patch, LUCENE-10335.patch, Screenshot > from 2021-12-25 18-04-55.png > > Time Spent: 10h 20m > Remaining Estimate: 0h > > This method calls clazz.getResourceAsStream() but in a modular application > the method won't see any of the resources in clazz's module, causing an NPE. > We should deprecate or even remove this method entirely, leaving only > getDecodingReader(InputStream) and opening the resource on the caller's side. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org