[GitHub] [lucene] dweiss commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
dweiss commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-180556 > I still cannot convince myself it is the best or only one solution for that, but maybe I'd need to recognize the strict dependency management of jms as a necessary thing for embr

[jira] [Created] (LUCENE-10337) xercesImpl has split packages with the JDK (required transitively by benchmarks)

2021-12-22 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10337: Summary: xercesImpl has split packages with the JDK (required transitively by benchmarks) Key: LUCENE-10337 URL: https://issues.apache.org/jira/browse/LUCENE-10337 Pr

[jira] [Updated] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10335: - Attachment: LUCENE-10335.patch > IOUtils.getDecodingReader(Class, String) is broken with module

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464331#comment-17464331 ] Dawid Weiss commented on LUCENE-10335: -- You may be right that the lambda version m

[jira] [Updated] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10335: - Attachment: LUCENE-10335-1.patch > IOUtils.getDecodingReader(Class, String) is broken with modu

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464334#comment-17464334 ] Dawid Weiss commented on LUCENE-10335: -- The attached seems to fix all of them and

[GitHub] [lucene] mocobeta commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-196889 I started to feel that we may need to check if the "runtime" dependency graph in the binary distribution is complete (or, does not lack any node). While it can be seen as a colle

[jira] [Created] (LUCENE-10338) Scan for tests only by convention file name pattern (Test*)

2021-12-22 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10338: Summary: Scan for tests only by convention file name pattern (Test*) Key: LUCENE-10338 URL: https://issues.apache.org/jira/browse/LUCENE-10338 Project: Lucene - Core

[jira] [Commented] (LUCENE-10338) Scan for tests only by convention file name pattern (Test*)

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464341#comment-17464341 ] Dawid Weiss commented on LUCENE-10338: -- Hey, Uwe - this is the thing that also aff

[jira] [Assigned] (LUCENE-10338) Scan for tests only by convention file name pattern (Test*)

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-10338: Assignee: Dawid Weiss > Scan for tests only by convention file name pattern (Test*) > --

[jira] [Commented] (LUCENE-10307) Add sanity checks for the distribution

2021-12-22 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464345#comment-17464345 ] Tomoko Uchida commented on LUCENE-10307: Just for filing - according to the pac

[GitHub] [lucene] uschindler commented on pull request #518: Initial rewrite of MMapDirectory for JDK-18 preview (incubating) Panama APIs (>= JDK-18-ea-b26)

2021-12-22 Thread GitBox
uschindler commented on pull request #518: URL: https://github.com/apache/lucene/pull/518#issuecomment-999371293 Hi, that's sorry. I just merged yesterday but didn't run tests. The test is obsolete on branch. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene] uschindler edited a comment on pull request #518: Initial rewrite of MMapDirectory for JDK-18 preview (incubating) Panama APIs (>= JDK-18-ea-b26)

2021-12-22 Thread GitBox
uschindler edited a comment on pull request #518: URL: https://github.com/apache/lucene/pull/518#issuecomment-999371293 Hi @dweiss, I'm so sorry. I just merged yesterday but didn't run tests. The test is obsolete on branch. -- This is an automated message from the Apache Git Service. To

[GitHub] [lucene] gf2121 commented on pull request #557: LUCENE-10333: Speed up BinaryDocValues with a batch reading on LongValues

2021-12-22 Thread GitBox
gf2121 commented on pull request #557: URL: https://github.com/apache/lucene/pull/557#issuecomment-999377609 @jpountz Thanks a lot for the suggestion! > Let's update this pull request to limit the impact to the API to DirectMonotonicReader, since it's the only LongValues impl where

[GitHub] [lucene] dweiss commented on pull request #518: Initial rewrite of MMapDirectory for JDK-18 preview (incubating) Panama APIs (>= JDK-18-ea-b26)

2021-12-22 Thread GitBox
dweiss commented on pull request #518: URL: https://github.com/apache/lucene/pull/518#issuecomment-999377984 No worries - just tweak whatever you want. I just didn't want jenkins to complain over and over. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene] mocobeta commented on a change in pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta commented on a change in pull request #550: URL: https://github.com/apache/lucene/pull/550#discussion_r773693085 ## File path: lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestScripts.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene] mocobeta commented on a change in pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta commented on a change in pull request #550: URL: https://github.com/apache/lucene/pull/550#discussion_r773693085 ## File path: lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestScripts.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene] gf2121 commented on a change in pull request #557: LUCENE-10333: Speed up BinaryDocValues with a batch reading on LongValues

2021-12-22 Thread GitBox
gf2121 commented on a change in pull request #557: URL: https://github.com/apache/lucene/pull/557#discussion_r773692776 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectMonotonicReader.java ## @@ -157,11 +159,29 @@ private DirectMonotonicReader( @Overr

[GitHub] [lucene] uschindler commented on pull request #518: Initial rewrite of MMapDirectory for JDK-18 preview (incubating) Panama APIs (>= JDK-18-ea-b26)

2021-12-22 Thread GitBox
uschindler commented on pull request #518: URL: https://github.com/apache/lucene/pull/518#issuecomment-999391791 I corrected the test to assert the `jdk.unsupported.foreign` module. But as this won't compile without it, it is in fact obsolete. But for easier merging in future I left it. I

[GitHub] [lucene] dweiss commented on a change in pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
dweiss commented on a change in pull request #550: URL: https://github.com/apache/lucene/pull/550#discussion_r773758512 ## File path: lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestScripts.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] uschindler opened a new pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
uschindler opened a new pull request #561: URL: https://github.com/apache/lucene/pull/561 Followup to cleanup TestSecrets after https://issues.apache.org/jira/browse/LUCENE-10301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [lucene] uschindler commented on pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
uschindler commented on pull request #561: URL: https://github.com/apache/lucene/pull/561#issuecomment-999455025 This is done in similar way by the JDK SharedSecrets. The reason is mainly to not produce a stack inspection on every access. It is also more readable because code is smaller.

[GitHub] [lucene] mocobeta commented on a change in pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta commented on a change in pull request #550: URL: https://github.com/apache/lucene/pull/550#discussion_r773771220 ## File path: lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestScripts.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene] dweiss commented on a change in pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
dweiss commented on a change in pull request #550: URL: https://github.com/apache/lucene/pull/550#discussion_r773776646 ## File path: lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestScripts.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] dweiss commented on pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
dweiss commented on pull request #561: URL: https://github.com/apache/lucene/pull/561#issuecomment-999463820 To me the explicit version is more readable because you see the "testsecrets" class and not the private constant but I really don't care or mind either way - looks fine to me. --

[GitHub] [lucene] uschindler commented on pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
uschindler commented on pull request #561: URL: https://github.com/apache/lucene/pull/561#issuecomment-999466216 This is why I asked to rename the constants. I think `INDEX_PACKAGE_ACCESS` => `INDEX_PACKAGE_SECRETS` or `indexPackageSecrets` (although this does not conform to coding standar

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-22 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463706#comment-17463706 ] Uwe Schindler commented on LUCENE-10301: Hi, I created a PR with some followup

[GitHub] [lucene] uschindler commented on pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
uschindler commented on pull request #561: URL: https://github.com/apache/lucene/pull/561#issuecomment-999469874 I think both names are fine. No matter if its "secret" or "access". Both mean the same in this context. I will merge this later and backport (should work). -- This is an auto

[GitHub] [lucene] dweiss commented on pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
dweiss commented on pull request #561: URL: https://github.com/apache/lucene/pull/561#issuecomment-999470748 I modelled this after the JDK, actually. So Test"Secrets" but inside they have "access" objects. Makes sense to me. -- This is an automated message from the Apache Git Service. To

[GitHub] [lucene] uschindler commented on pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
uschindler commented on pull request #561: URL: https://github.com/apache/lucene/pull/561#issuecomment-999471360 Here is an example in the JDK: https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d07414537b6c0/src/java.base/windows/classes/sun/nio/ch/SocketDispatcher.java#L40-L41

[GitHub] [lucene] uschindler edited a comment on pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
uschindler edited a comment on pull request #561: URL: https://github.com/apache/lucene/pull/561#issuecomment-999471360 Here is an example in the JDK: https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d07414537b6c0/src/java.base/windows/classes/sun/nio/ch/SocketDispatcher.java#

[GitHub] [lucene] uschindler commented on pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
uschindler commented on pull request #561: URL: https://github.com/apache/lucene/pull/561#issuecomment-999479096 Hi, have you seen this method in Java 15, this should be used, maybe we should add a TODO: [Lookup#ensureInitialized(Clazz)](https://docs.oracle.com/en/java/javase/17/docs/api/j

[GitHub] [lucene] rmuir commented on pull request #557: LUCENE-10333: Speed up BinaryDocValues with a batch reading on LongValues

2021-12-22 Thread GitBox
rmuir commented on pull request #557: URL: https://github.com/apache/lucene/pull/557#issuecomment-999482656 > I like this change, it's a net win that is not only going to speed up binary doc values but also sorted set and sorted numeric doc values, which also use a direct monotonic reader

[GitHub] [lucene] dweiss commented on pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
dweiss commented on pull request #561: URL: https://github.com/apache/lucene/pull/561#issuecomment-999485297 No, I didn't see that. But it's an equivalent of what class for name currently does (and it doesn't require a lookup). Up to you, this would only apply on main though if it requires

[GitHub] [lucene] rmuir merged pull request #553: LUCENE-10329: Use computed mask for DirectMonotonicReader#get

2021-12-22 Thread GitBox
rmuir merged pull request #553: URL: https://github.com/apache/lucene/pull/553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Commented] (LUCENE-10329) Use Computed Mask For DirectMonotonicReader#get

2021-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463741#comment-17463741 ] ASF subversion and git services commented on LUCENE-10329: -- Co

[GitHub] [lucene] rmuir commented on pull request #553: LUCENE-10329: Use computed mask for DirectMonotonicReader#get

2021-12-22 Thread GitBox
rmuir commented on pull request #553: URL: https://github.com/apache/lucene/pull/553#issuecomment-999486098 Thank you @gf2121 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [lucene] dweiss commented on pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
dweiss commented on pull request #561: URL: https://github.com/apache/lucene/pull/561#issuecomment-999486042 I'd stick to normal java conventions with respect to naming (so upper case, final constant). -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [lucene] uschindler commented on pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
uschindler commented on pull request #561: URL: https://github.com/apache/lucene/pull/561#issuecomment-999486380 I just left a TODO. The code you did is fine, I just like to add TODOs for all stuff where we may need to work after a JDK upgrade. Maybe we should mark those with a separate "t

[GitHub] [lucene] uschindler commented on pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
uschindler commented on pull request #561: URL: https://github.com/apache/lucene/pull/561#issuecomment-999487238 Main is still JDK 11, but may change soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] uschindler merged pull request #561: LUCENE-10301: extract constants to TestSecrets to spare stack inspection and make code more readable

2021-12-22 Thread GitBox
uschindler merged pull request #561: URL: https://github.com/apache/lucene/pull/561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463749#comment-17463749 ] ASF subversion and git services commented on LUCENE-10301: -- Co

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463750#comment-17463750 ] ASF subversion and git services commented on LUCENE-10301: -- Co

[GitHub] [lucene] mocobeta commented on a change in pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta commented on a change in pull request #550: URL: https://github.com/apache/lucene/pull/550#discussion_r773810546 ## File path: lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestScripts.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Softwa

[jira] [Created] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-22 Thread Feng Guo (Jira)
Feng Guo created LUCENE-10334: - Summary: Introduce a BlockReader based on ForUtil and use it for NumericDocValues Key: LUCENE-10334 URL: https://issues.apache.org/jira/browse/LUCENE-10334 Project: Lucene

[jira] [Commented] (LUCENE-10329) Use Computed Mask For DirectMonotonicReader#get

2021-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463755#comment-17463755 ] ASF subversion and git services commented on LUCENE-10329: -- Co

[GitHub] [lucene] gf2121 opened a new pull request #562: LUCENE-10334: Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-22 Thread GitBox
gf2121 opened a new pull request #562: URL: https://github.com/apache/lucene/pull/562 see https://issues.apache.org/jira/browse/LUCENE-10334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Resolved] (LUCENE-10329) Use Computed Mask For DirectMonotonicReader#get

2021-12-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10329. -- Fix Version/s: 9.1 Resolution: Fixed Thanks [~gf2121]! > Use Computed Mask For Direct

[GitHub] [lucene] gf2121 commented on pull request #557: LUCENE-10333: Speed up BinaryDocValues with a batch reading on LongValues

2021-12-22 Thread GitBox
gf2121 commented on pull request #557: URL: https://github.com/apache/lucene/pull/557#issuecomment-999516790 Hi @rmuir @jpountz , Thanks a lot for all talking about this! I think i **probably** find out a better way there: > Actually, what I thought at first was to only change the st

[GitHub] [lucene] gf2121 edited a comment on pull request #557: LUCENE-10333: Speed up BinaryDocValues with a batch reading on LongValues

2021-12-22 Thread GitBox
gf2121 edited a comment on pull request #557: URL: https://github.com/apache/lucene/pull/557#issuecomment-999516790 Hi @rmuir @jpountz , Thanks a lot for all talking about this! I think i **probably** find out a better way there: > Actually, what I thought at first was to only change

[jira] [Commented] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463764#comment-17463764 ] Robert Muir commented on LUCENE-10334: -- Wow! very promising results :) > Introduc

[GitHub] [lucene] gf2121 edited a comment on pull request #557: LUCENE-10333: Speed up BinaryDocValues with a batch reading on LongValues

2021-12-22 Thread GitBox
gf2121 edited a comment on pull request #557: URL: https://github.com/apache/lucene/pull/557#issuecomment-999516790 Hi @rmuir @jpountz , Thanks a lot for all talking about this! I think we **probably** find out a better way there: > Actually, what I thought at first was to only chang

[GitHub] [lucene] mocobeta commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999607132 The test failure cannot be reproduced for me. https://github.com/apache/lucene/runs/4606721258?check_suite_focus=true ``` gradlew :lucene:distribution.tests:test --tests "

[GitHub] [lucene] mocobeta edited a comment on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta edited a comment on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999607132 The test failure cannot be reproduced for me. https://github.com/apache/lucene/runs/4606721258?check_suite_focus=true ``` gradlew :lucene:distribution.tests:test --t

[GitHub] [lucene] dweiss commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
dweiss commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999609699 I'm not sure what it is but I'm ears deep into rewriting these path-related things - there are bugs and quirks there that I'm trying to overcome. Once I finalize that, I'll return t

[GitHub] [lucene] mocobeta commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999624305 Thanks for your quick response as always. Sorry, I just tend to add uncoordinated memos in pull requests but they are not questions that need responses. -- This is an automated

[GitHub] [lucene] mocobeta edited a comment on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta edited a comment on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999607132 The test failure cannot be reproduced for me. https://github.com/apache/lucene/runs/4606721258?check_suite_focus=true ``` gradlew :lucene:distribution.tests:test --t

[jira] [Commented] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-22 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463868#comment-17463868 ] Greg Miller commented on LUCENE-10334: -- Cool! I haven't looked at the PR yet but t

[GitHub] [lucene] mocobeta commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999637256 It seems that this can be reproduced on the Github Actions container. As a test, let me revert the recently merged change... -- This is an automated message from the Apache Git

[GitHub] [lucene] gf2121 edited a comment on pull request #557: LUCENE-10333: Speed up BinaryDocValues with a batch reading on LongValues

2021-12-22 Thread GitBox
gf2121 edited a comment on pull request #557: URL: https://github.com/apache/lucene/pull/557#issuecomment-999516790 Hi @rmuir @jpountz , Thanks a lot for all talking about this! I think we **probably** find out a better way there: > Actually, what I thought at first was to only chang

[GitHub] [lucene] mocobeta commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999650568 It looks like the failure is not related to https://github.com/dweiss/lucene/pull/15. I will revert the revert commit; sorry for the noise again. -- This is an automated messag

[GitHub] [lucene] gf2121 edited a comment on pull request #557: LUCENE-10333: Speed up BinaryDocValues with a batch reading on LongValues

2021-12-22 Thread GitBox
gf2121 edited a comment on pull request #557: URL: https://github.com/apache/lucene/pull/557#issuecomment-999516790 Hi @rmuir @jpountz , Thanks a lot for all talking about this! I think we **probably** find out a better way there: > Actually, what I thought at first was to only chang

[GitHub] [lucene-solr] cpoerschke commented on pull request #1994: Mention 'ant server' equivalent(s) in help/ant.txt file.

2021-12-22 Thread GitBox
cpoerschke commented on pull request #1994: URL: https://github.com/apache/lucene-solr/pull/1994#issuecomment-999663008 Closing as stale and probably now less useful with Gradle familiarity having increased over time and Ant habits having faded over time. -- This is an automated message

[GitHub] [lucene-solr] cpoerschke closed pull request #1994: Mention 'ant server' equivalent(s) in help/ant.txt file.

2021-12-22 Thread GitBox
cpoerschke closed pull request #1994: URL: https://github.com/apache/lucene-solr/pull/1994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene] mocobeta opened a new pull request #563: Lucene-8930: script testing in the distribution (clone of #550)

2021-12-22 Thread GitBox
mocobeta opened a new pull request #563: URL: https://github.com/apache/lucene/pull/563 This is a clone PR of https://github.com/apache/lucene/pull/550 to explore the test failure on Github Actions. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-22 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463911#comment-17463911 ] Feng Guo commented on LUCENE-10334: --- Thanks [~gsmiller] ! Yes I do thought i would ge

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-22 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463911#comment-17463911 ] Feng Guo edited comment on LUCENE-10334 at 12/22/21, 4:34 PM: ---

[GitHub] [lucene] mocobeta closed pull request #563: Lucene-8930: script testing in the distribution (clone of #550)

2021-12-22 Thread GitBox
mocobeta closed pull request #563: URL: https://github.com/apache/lucene/pull/563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene] mocobeta commented on pull request #563: Lucene-8930: script testing in the distribution (clone of #550)

2021-12-22 Thread GitBox
mocobeta commented on pull request #563: URL: https://github.com/apache/lucene/pull/563#issuecomment-999744354 It would be better to wait for LUCENE-10301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] mocobeta commented on pull request #564: Lucene-8930: debug actions

2021-12-22 Thread GitBox
mocobeta commented on pull request #564: URL: https://github.com/apache/lucene/pull/564#issuecomment-999767130 Actually, `lucene-test-framework-10.0.0-SNAPSHOT.jar` is on the module path. ``` 1> --- [forked subprocess output: /usr/bin/dash] --- 1> files in /home/runner/work/luc

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-22 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463911#comment-17463911 ] Feng Guo edited comment on LUCENE-10334 at 12/22/21, 6:05 PM: ---

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-22 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463911#comment-17463911 ] Feng Guo edited comment on LUCENE-10334 at 12/22/21, 6:10 PM: ---

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-22 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463911#comment-17463911 ] Feng Guo edited comment on LUCENE-10334 at 12/22/21, 6:24 PM: ---

[jira] [Comment Edited] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-22 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463911#comment-17463911 ] Feng Guo edited comment on LUCENE-10334 at 12/22/21, 6:25 PM: ---

[GitHub] [lucene] dweiss commented on pull request #564: Lucene-8930: debug actions

2021-12-22 Thread GitBox
dweiss commented on pull request #564: URL: https://github.com/apache/lucene/pull/564#issuecomment-999781303 This may be a problem with how paths are placed for tests - it's not correct on main. I'm working on it, but it's not trivial at all. I think this will have to wait until LUCENE-103

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is wrong

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464002#comment-17464002 ] Dawid Weiss commented on LUCENE-10328: -- Right. Once you actually fix the module pa

[GitHub] [lucene] mocobeta commented on pull request #564: Lucene-8930: debug actions

2021-12-22 Thread GitBox
mocobeta commented on pull request #564: URL: https://github.com/apache/lucene/pull/564#issuecomment-999793043 It seems there is a difference in the binary distribution structure. On my local machine: ``` lucene/distribution/build/packages/lucene-10.0.0-SNAPSHOT-itests/ ├── R

[GitHub] [lucene] mocobeta commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999814200 I thought [something strange was happening on the Actions](https://github.com/apache/lucene/pull/564#issuecomment-999793043), but after merging the main branch (I did that to fetc

[GitHub] [lucene] dweiss commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
dweiss commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999817741 This means module resolution picks up all the modules, not just those requested and fails there because it can't find dependencies of the test framework... If this indeed is the cas

[GitHub] [lucene] mocobeta commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999818035 Besides the test failure, Luke fails to start on the latest main as I speculated. ``` lucene $ tar xzf lucene/distribution/build/packages/lucene-10.0.0-SNAPSHOT lucene-10.

[GitHub] [lucene] dweiss commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
dweiss commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999819547 Well, this confirms the test is working... ;) I didn't realize the resolution is eager for all modules on module path - I thought it'd only include the actual graph of included modu

[GitHub] [lucene] dweiss commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
dweiss commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999823044 I think the resolution may be actually lazy but the test framework provides services consumed by lucene-core - that's why the resolver tries to load the test framework module (and f

[GitHub] [lucene] dweiss commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
dweiss commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999823838 If you'd like to provide a minor patch reverting just this distribution-assembly bit, @mocobeta , it'd be great (the tests in distribution.tests would have to be updated too). --

[GitHub] [lucene] mocobeta commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
mocobeta commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999825830 Thanks. The problem is now clear to me. I will try to look at this tomorrow (or today; it's 5 am in my timezone). -- This is an automated message from the Apache Git Service

[GitHub] [lucene] mocobeta closed pull request #564: Lucene-8930: debug actions

2021-12-22 Thread GitBox
mocobeta closed pull request #564: URL: https://github.com/apache/lucene/pull/564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene] dweiss commented on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
dweiss commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999833490 bq. 5 am in my timezone Nobody should not be awake at this ungodly hour. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [lucene] dweiss edited a comment on pull request #550: LUCENE-8930: script testing in the distribution

2021-12-22 Thread GitBox
dweiss edited a comment on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-999833490 bq. 5 am in my timezone Nobody should be awake at this ungodly hour. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Created] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10335: Summary: IOUtils.getDecodingReader(Class, String) is broken with modules Key: LUCENE-10335 URL: https://issues.apache.org/jira/browse/LUCENE-10335 Project: Lucene - C

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464033#comment-17464033 ] Uwe Schindler commented on LUCENE-10335: This should work inside the same modul

[jira] [Comment Edited] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464033#comment-17464033 ] Uwe Schindler edited comment on LUCENE-10335 at 12/22/21, 8:23 PM: --

[jira] [Commented] (LUCENE-10328) Module path for compiling and running tests is wrong

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464034#comment-17464034 ] Dawid Weiss commented on LUCENE-10328: -- There are more problems that surfaced when

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464035#comment-17464035 ] Dawid Weiss commented on LUCENE-10335: -- take a look at JavascriptCompiler - it cal

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464036#comment-17464036 ] Dawid Weiss commented on LUCENE-10335: -- btw - I know it's broken because I have it

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464040#comment-17464040 ] Uwe Schindler commented on LUCENE-10335: I wonder why it is broken. Because you

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464045#comment-17464045 ] Uwe Schindler commented on LUCENE-10335: It is not caller sensitive. I have the

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464048#comment-17464048 ] Dawid Weiss commented on LUCENE-10335: -- And it's exactly how it works. So unless y

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464046#comment-17464046 ] Dawid Weiss commented on LUCENE-10335: -- Resources in named modules are subject to

[jira] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335 ] Uwe Schindler deleted comment on LUCENE-10335: was (Author: thetaphi): It is not caller sensitive. I have the feeling your packaging is wrong. If the resource is in same package and is

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464049#comment-17464049 ] Dawid Weiss commented on LUCENE-10335: -- If you don't believe me, write a snippet o

[jira] [Commented] (LUCENE-10335) IOUtils.getDecodingReader(Class, String) is broken with modules

2021-12-22 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464050#comment-17464050 ] Uwe Schindler commented on LUCENE-10335: Yes I figured, it is caller sensitive:

  1   2   >