[jira] [Created] (LUCENE-10284) Upgrade morfologik-stemming to 2.1.8

2021-12-04 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10284: Summary: Upgrade morfologik-stemming to 2.1.8 Key: LUCENE-10284 URL: https://issues.apache.org/jira/browse/LUCENE-10284 Project: Lucene - Core Issue Type: Ta

[jira] [Updated] (LUCENE-10284) Upgrade morfologik-stemming to 2.1.8

2021-12-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10284: - Fix Version/s: 9.1 > Upgrade morfologik-stemming to 2.1.8 > ---

[jira] [Assigned] (LUCENE-10284) Upgrade morfologik-stemming to 2.1.8

2021-12-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-10284: Assignee: Dawid Weiss > Upgrade morfologik-stemming to 2.1.8 > -

[GitHub] [lucene] dweiss merged pull request #514: LUCENE-10284: Upgrade morfologik-stemming to 2.1.8

2021-12-04 Thread GitBox
dweiss merged pull request #514: URL: https://github.com/apache/lucene/pull/514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-10284) Upgrade morfologik-stemming to 2.1.8

2021-12-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453322#comment-17453322 ] ASF subversion and git services commented on LUCENE-10284: -- Co

[jira] [Commented] (LUCENE-10284) Upgrade morfologik-stemming to 2.1.8

2021-12-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453323#comment-17453323 ] ASF subversion and git services commented on LUCENE-10284: -- Co

[jira] [Resolved] (LUCENE-10284) Upgrade morfologik-stemming to 2.1.8

2021-12-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10284. -- Resolution: Fixed > Upgrade morfologik-stemming to 2.1.8 > --

[GitHub] [lucene] rmuir opened a new pull request #515: simplify jflex grammars by using difference rather than negation

2021-12-04 Thread GitBox
rmuir opened a new pull request #515: URL: https://github.com/apache/lucene/pull/515 This change uses a new jflex feature (https://github.com/jflex-de/jflex/pull/654) to simplify emoji processing in the grammar. We can do a set difference rather than workaround it with complement + demorg

[GitHub] [lucene] rmuir commented on pull request #515: simplify jflex grammars by using difference rather than negation

2021-12-04 Thread GitBox
rmuir commented on pull request #515: URL: https://github.com/apache/lucene/pull/515#issuecomment-986055369 I'll take care of the precommit. There's some build wierdness in the regeneration where we pull the TLDs and make the new included-TLD.jflex *after* we recompile the grammar. Maybe d

[GitHub] [lucene] rmuir commented on pull request #515: simplify jflex grammars by using difference rather than negation

2021-12-04 Thread GitBox
rmuir commented on pull request #515: URL: https://github.com/apache/lucene/pull/515#issuecomment-986055851 and don't worry about the gradle build, I think part of the issue is that this TLDs file annoyingly changed *while I was iterating and working on this*: ``` # Version 2021120400

[jira] [Created] (LUCENE-10285) gradle regenerate TLDs file / tokenizer dependency is backwards/wrong

2021-12-04 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10285: Summary: gradle regenerate TLDs file / tokenizer dependency is backwards/wrong Key: LUCENE-10285 URL: https://issues.apache.org/jira/browse/LUCENE-10285 Project: Luce

[jira] [Assigned] (LUCENE-10285) gradle regenerate TLDs file / tokenizer dependency is backwards/wrong

2021-12-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-10285: Assignee: Dawid Weiss > gradle regenerate TLDs file / tokenizer dependency is backwards/

[jira] [Commented] (LUCENE-10285) gradle regenerate TLDs file / tokenizer dependency is backwards/wrong

2021-12-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453453#comment-17453453 ] Dawid Weiss commented on LUCENE-10285: -- Eh. That crap is so complicated already th

[GitHub] [lucene] rmuir commented on pull request #515: simplify jflex grammars by using difference rather than negation

2021-12-04 Thread GitBox
rmuir commented on pull request #515: URL: https://github.com/apache/lucene/pull/515#issuecomment-986060813 I opened https://issues.apache.org/jira/browse/LUCENE-10285 about the TLD task dependency. For now, I just ran `regenerate` again and it brought in the TLD changes. It is a lot less

[jira] [Commented] (LUCENE-10285) gradle regenerate TLDs file / tokenizer dependency is backwards/wrong

2021-12-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453456#comment-17453456 ] Robert Muir commented on LUCENE-10285: -- Yeah, I just ran {{regenerate}} again to w

[GitHub] [lucene] dweiss commented on pull request #515: simplify jflex grammars by using difference rather than negation

2021-12-04 Thread GitBox
dweiss commented on pull request #515: URL: https://github.com/apache/lucene/pull/515#issuecomment-986062093 That's a nice improvement! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Commented] (LUCENE-10282) morfologik-stemming is not an automatic module

2021-12-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453460#comment-17453460 ] Dawid Weiss commented on LUCENE-10282: -- This is partially done. The weird part is

[jira] [Commented] (LUCENE-10282) morfologik-stemming is not an automatic module

2021-12-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453461#comment-17453461 ] Dawid Weiss commented on LUCENE-10282: -- And I think this shows how even a compilin

[jira] [Created] (LUCENE-10286) Module path to dependencies that are not automatic modules (according to gradle)

2021-12-04 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10286: Summary: Module path to dependencies that are not automatic modules (according to gradle) Key: LUCENE-10286 URL: https://issues.apache.org/jira/browse/LUCENE-10286 Pr

[jira] [Updated] (LUCENE-10255) Fully embrace the java module system

2021-12-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10255: - Description: I've experimented a bit trying to move the code to the JMS. It is _surprisingly d

[GitHub] [lucene] rmuir commented on pull request #515: simplify jflex grammars by using difference rather than negation

2021-12-04 Thread GitBox
rmuir commented on pull request #515: URL: https://github.com/apache/lucene/pull/515#issuecomment-986075965 @dweiss i think it's good win just for getting a simpler grammar. There is probably evil stuff we could do to speed up the monster. Yes, I am slightly tempted to import `org.a

[GitHub] [lucene] rmuir merged pull request #504: Make TestNRTReplication.testCrashReplica nightly

2021-12-04 Thread GitBox
rmuir merged pull request #504: URL: https://github.com/apache/lucene/pull/504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene] rmuir merged pull request #505: tone down BaseTermVectorsFormatTestCase.testLotsOfFields in non-nightly

2021-12-04 Thread GitBox
rmuir merged pull request #505: URL: https://github.com/apache/lucene/pull/505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene] rmuir merged pull request #506: tone down TestIndexWriter.testMaxCompletedSequenceNumber in non-nightly

2021-12-04 Thread GitBox
rmuir merged pull request #506: URL: https://github.com/apache/lucene/pull/506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene] rmuir opened a new pull request #516: speed up TestSimpleExplanationsWithFillerDocs

2021-12-04 Thread GitBox
rmuir opened a new pull request #516: URL: https://github.com/apache/lucene/pull/516 This is the slowest test suite, runs for ~ 60s, because between every document it adds 2048 "filler docs". This just adds up to a ton of indexing across all the test methods. Use 2048 for Nightl

[GitHub] [lucene] dsmiley commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-04 Thread GitBox
dsmiley commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r762497281 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -113,118 +112,239 @@ protected static final L

[GitHub] [lucene] apanimesh061 commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-04 Thread GitBox
apanimesh061 commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r762514373 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -113,118 +112,239 @@ protected static fi

[GitHub] [lucene] apanimesh061 commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-04 Thread GitBox
apanimesh061 commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r762514390 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -823,24 +943,13 @@ public void visitLeaf(Qu

[jira] [Commented] (LUCENE-10229) Match offsets should be consistent for fields with positions and fields with offsets

2021-12-04 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453526#comment-17453526 ] Haoyu Zhai commented on LUCENE-10229: - Seems for {{containedBy}} this inconsistency

[GitHub] [lucene] apanimesh061 commented on pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-04 Thread GitBox
apanimesh061 commented on pull request #412: URL: https://github.com/apache/lucene/pull/412#issuecomment-986174116 @dsmiley Updated the PR as per the comments and added the new builder functions. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (LUCENE-10229) Match offsets should be consistent for fields with positions and fields with offsets

2021-12-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453538#comment-17453538 ] Dawid Weiss commented on LUCENE-10229: -- Thanks for looking at this, [~zhai7631]! I