Robert Muir created LUCENE-10285:
------------------------------------

             Summary: gradle regenerate TLDs file / tokenizer dependency is 
backwards/wrong
                 Key: LUCENE-10285
                 URL: https://issues.apache.org/jira/browse/LUCENE-10285
             Project: Lucene - Core
          Issue Type: Task
            Reporter: Robert Muir


To reproduce: {{./gradlew regenerate --rerun-tasks}}

You'll see this behavior:
{noformat}
> Task :lucene:analysis:common:generateUAX29URLEmailTokenizerInternal
Regenerating UAX29URLEmailTokenizerImpl. This may take a long time (and 
requires 12g of memory!).
Recompiling JFlex: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/email/UAX29URLEmailTokenizerImpl.jflex

...

> Task :lucene:analysis:common:generateTldsInternal
Execution optimizations have been disabled for task 
':lucene:analysis:common:generateTldsInternal' to ensure correctness due to the 
following reasons:
  - Gradle detected a problem with the following location: 
'/home/rmuir/workspace/lucene/lucene/analysis/common/src/java/org/apache/lucene/analysis/email/ASCIITLD.jflex'.
 Reason: Task ':lucene:analysis:common:generateUAX29URLEmailTokenizerInternal' 
uses this output of task ':lucene:analysis:common:generateTldsInternal' without 
declaring an explicit or implicit dependency. This can lead to incorrect 
results being produced, depending on what order the tasks are executed. Please 
refer to 
https://docs.gradle.org/7.2/userguide/validation_problems.html#implicit_dependency
 for more details about this problem.
Found 1489 TLDs in IANA TLD Database at 
https://data.iana.org/TLD/tlds-alpha-by-domain.txt
                      ASCIITLD: 1370 TLDs
    ASCIITLDprefix_1CharSuffix:  108 TLDs
    ASCIITLDprefix_2CharSuffix:   11 TLDs
                         Total: 1489 TLDs
You've regenerated the TLD include file, remember to regenerate 
UAX29URLEmailTokenizerImpl too.
{noformat}

So it regenerates the TLD include file after the UAX29URLEmailTokenizerImpl, 
which means now you gotta run "gradlew regenerate" again to really pick up the 
changes.

cc [~dweiss]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to