[
https://issues.apache.org/jira/browse/LUCENE-10265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17449967#comment-17449967
]
kkewwei commented on LUCENE-10265:
--
Yes, you are right, I read it wrong.
If we should
[
https://issues.apache.org/jira/browse/LUCENE-10265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17449967#comment-17449967
]
kkewwei edited comment on LUCENE-10265 at 11/28/21, 8:00 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17449967#comment-17449967
]
kkewwei edited comment on LUCENE-10265 at 11/28/21, 8:09 AM:
mocobeta merged pull request #481:
URL: https://github.com/apache/lucene/pull/481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
mocobeta merged pull request #482:
URL: https://github.com/apache/lucene/pull/482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
uschindler commented on pull request #482:
URL: https://github.com/apache/lucene/pull/482#issuecomment-981080121
Thanks 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r757898115
##
File path: lucene/luke/src/java-module/module-info.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
mocobeta commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-981090868
I would recommend cherry-picking this clean-up
https://github.com/apache/lucene/commit/57f695b14d8ad9f156bc06518a8c86058b813bd5.
In regard to Luke, I had a concern about thi
mocobeta edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-981090868
I would recommend cherry-picking this clean-up
https://github.com/apache/lucene/commit/57f695b14d8ad9f156bc06518a8c86058b813bd5.
In regard to Luke, I had a concern ab
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r757898115
##
File path: lucene/luke/src/java-module/module-info.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
rmuir merged pull request #471:
URL: https://github.com/apache/lucene/pull/471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
apanimesh061 commented on pull request #412:
URL: https://github.com/apache/lucene/pull/412#issuecomment-981097369
@dsmiley
I was finally able to address your comments on my previous PR request. Thank
you for your patience.
Added a new PR version with new changes related to the b
apanimesh061 commented on a change in pull request #412:
URL: https://github.com/apache/lucene/pull/412#discussion_r757907069
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
##
@@ -143,88 +135,168 @@
private int cacheF
apanimesh061 commented on a change in pull request #412:
URL: https://github.com/apache/lucene/pull/412#discussion_r757907807
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
##
@@ -117,13 +116,6 @@
protected final Anal
apanimesh061 commented on a change in pull request #412:
URL: https://github.com/apache/lucene/pull/412#discussion_r757907893
##
File path:
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/SearchTravRetHighlightTask.java
##
@@ -319,4 +329,12 @@ public void wi
rmuir opened a new pull request #483:
URL: https://github.com/apache/lucene/pull/483
The most recent `ecj` has significant performance improvements for our
use-case. It removes minutes from precommit checks.
I ran tests several times to be sure:
```
Test commandline: ./gradlew
mikemccand commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r753339619
##
File path: lucene/CHANGES.txt
##
@@ -7,6 +7,8 @@ http://s.apache.org/luceneversions
New Features
+* LUCENE-10010 Introduce NFARunAutomaton to run
rmuir commented on pull request #483:
URL: https://github.com/apache/lucene/pull/483#issuecomment-981107916
You can see the performance improvement kicked in for the github actions
here, too:
precommit check for this PR: `5m 46s`
precommit check for previous PR: `8m 15s`
I am s
dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r757922730
##
File path: lucene/luke/src/java-module/module-info.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
rmuir merged pull request #483:
URL: https://github.com/apache/lucene/pull/483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r757927062
##
File path: lucene/luke/src/java-module/module-info.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r757927837
##
File path: lucene/luke/src/java-module/module-info.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
rmuir commented on pull request #483:
URL: https://github.com/apache/lucene/pull/483#issuecomment-981125117
I'm still digging into this more: I'm trying to understand why it speeds up
performance and also why precommit took 3x longer around oct 19 in mike's
benchmark: http://people.apache.
uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r757930753
##
File path: lucene/luke/src/java-module/module-info.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
rmuir opened a new pull request #484:
URL: https://github.com/apache/lucene/pull/484
LUCENE-10185 caused a large performance regression in ECJ tasks by using the
--release flag. See graph:
http://people.apache.org/~mikemccand/lucenebench/antcleantest.html
We recovered some, but not
rmuir commented on pull request #484:
URL: https://github.com/apache/lucene/pull/484#issuecomment-981133462
note: the change doesn't help any build machines running with java 11, the
`--release` flag acts as a no-op in that case and doesn't cause slowdowns. The
change only helps ppl runnin
dweiss commented on pull request #484:
URL: https://github.com/apache/lucene/pull/484#issuecomment-981141614
I think ecj folks may be interested in this one - seems crazy that this
creates such a difference.
--
This is an automated message from the Apache Git Service.
To respond to the m
rmuir commented on pull request #484:
URL: https://github.com/apache/lucene/pull/484#issuecomment-981142619
well, with the latest release, the cost was reduced substantially:
https://github.com/apache/lucene/pull/483
so it's trending in the right direction. but still currently 50% sl
rmuir merged pull request #484:
URL: https://github.com/apache/lucene/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
[
https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450110#comment-17450110
]
ASF subversion and git services commented on LUCENE-10185:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450111#comment-17450111
]
ASF subversion and git services commented on LUCENE-10185:
--
Co
uschindler commented on pull request #484:
URL: https://github.com/apache/lucene/pull/484#issuecomment-981145420
We should really go back to release when the echo people have fixed this. So
we should leave a Todo.
--
This is an automated message from the Apache Git Service.
To respond to
uschindler edited a comment on pull request #484:
URL: https://github.com/apache/lucene/pull/484#issuecomment-981145420
We should really go back to release when the ecj people have fixed this. So
we should leave a Todo.
--
This is an automated message from the Apache Git Service.
To resp
Robert Muir created LUCENE-10268:
Summary: TestFuzzyQuery.testErrorMessage can sometimes run for a
hundred seconds
Key: LUCENE-10268
URL: https://issues.apache.org/jira/browse/LUCENE-10268
Project: Lu
rmuir commented on pull request #484:
URL: https://github.com/apache/lucene/pull/484#issuecomment-981147052
> We should really go back to release when the ecj people have fixed this.
So we should leave a Todo.
I already added a comment right where we do this about why. It isn't a TOD
[
https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450115#comment-17450115
]
Robert Muir commented on LUCENE-10268:
--
Don't worry about the loss of seed, I'm ru
[
https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-10268:
-
Description:
I ran 6 test runs, and it happened only in one of them:
97.93s TestFuzzyQuery.tes
[
https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450118#comment-17450118
]
Robert Muir commented on LUCENE-10268:
--
I ran the first seed (just tacked on {{-Dt
[
https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450121#comment-17450121
]
Robert Muir commented on LUCENE-10268:
--
Here are the strings in question. Sorry if
[
https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450122#comment-17450122
]
Robert Muir commented on LUCENE-10268:
--
So, if I patch the test to just use ASCII
[
https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450123#comment-17450123
]
Robert Muir commented on LUCENE-10268:
--
oh, duh, it was that previous insane loop
[
https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450148#comment-17450148
]
Robert Muir commented on LUCENE-10268:
--
So for the first seed, here's the state/tr
[
https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-10268:
-
Attachment: LUCENE-10268_test.patch
Status: Open (was: Open)
> TestFuzzyQuery.testErro
[
https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450149#comment-17450149
]
Robert Muir commented on LUCENE-10268:
--
Use curl to download the patch to reproduc
[
https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450153#comment-17450153
]
Robert Muir commented on LUCENE-10268:
--
OK, I've got a better understanding of thi
[
https://issues.apache.org/jira/browse/LUCENE-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450160#comment-17450160
]
Robert Muir commented on LUCENE-10268:
--
an evil way to bypass all this overhead mi
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r757996507
##
File path: lucene/luke/src/java-module/module-info.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r757997802
##
File path: lucene/luke/src/java-module/module-info.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
mocobeta commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-981235169
I'm wondering if, from some minor version of 9.x, Luke can be released with
the module descriptor in advance of the whole project. If any problems pop up,
switching back is easy (
mocobeta edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-981235169
I'm wondering if, from some minor version of 9.x, Luke can be released with
the module descriptor in advance of the whole project. If any problems pop up,
switching back is
mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r758096467
##
File path: lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java
##
@@ -55,29 +55,32 @@ public static JFrame getOwnerFrame() {
retur
dweiss commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-981360588
I think you should be able to commit directly to this branch, @mocobeta !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
mocobeta commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-981366428
> I think you should be able to commit directly to this branch
yes I know that, I'd prefer to rely on github's "suggestion" feature here
instead of directly pushing any chan
mocobeta edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-981366428
> I think you should be able to commit directly to this branch
yes I know that, but I'd prefer to rely on github's "suggestion" feature
here instead of directly pushi
rmuir commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-981367730
> But since we are not changing the behavior of `AutomatonQuery` (it still
determinizes up-front by default), I don't think we need to block pushing this
(once we iterate on all feed
55 matches
Mail list logo
