[GitHub] [lucene] jpountz commented on a change in pull request #413: LUCENE-9614: Fix KnnVectorQuery failure when numDocs is 0

2021-10-27 Thread GitBox
jpountz commented on a change in pull request #413: URL: https://github.com/apache/lucene/pull/413#discussion_r737165184 ## File path: lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java ## @@ -25,18 +25,10 @@ import java.io.IOException; import java.util.Has

[GitHub] [lucene] jpountz merged pull request #415: LUCENE-10206 Implement O(1) count on query cache

2021-10-27 Thread GitBox
jpountz merged pull request #415: URL: https://github.com/apache/lucene/pull/415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10206) Implement O(1) count on query cache

2021-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434733#comment-17434733 ] ASF subversion and git services commented on LUCENE-10206: -- Co

[GitHub] [lucene-solr] janhoy commented on a change in pull request #2594: SOLR-14726: Initial draft of a new quickstart guide

2021-10-27 Thread GitBox
janhoy commented on a change in pull request #2594: URL: https://github.com/apache/lucene-solr/pull/2594#discussion_r737229976 ## File path: solr/solr-ref-guide/src/quickstart.adoc ## @@ -0,0 +1,140 @@ += Quickstart Guide +:experimental: +// Licensed to the Apache Software Foun

[jira] [Resolved] (LUCENE-10206) Implement O(1) count on query cache

2021-10-27 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10206. --- Fix Version/s: main (9.0) Resolution: Fixed > Implement O(1) count on query cache >

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-27 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434769#comment-17434769 ] Michael McCandless commented on LUCENE-10207: - I love this idea!  Using the

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434803#comment-17434803 ] ASF subversion and git services commented on LUCENE-9660: - Commi

[jira] [Commented] (LUCENE-10163) Review top-level *.txt and *.md files

2021-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434808#comment-17434808 ] ASF subversion and git services commented on LUCENE-10163: -- Co

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434801#comment-17434801 ] ASF subversion and git services commented on LUCENE-9660: - Commi

[jira] [Commented] (LUCENE-10198) Allow external JAVA_OPTS in gradlew scripts; use sane defaults (heap, stack and system proxies)

2021-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434807#comment-17434807 ] ASF subversion and git services commented on LUCENE-10198: -- Co

[jira] [Commented] (LUCENE-10154) NumericLeafComparator to define getPointValues

2021-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434802#comment-17434802 ] ASF subversion and git services commented on LUCENE-10154: -- Co

[jira] [Commented] (LUCENE-10198) Allow external JAVA_OPTS in gradlew scripts; use sane defaults (heap, stack and system proxies)

2021-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434804#comment-17434804 ] ASF subversion and git services commented on LUCENE-10198: -- Co

[jira] [Commented] (LUCENE-10199) Drop ZIP binary distribution from release artifacts

2021-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434806#comment-17434806 ] ASF subversion and git services commented on LUCENE-10199: -- Co

[jira] [Commented] (LUCENE-10206) Implement O(1) count on query cache

2021-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434809#comment-17434809 ] ASF subversion and git services commented on LUCENE-10206: -- Co

[jira] [Commented] (LUCENE-10163) Review top-level *.txt and *.md files

2021-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434805#comment-17434805 ] ASF subversion and git services commented on LUCENE-10163: -- Co

[GitHub] [lucene] nik9000 commented on pull request #415: LUCENE-10206 Implement O(1) count on query cache

2021-10-27 Thread GitBox
nik9000 commented on pull request #415: URL: https://github.com/apache/lucene/pull/415#issuecomment-952923025 > jpountz merged commit 941df98 into apache:main 5 hours ago Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Created] (LUCENE-10208) Minimum score can decrease in concurrent search

2021-10-27 Thread Jim Ferenczi (Jira)
Jim Ferenczi created LUCENE-10208: - Summary: Minimum score can decrease in concurrent search Key: LUCENE-10208 URL: https://issues.apache.org/jira/browse/LUCENE-10208 Project: Lucene - Core I

[GitHub] [lucene-solr] chatman commented on a change in pull request #2594: SOLR-14726: Initial draft of a new quickstart guide

2021-10-27 Thread GitBox
chatman commented on a change in pull request #2594: URL: https://github.com/apache/lucene-solr/pull/2594#discussion_r737538697 ## File path: solr/solr-ref-guide/src/quickstart.adoc ## @@ -0,0 +1,140 @@ += Quickstart Guide +:experimental: +// Licensed to the Apache Software Fou

[GitHub] [lucene] apanimesh061 commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-27 Thread GitBox
apanimesh061 commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r737588612 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -143,6 +143,106 @@ private int cacheFi

[GitHub] [lucene] jtibshirani commented on a change in pull request #413: LUCENE-9614: Fix KnnVectorQuery failure when numDocs is 0

2021-10-27 Thread GitBox
jtibshirani commented on a change in pull request #413: URL: https://github.com/apache/lucene/pull/413#discussion_r737599366 ## File path: lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java ## @@ -25,18 +25,10 @@ import java.io.IOException; import java.util

[GitHub] [lucene] mayya-sharipova opened a new pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-10-27 Thread GitBox
mayya-sharipova opened a new pull request #416: URL: https://github.com/apache/lucene/pull/416 Currently HNSW has only a single layer. This patch attempts to make multi-layered. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [lucene] mayya-sharipova commented on pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-10-27 Thread GitBox
mayya-sharipova commented on pull request #416: URL: https://github.com/apache/lucene/pull/416#issuecomment-953142944 Benchmarking based on @jtibshirani [setup](based on https://github.com/jtibshirani/lucene/pull/1) baseline: main branch candidate: this PR **glove-25-angula

[GitHub] [lucene] mayya-sharipova edited a comment on pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-10-27 Thread GitBox
mayya-sharipova edited a comment on pull request #416: URL: https://github.com/apache/lucene/pull/416#issuecomment-953142944 Benchmarking based on @jtibshirani [setup](based on https://github.com/jtibshirani/lucene/pull/1) baseline: main branch candidate: this PR **glove-25

[GitHub] [lucene] jtibshirani merged pull request #413: LUCENE-9614: Fix KnnVectorQuery failure when numDocs is 0

2021-10-27 Thread GitBox
jtibshirani merged pull request #413: URL: https://github.com/apache/lucene/pull/413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Commented] (LUCENE-9614) Implement KNN Query

2021-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434996#comment-17434996 ] ASF subversion and git services commented on LUCENE-9614: - Commi

[GitHub] [lucene] jtibshirani commented on pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-10-27 Thread GitBox
jtibshirani commented on pull request #416: URL: https://github.com/apache/lucene/pull/416#issuecomment-953198759 > As can be seen from the comparison, there is very slight change that the hierarchy brings: a small increase in recall by at the expense of lower QPSs It looks like QPS

[jira] [Updated] (LUCENE-10200) Restructure and modernize the release artifacts

2021-10-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10200: - Description: This is an umbrella issue for various sub-tasks as per my e-mail [1]. [1] [https:

[jira] [Commented] (LUCENE-10200) Restructure and modernize the release artifacts

2021-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435007#comment-17435007 ] ASF subversion and git services commented on LUCENE-10200: -- Co

[jira] [Commented] (LUCENE-10209) Gradle wrapper validation gh workflow step fails with odd messages

2021-10-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435016#comment-17435016 ] ASF subversion and git services commented on LUCENE-10209: -- Co

[jira] [Created] (LUCENE-10209) Gradle wrapper validation gh workflow step fails with odd messages

2021-10-27 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10209: Summary: Gradle wrapper validation gh workflow step fails with odd messages Key: LUCENE-10209 URL: https://issues.apache.org/jira/browse/LUCENE-10209 Project: Lucene

[jira] [Assigned] (LUCENE-10209) Gradle wrapper validation gh workflow step fails with odd messages

2021-10-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-10209: Assignee: Dawid Weiss > Gradle wrapper validation gh workflow step fails with odd messag

[GitHub] [lucene] dsmiley commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-27 Thread GitBox
dsmiley commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r737770485 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -143,6 +143,106 @@ private int cacheFieldVa

[GitHub] [lucene] mayya-sharipova edited a comment on pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-10-27 Thread GitBox
mayya-sharipova edited a comment on pull request #416: URL: https://github.com/apache/lucene/pull/416#issuecomment-953142944 Benchmarking based on @jtibshirani [setup](https://github.com/jtibshirani/lucene/pull/1) baseline: main branch candidate: this PR **glove-25-angular*

[GitHub] [lucene] mayya-sharipova commented on pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-10-27 Thread GitBox
mayya-sharipova commented on pull request #416: URL: https://github.com/apache/lucene/pull/416#issuecomment-953265461 @jtibshirani Thanks for the comment. > I wonder if the first runs are affected by a lack of warm-up? I've added a warmup stage as well, but starting with bog

[GitHub] [lucene] mayya-sharipova edited a comment on pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-10-27 Thread GitBox
mayya-sharipova edited a comment on pull request #416: URL: https://github.com/apache/lucene/pull/416#issuecomment-953265461 @jtibshirani Thanks for the comment. > I wonder if the first runs are affected by a lack of warm-up? I've added a warmup stage as well, but starting w

[GitHub] [lucene] apanimesh061 commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-27 Thread GitBox
apanimesh061 commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r737860855 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -143,6 +143,106 @@ private int cacheFi

[GitHub] [lucene] dsmiley commented on pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-27 Thread GitBox
dsmiley commented on pull request #412: URL: https://github.com/apache/lucene/pull/412#issuecomment-953329902 > Does the new builder class look right to you? Is it expected to remove all setters from this class? This would mean I'll have to modify all their references in other classes and

[GitHub] [lucene] apanimesh061 commented on pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-27 Thread GitBox
apanimesh061 commented on pull request #412: URL: https://github.com/apache/lucene/pull/412#issuecomment-95323 > It looks good at a glance... you/I will see better if you update one of the clients that might want to subclass with extra configuration. Is there any or is this builder sub

[jira] [Updated] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10207: - Attachment: LUCENE-10207_multitermquery.patch > Make TermInSetQuery usable with IndexOrDocValue

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435109#comment-17435109 ] Robert Muir commented on LUCENE-10207: -- I attached a patch that refactors {{TermIn

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435115#comment-17435115 ] Robert Muir commented on LUCENE-10207: -- {quote} Should we try to take deletions in

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435116#comment-17435116 ] Robert Muir commented on LUCENE-10207: -- cc [~uschindler] if you get a chance to lo

[GitHub] [lucene] mayya-sharipova edited a comment on pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-10-27 Thread GitBox
mayya-sharipova edited a comment on pull request #416: URL: https://github.com/apache/lucene/pull/416#issuecomment-953142944 Benchmarking based on @jtibshirani [setup](https://github.com/jtibshirani/lucene/pull/1) baseline: main branch candidate: this PR **glove-25-angular*

[GitHub] [lucene] apanimesh061 edited a comment on pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-27 Thread GitBox
apanimesh061 edited a comment on pull request #412: URL: https://github.com/apache/lucene/pull/412#issuecomment-95323 > It looks good at a glance... you/I will see better if you update one of the clients that might want to subclass with extra configuration. Is there any or is this buil

[GitHub] [lucene-solr] noblepaul merged pull request #2596: SOLR-15722: Delete Replica does not delete the Per replica state

2021-10-27 Thread GitBox
noblepaul merged pull request #2596: URL: https://github.com/apache/lucene-solr/pull/2596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[jira] [Commented] (LUCENE-10207) Make TermInSetQuery usable with IndexOrDocValuesQuery

2021-10-27 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435190#comment-17435190 ] Adrien Grand commented on LUCENE-10207: --- I have vague memories of playing with th