[GitHub] [lucene] janhoy commented on pull request #358: Add JAVA_OPTS to download the gradle-wrapper jar behind proxy.

2021-10-22 Thread GitBox
janhoy commented on pull request #358: URL: https://github.com/apache/lucene/pull/358#issuecomment-949359383 I have also seen other tools respecting `http_proxy` env, so that would be a nice solution. Is this something that should be fixed upstream (instead/as well)? -- This is a

[GitHub] [lucene] dweiss commented on pull request #358: Add JAVA_OPTS to download the gradle-wrapper jar behind proxy.

2021-10-22 Thread GitBox
dweiss commented on pull request #358: URL: https://github.com/apache/lucene/pull/358#issuecomment-949369176 There are two things, it seems: if we always pass -Djava.net.useSystemProxies=true to the downloader, it should respect the system proxy settings (which is great). The http_proxy en

[GitHub] [lucene] balmukundblr commented on pull request #358: Add JAVA_OPTS to download the gradle-wrapper jar behind proxy.

2021-10-22 Thread GitBox
balmukundblr commented on pull request #358: URL: https://github.com/apache/lucene/pull/358#issuecomment-949745511 > There are two things, it seems: if we always pass -Djava.net.useSystemProxies=true to the downloader, it should respect the system proxy settings (which is great). The http_

[GitHub] [lucene] balmukundblr commented on pull request #358: Add JAVA_OPTS to download the gradle-wrapper jar behind proxy.

2021-10-22 Thread GitBox
balmukundblr commented on pull request #358: URL: https://github.com/apache/lucene/pull/358#issuecomment-949747082 > I looked it up. It does seem to be a widespread (and old) convention indeed. I think it'd be good to take it into account. Would it work for you to pass proxy settings via e

[jira] [Created] (LUCENE-10197) Move setters in UnifiedHighlighter to use builders to make it thread-safe

2021-10-22 Thread Animesh Pandey (Jira)
Animesh Pandey created LUCENE-10197: --- Summary: Move setters in UnifiedHighlighter to use builders to make it thread-safe Key: LUCENE-10197 URL: https://issues.apache.org/jira/browse/LUCENE-10197 Pro

[jira] [Commented] (LUCENE-9431) UnifiedHighlighter: Make WEIGHT_MATCHES the default

2021-10-22 Thread Animesh Pandey (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433187#comment-17433187 ] Animesh Pandey commented on LUCENE-9431: [~dsmiley] How do I modify the status o

[jira] [Updated] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety

2021-10-22 Thread Animesh Pandey (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Animesh Pandey updated LUCENE-10197: Summary: UnifiedHighlighter should use builders for thread-safety (was: Move setters in

[GitHub] [lucene] dsmiley merged pull request #362: LUCENE-9431: UnifiedHighlighter WEIGHT_MATCHES is now true by default

2021-10-22 Thread GitBox
dsmiley merged pull request #362: URL: https://github.com/apache/lucene/pull/362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-9431) UnifiedHighlighter: Make WEIGHT_MATCHES the default

2021-10-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433194#comment-17433194 ] ASF subversion and git services commented on LUCENE-9431: - Commi

[jira] [Resolved] (LUCENE-9431) UnifiedHighlighter: Make WEIGHT_MATCHES the default

2021-10-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-9431. -- Assignee: David Smiley Resolution: Fixed > UnifiedHighlighter: Make WEIGHT_MATCHES the d

[jira] [Commented] (LUCENE-9431) UnifiedHighlighter: Make WEIGHT_MATCHES the default

2021-10-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433195#comment-17433195 ] David Smiley commented on LUCENE-9431: -- Other than closing an issue that becomes in

[jira] [Commented] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety

2021-10-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433196#comment-17433196 ] David Smiley commented on LUCENE-10197: --- FYI Lucene 9 feature-freeze is November

[jira] [Commented] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety

2021-10-22 Thread Animesh Pandey (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433214#comment-17433214 ] Animesh Pandey commented on LUCENE-10197: - Does this mean any code change would

[jira] [Commented] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety

2021-10-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433218#comment-17433218 ] David Smiley commented on LUCENE-10197: --- If this misses Nov 1st, then yes, thus w