dweiss commented on pull request #358: URL: https://github.com/apache/lucene/pull/358#issuecomment-949369176
There are two things, it seems: if we always pass -Djava.net.useSystemProxies=true to the downloader, it should respect the system proxy settings (which is great). The http_proxy environment variable convention seems unrelated and it'd have to be implemented separately (in the downloader again?). The third issue - this patch - is also valuable since it allows the user to bypass whatever else is set up. I don't have a proxy and don't intend to play with it so somebody with access to such infrastructure would have to test it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
