[jira] [Commented] (LUCENE-10184) Move "how to contribute" documentation to the git repo

2021-10-17 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429662#comment-17429662 ] Jan Høydahl commented on LUCENE-10184: -- +1 I also suggested similar for Solr proje

[jira] [Commented] (LUCENE-10163) Review top-level *.txt and *.md files

2021-10-17 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429670#comment-17429670 ] Tomoko Uchida commented on LUCENE-10163: bq. I think a pragmatic approach is to

[GitHub] [lucene] mocobeta opened a new pull request #390: Remove pointer to no longer exists file

2021-10-17 Thread GitBox
mocobeta opened a new pull request #390: URL: https://github.com/apache/lucene/pull/390 BUILD.md is no longer exists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[jira] [Commented] (LUCENE-10163) Review top-level *.txt and *.md files

2021-10-17 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429675#comment-17429675 ] Tomoko Uchida commented on LUCENE-10163: Maybe related to this issue, I removed

[GitHub] [lucene] mocobeta merged pull request #390: LUCENE-10163: Remove pointer to no longer exists file

2021-10-17 Thread GitBox
mocobeta merged pull request #390: URL: https://github.com/apache/lucene/pull/390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-10163) Review top-level *.txt and *.md files

2021-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429679#comment-17429679 ] ASF subversion and git services commented on LUCENE-10163: -- Co

[jira] [Commented] (LUCENE-10170) Regression in stored fields compression in 9.0

2021-10-17 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429690#comment-17429690 ] Michael Sokolov commented on LUCENE-10170: -- IIRC luceneutil does have some sup

[jira] [Commented] (LUCENE-10180) Remove usage of lambdas in SegmentMerger?

2021-10-17 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429694#comment-17429694 ] Michael Sokolov commented on LUCENE-10180: -- Thanks for digging - does the prop

[jira] [Commented] (LUCENE-10184) Move "how to contribute" documentation to the git repo

2021-10-17 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429704#comment-17429704 ] Tomoko Uchida commented on LUCENE-10184: Also, top-level README's "Building wit

[jira] [Updated] (LUCENE-10159) Index corruption: IndexOutOfBoundsException for doc values

2021-10-17 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-10159: - Status: Patch Available (was: Open) > Index corruption: IndexOutOfBoundsException for doc valu

[GitHub] [lucene] rmuir commented on a change in pull request #389: LUCENE-10159: Fix invalid access in sorted set dv

2021-10-17 Thread GitBox
rmuir commented on a change in pull request #389: URL: https://github.com/apache/lucene/pull/389#discussion_r730451580 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java ## @@ -1402,15 +1403,23 @@ public int docID() { @Ov

[GitHub] [lucene] dnhatn commented on a change in pull request #389: LUCENE-10159: Fix invalid access in sorted set dv

2021-10-17 Thread GitBox
dnhatn commented on a change in pull request #389: URL: https://github.com/apache/lucene/pull/389#discussion_r730454030 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java ## @@ -1402,15 +1403,23 @@ public int docID() { @O

[GitHub] [lucene] dnhatn commented on a change in pull request #389: LUCENE-10159: Fix invalid access in sorted set dv

2021-10-17 Thread GitBox
dnhatn commented on a change in pull request #389: URL: https://github.com/apache/lucene/pull/389#discussion_r730456115 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java ## @@ -1402,15 +1403,23 @@ public int docID() { @O

[GitHub] [lucene] janhoy opened a new pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-17 Thread GitBox
janhoy opened a new pull request #391: URL: https://github.com/apache/lucene/pull/391 https://issues.apache.org/jira/browse/LUCENE-9997 This is the second pass of changes to smoketester for the new gradle build. * Adapt to the new source-tgz file layout * Tested gradlew comm

[GitHub] [lucene] janhoy commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-17 Thread GitBox
janhoy commented on pull request #391: URL: https://github.com/apache/lucene/pull/391#issuecomment-945210830 The smoketester is tested locally and currently stops at **verify maven artifact sigs** ``` command "gpg --homedir /tmp/smoke_lucene_9.0.0_537d435f5ee7c884221371a59673b878d82f

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-17 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429776#comment-17429776 ] Jan Høydahl commented on LUCENE-9997: - New PR [https://github.com/apache/lucene/pull

[jira] [Comment Edited] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-17 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428828#comment-17428828 ] Jan Høydahl edited comment on LUCENE-9997 at 10/17/21, 11:06 PM: -

[jira] [Comment Edited] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-17 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429776#comment-17429776 ] Jan Høydahl edited comment on LUCENE-9997 at 10/17/21, 11:11 PM: -

[GitHub] [lucene] janhoy commented on pull request #391: LUCENE-9997 Second pass smoketester fixes for 9.0

2021-10-17 Thread GitBox
janhoy commented on pull request #391: URL: https://github.com/apache/lucene/pull/391#issuecomment-945212495 Reporoduce like this ``` git checkout -b janhoy-lucene9997-smoketester-part-2 main git pull https://github.com/janhoy/lucene.git lucene9997-smoketester-part-2 python3

[GitHub] [lucene] janhoy merged pull request #388: LUCENE-10163 Move LICENSE and NOTICE file to top level

2021-10-17 Thread GitBox
janhoy merged pull request #388: URL: https://github.com/apache/lucene/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-10163) Review top-level *.txt and *.md files

2021-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429777#comment-17429777 ] ASF subversion and git services commented on LUCENE-10163: -- Co

[GitHub] [lucene] dnhatn commented on pull request #389: LUCENE-10159: Fix invalid access in sorted set dv

2021-10-17 Thread GitBox
dnhatn commented on pull request #389: URL: https://github.com/apache/lucene/pull/389#issuecomment-945276042 @rmuir I pushed https://github.com/apache/lucene/pull/389/commits/4ee7a6bd90d275a7df193a87aea3836c65a786ff to write more trailing bytes. Would you mind taking another look? Thank yo

[GitHub] [lucene] rmuir commented on pull request #389: LUCENE-10159: Fix invalid access in sorted set dv

2021-10-17 Thread GitBox
rmuir commented on pull request #389: URL: https://github.com/apache/lucene/pull/389#issuecomment-945322135 Hmm, sorry if I'm being overly nitpicky, but it doesn't seem good to mix this concern into `DirectWriter`? It has nothing to do with `DirectWriter`. Seems like writing the extra `0`

[GitHub] [lucene] rmuir commented on pull request #389: LUCENE-10159: Fix invalid access in sorted set dv

2021-10-17 Thread GitBox
rmuir commented on pull request #389: URL: https://github.com/apache/lucene/pull/389#issuecomment-945324108 Also, given that writing a sortedset is really just a sortednumeric, isn't sortednumeric impacted by the bug too? would it easier to test for this bug with a sortednumeric unit test?

[GitHub] [lucene] dsmiley commented on a change in pull request #362: LUCENE-9431: UnifiedHighlighter WEIGHT_MATCHES is now true by default

2021-10-17 Thread GitBox
dsmiley commented on a change in pull request #362: URL: https://github.com/apache/lucene/pull/362#discussion_r730550959 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -1168,9 +1174,12 @@ public CacheHelper getReader

[GitHub] [lucene] apanimesh061 commented on a change in pull request #362: LUCENE-9431: UnifiedHighlighter WEIGHT_MATCHES is now true by default

2021-10-17 Thread GitBox
apanimesh061 commented on a change in pull request #362: URL: https://github.com/apache/lucene/pull/362#discussion_r730555792 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -1168,9 +1174,12 @@ public CacheHelper getR

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-10-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429816#comment-17429816 ] Dawid Weiss commented on LUCENE-9997: - Hi Jan. These maven artifacts are not signed

[GitHub] [lucene] jpountz commented on a change in pull request #389: LUCENE-10159: Fix invalid access in sorted set dv

2021-10-17 Thread GitBox
jpountz commented on a change in pull request #389: URL: https://github.com/apache/lucene/pull/389#discussion_r730575499 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java ## @@ -1402,15 +1403,23 @@ public int docID() { @

[GitHub] [lucene] jpountz commented on pull request #389: LUCENE-10159: Fix invalid access in sorted set dv

2021-10-17 Thread GitBox
jpountz commented on pull request #389: URL: https://github.com/apache/lucene/pull/389#issuecomment-945374678 I think the test is useful to double check that the change is fixing the issue but I'm not sure if we should merge it: it wouldn't be manageable to have tests at the doc-values for

[jira] [Commented] (LUCENE-10182) TestRamUsageEstimator asserts trivial equality

2021-10-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429819#comment-17429819 ] Dawid Weiss commented on LUCENE-10182: -- This helps now but doesn't prevent the err