[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427492#comment-17427492
]
Dawid Weiss commented on LUCENE-9997:
-
Yep, these sanity checks are needed without a
uschindler commented on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-940751666
> It was pretty surprising this issue hid out for so long. I've run it on 5
towers, a mini desktop box, a couple raspberry pi's, across Ubuntu,
Arch/Manjaro, x86, arm, bash, zsh
Dawid Weiss created LUCENE-10167:
Summary: Run tests on PRs (and pushes to the main branch)
Key: LUCENE-10167
URL: https://issues.apache.org/jira/browse/LUCENE-10167
Project: Lucene - Core
Is
dweiss commented on a change in pull request #376:
URL: https://github.com/apache/lucene/pull/376#discussion_r726860485
##
File path: .github/workflows/gradle-precommit.yml
##
@@ -33,9 +37,46 @@ jobs:
${{ runner.os }}-gradle-
- name: Initialize gradle settings
dweiss commented on a change in pull request #376:
URL: https://github.com/apache/lucene/pull/376#discussion_r726860999
##
File path: .github/workflows/gradle-precommit.yml
##
@@ -5,9 +5,13 @@ on:
branches:
- '*'
+ push:
+branches:
+- main_test
Review comm
[
https://issues.apache.org/jira/browse/LUCENE-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427529#comment-17427529
]
Dawid Weiss commented on LUCENE-10167:
--
PoC here:
https://github.com/apache/lucene
[
https://issues.apache.org/jira/browse/LUCENE-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427535#comment-17427535
]
Adrien Grand commented on LUCENE-10167:
---
woah this looks fantastic
> Run tests o
iverase commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r726883304
##
File path:
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java
##
@@ -372,6 +372,12 @@ private void checkAndThrow() {
}
}
markrmiller commented on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-940786135
On Tue, Oct 12, 2021 at 2:45 AM Uwe Schindler ***@***.***>
wrote:
> It was pretty surprising this issue hid out for so long. I've run it on 5
> towers, a mini deskto
iverase commented on a change in pull request #7:
URL: https://github.com/apache/lucene/pull/7#discussion_r726886141
##
File path:
lucene/test-framework/src/java/org/apache/lucene/index/AssertingLeafReader.java
##
@@ -1090,6 +1090,13 @@ private void assertStats(int maxDoc) {
romseygeek merged pull request #370:
URL: https://github.com/apache/lucene/pull/370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
[
https://issues.apache.org/jira/browse/LUCENE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-10140.
Fix Version/s: main (9.0)
Resolution: Fixed
Thanks [~khitrin]!
> Minimizing inter
[
https://issues.apache.org/jira/browse/LUCENE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427544#comment-17427544
]
ASF subversion and git services commented on LUCENE-10140:
--
Co
iverase commented on pull request #7:
URL: https://github.com/apache/lucene/pull/7#issuecomment-940789913
Another iteration: I moved the index tree to the PointValues API, which
start looking more to the structure proposed in LUCENE-9619.
--
This is an automated message from the
uschindler commented on pull request #365:
URL: https://github.com/apache/lucene/pull/365#issuecomment-940798656
> I only recently learned that while Apache has unlimited action minutes,
they do have limited throughput for the whole organization and I don't want to
eat them here.
I
[
https://issues.apache.org/jira/browse/LUCENE-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10167:
-
Attachment: screenshot-1.png
> Run tests on PRs (and pushes to the main branch)
> -
[
https://issues.apache.org/jira/browse/LUCENE-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427574#comment-17427574
]
Dawid Weiss commented on LUCENE-10167:
--
I don't see any improvement in bumping max
[
https://issues.apache.org/jira/browse/LUCENE-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427574#comment-17427574
]
Dawid Weiss edited comment on LUCENE-10167 at 10/12/21, 9:15 AM:
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427612#comment-17427612
]
Robert Muir commented on LUCENE-9997:
-
I'm not knowledgeable on the limits but on my
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9997:
Attachment: image-2021-10-12-12-47-11-480.png
> Revisit smoketester for 9.0 build
> --
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9997:
Attachment: image-2021-10-12-12-48-15-373.png
> Revisit smoketester for 9.0 build
> --
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427614#comment-17427614
]
Dawid Weiss commented on LUCENE-9997:
-
You can actually see what's taking how long o
[
https://issues.apache.org/jira/browse/LUCENE-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427630#comment-17427630
]
Dawid Weiss commented on LUCENE-10167:
--
I added Windows and MacOS to the job matri
[
https://issues.apache.org/jira/browse/LUCENE-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427638#comment-17427638
]
Dawid Weiss commented on LUCENE-10167:
--
This actually reproduces on those Windows
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427643#comment-17427643
]
Robert Muir commented on LUCENE-9997:
-
yes, slowest tests are in backwards, the back
Robert Muir created LUCENE-10168:
Summary: drop support for 7.0 indexes in 9.0 (master)
Key: LUCENE-10168
URL: https://issues.apache.org/jira/browse/LUCENE-10168
Project: Lucene - Core
Issue
[
https://issues.apache.org/jira/browse/LUCENE-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427651#comment-17427651
]
Adrien Grand commented on LUCENE-10168:
---
Maybe all tests in this module should be
[
https://issues.apache.org/jira/browse/LUCENE-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427656#comment-17427656
]
Dawid Weiss commented on LUCENE-10168:
--
I think this makes sense. Backward-compati
[
https://issues.apache.org/jira/browse/LUCENE-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427664#comment-17427664
]
Michael Sokolov commented on LUCENE-10168:
--
I haven't messed around with these
[
https://issues.apache.org/jira/browse/LUCENE-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427664#comment-17427664
]
Michael Sokolov edited comment on LUCENE-10168 at 10/12/21, 12:56 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427666#comment-17427666
]
Dawid Weiss commented on LUCENE-10168:
--
IntelliJ doesn't use parallel VMs (or rath
[
https://issues.apache.org/jira/browse/LUCENE-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427670#comment-17427670
]
Dawid Weiss commented on LUCENE-10167:
--
I'm going to merge this in. Doesn't seem t
dweiss merged pull request #376:
URL: https://github.com/apache/lucene/pull/376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/LUCENE-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427674#comment-17427674
]
ASF subversion and git services commented on LUCENE-10167:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10167.
--
Fix Version/s: main (9.0)
Resolution: Fixed
> Run tests on PRs (and pushes to the main
[
https://issues.apache.org/jira/browse/LUCENE-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reassigned LUCENE-10167:
Assignee: Dawid Weiss
> Run tests on PRs (and pushes to the main branch)
> -
Dawid Weiss created LUCENE-10169:
Summary: TestDirectIODirectory fails on Windows Server 2019
Key: LUCENE-10169
URL: https://issues.apache.org/jira/browse/LUCENE-10169
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427683#comment-17427683
]
Dawid Weiss commented on LUCENE-10169:
--
I added Windows and MacOS to the job matri
[
https://issues.apache.org/jira/browse/LUCENE-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427684#comment-17427684
]
Dawid Weiss commented on LUCENE-10169:
--
Uwe, what do you think we should do? :)
>
[
https://issues.apache.org/jira/browse/LUCENE-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427690#comment-17427690
]
Robert Muir commented on LUCENE-10168:
--
The reason they only take 6 minutes on you
janhoy commented on pull request #376:
URL: https://github.com/apache/lucene/pull/376#issuecomment-941041404
Is there a way to exclude the tests if no source files are changed for a PR?
I.e. if the PR only touches certain paths such as `README.md`, `dev-tools/`,
`dev-docs/`, `help/` etc?
[
https://issues.apache.org/jira/browse/LUCENE-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427692#comment-17427692
]
Dawid Weiss commented on LUCENE-10168:
--
We do now:
[https://github.com/apache/luc
[
https://issues.apache.org/jira/browse/LUCENE-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427691#comment-17427691
]
Robert Muir commented on LUCENE-10168:
--
And instead of hiding the problem under th
dweiss commented on pull request #376:
URL: https://github.com/apache/lucene/pull/376#issuecomment-941045691
There is but it'd make the rules more complex. Why bother? They're
randomized - let them run? The validation checks take approximately what the
tests take in a concurrent job.
--
dweiss commented on pull request #376:
URL: https://github.com/apache/lucene/pull/376#issuecomment-941049642
https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#onpushpull_requestpaths
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/LUCENE-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427701#comment-17427701
]
Michael Sokolov commented on LUCENE-10168:
--
This is what I see:
{{> Task :
[
https://issues.apache.org/jira/browse/LUCENE-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427703#comment-17427703
]
Dawid Weiss commented on LUCENE-10168:
--
I'd move them to nightly runs. Or mark the
msokolov commented on a change in pull request #366:
URL: https://github.com/apache/lucene/pull/366#discussion_r727213376
##
File path: lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java
##
@@ -234,10 +235,65 @@ public void testScoreDotProduct() throws IOExce
cpoerschke commented on a change in pull request #355:
URL: https://github.com/apache/lucene/pull/355#discussion_r727204711
##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -141,21 +146,19 @@ def checkJARMetaData(desc, jarFile, gitRevision, version):
raise R
magibney commented on pull request #208:
URL: https://github.com/apache/lucene/pull/208#issuecomment-941133721
Closing; see discussion at
[LUCENE-10023](https://issues.apache.org/jira/browse/LUCENE-10023).
Note: I may continue to update the PR branch.
--
This is an automated message f
magibney closed pull request #208:
URL: https://github.com/apache/lucene/pull/208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
zhaih commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-941199775
Hmmm one of the test failed
```
ERROR: The following test(s) have failed:
> Task :lucene:analysis:smartcn:test
- org.apache.lucene.index.TestIndexFileDeleter.testExcInDec
jtibshirani commented on pull request #366:
URL: https://github.com/apache/lucene/pull/366#issuecomment-941239181
@msokolov this is a good point, I will play around with this more and loop
back here.
--
This is an automated message from the Apache Git Service.
To respond to the message,
dweiss commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-941302842
The stack trace is interesting though - looks like a double close:
```
org.apache.lucene.index.TestIndexFileDeleter > testExcInDecRef FAILED
org.apache.lucene.store.Alrea
dweiss edited a comment on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-941302842
The stack trace is interesting though - looks like access to a closed reader
pool:
```
org.apache.lucene.index.TestIndexFileDeleter > testExcInDecRef FAILED
org.a
dweiss commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-941304810
I re-ran the jobs. The stack trace from the error does look suspicious
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
janhoy opened a new pull request #2590:
URL: https://github.com/apache/lucene-solr/pull/2590
https://issues.apache.org/jira/browse/SOLR-15691
Back-ported from apache/solr main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
janhoy merged pull request #2590:
URL: https://github.com/apache/lucene-solr/pull/2590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsu
janhoy commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r727570779
##
File path: lucene/distribution/build.gradle
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427951#comment-17427951
]
Chris M. Hostetter commented on LUCENE-9488:
{quote}I filed a large PR with
janhoy commented on a change in pull request #355:
URL: https://github.com/apache/lucene/pull/355#discussion_r727577690
##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -141,21 +146,19 @@ def checkJARMetaData(desc, jarFile, gitRevision, version):
raise Runti
janhoy commented on a change in pull request #355:
URL: https://github.com/apache/lucene/pull/355#discussion_r727578265
##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -1043,122 +823,81 @@ def getPOMcoordinate(treeRoot):
packaging = 'jar' if packaging is None else
janhoy commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r727591613
##
File path: lucene/distribution/build.gradle
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
janhoy commented on a change in pull request #372:
URL: https://github.com/apache/lucene/pull/372#discussion_r727608870
##
File path: lucene/distribution/binary-release.gradle
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * co
janhoy commented on pull request #355:
URL: https://github.com/apache/lucene/pull/355#issuecomment-941797977
I have started validating the smoke tester on the artifacts produced by the
new build targets in #372
I find bugs in the gradle build, but also bugs in the smoketester :)
Onc
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428039#comment-17428039
]
Dawid Weiss commented on LUCENE-9488:
-
{quote}although i have no idea why it says yo
[
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428043#comment-17428043
]
Dawid Weiss commented on LUCENE-9488:
-
[~janhoy] Can I merge this in? Have you had a
67 matches
Mail list logo
