[ 
https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427951#comment-17427951
 ] 

Chris M. Hostetter commented on LUCENE-9488:
--------------------------------------------

{quote}I filed a large PR with most of the packaging code rewritten from 
scratch:
 [https://github.com/apache/lucene/pull/372]

It does make a few changes on how things work. Please take a look at 
help/publishing.txt and try it out, letting me know if you run into any issues.
{quote}
I didn't review the details of PR372, but i did try it out based on dawid's 
comments (somwhere?) about wether using gpg-agent still worked...
 * NOTE: couldn't get 372.patch to apply to main, and {{--3way}} said it 
refered to blobs that i don't have ... so instead i checked out 
[remotes/dweiss/LUCENE-9488|https://github.com/dweiss/lucene/tree/LUCENE-9488] 
directly...

Using gpg-agent per the instructions in help/publishing.txt worked fine ... 
although i have no idea why it says you need {{--max-workers 1}} ?

when i removed the [explicit check dawid 
hardcoded|https://github.com/dweiss/lucene/commit/2b5467866a5f0f9cda06456379ff4988f8ef41fe]
 for max.workers, i was able to build & sign (using my gpg-agent) the assembly 
using my normal 5 worker threads w/oproblem...
{code:java}
$ gradle -Pvalidation.git.failOnModified=false -Psign -PuseGpg 
-Psigning.gnupg.keyName=4DDFABAF68C0F906B76CD9A09C784577F8F58E19 assembleRelease
{code}
(maybe this {{--max-workers 1-}} check is just a different solution to the same 
problem already mentioned in {{gpgSigning.txt}} about {{Inappropriate ioctl for 
device}}, and we can/should mention {{--max-workers 1}} as an additional 
workaround for that problem?)

other comments on the edits to {{gpgSigning.txt}}:
 * should we maybe re-name / re-title this file to something like 
{{usingExternalGpgAgent.txt}} since it's no longer the "starting" point for 
learning about how to gpg sign things in the code base?
 * I feel like any/all mention of {{signing.gnupg.passphrase}} should be 
removed?
 ** if folks are willing to provide their passphrase as a gradle property, they 
can now use {{-Psigning.password=....}} instead.  There's no reason to use 
{{-PuseGpg}} (and involve an external gpg / gpg-agent process)

> Update release process to work with Gradle.
> -------------------------------------------
>
>                 Key: LUCENE-9488
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9488
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Erick Erickson
>            Assignee: Mike Drob
>            Priority: Major
>         Attachments: Skjermbilde 2021-10-05 kl. 11.18.28.png
>
>          Time Spent: 20h 10m
>  Remaining Estimate: 0h
>
> The release process needs to reflect using Gradle rather than Ant. I suspect 
> this will be a significant task, thus it has its own JIRA



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to