[
https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422000#comment-17422000
]
Uwe Schindler commented on LUCENE-10126:
bq. The ML team at Elastic reported th
[
https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422038#comment-17422038
]
Adrien Grand commented on LUCENE-10130:
---
This looks like an easy win. +1
> HnswG
[
https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422042#comment-17422042
]
Adrien Grand commented on LUCENE-10130:
---
Looking at the call sites, it looks like
[
https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422059#comment-17422059
]
Robert Muir commented on LUCENE-10130:
--
sorry, I don't know much of the data patte
[
https://issues.apache.org/jira/browse/LUCENE-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422088#comment-17422088
]
Michael McCandless commented on LUCENE-9983:
[~zhai7631] I think this can be
mayya-sharipova opened a new pull request #326:
URL: https://github.com/apache/lucene/pull/326
Add extra test on _doc sort to test
that search with after collects all documents
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
[
https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422096#comment-17422096
]
Mayya Sharipova commented on LUCENE-10126:
--
[~uschindler] "ML team" stands fo
dnhatn commented on a change in pull request #326:
URL: https://github.com/apache/lucene/pull/326#discussion_r718495134
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestSortOptimization.java
##
@@ -483,6 +484,42 @@ public void testDocSortOptimizationWithAfter()
danmuzi commented on a change in pull request #285:
URL: https://github.com/apache/lucene/pull/285#discussion_r718565282
##
File path:
lucene/analysis/nori/src/test/org/apache/lucene/analysis/ko/TestKoreanTokenizer.java
##
@@ -592,6 +594,29 @@ public void testCombining() throw
mikemccand commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r715531456
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockReader.java
##
@@ -384,15 +390,18 @@ protected AutomatonNextTerm
mikemccand commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r718577915
##
File path: lucene/core/src/java/org/apache/lucene/search/AutomatonQuery.java
##
@@ -65,7 +66,19 @@
* @param automaton Automaton to run, terms that
jpountz opened a new pull request #327:
URL: https://github.com/apache/lucene/pull/327
There was a regression introduced in
https://github.com/apache/lucene/pull/107/files#diff-49b11ced76acedf749c5a5a0ff6e7fe93b8fb64caf8697e487a56f4f7adbb510
where we moved from write logic that was op
[
https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422190#comment-17422190
]
Adrien Grand commented on LUCENE-10125:
---
I found another change that happened ove
[
https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422213#comment-17422213
]
Julie Tibshirani commented on LUCENE-10128:
---
Thanks for looking into this! A
thelabdude opened a new pull request #2585:
URL: https://github.com/apache/lucene-solr/pull/2585
Backport of https://github.com/apache/solr/pull/318 to 8x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422218#comment-17422218
]
Robert Muir commented on LUCENE-10128:
--
yeah i probably used the wrong terminology
thelabdude merged pull request #2585:
URL: https://github.com/apache/lucene-solr/pull/2585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
Chris Hegarty created LUCENE-10132:
--
Summary: Support addition of diagnostics by custom merge policies
Key: LUCENE-10132
URL: https://issues.apache.org/jira/browse/LUCENE-10132
Project: Lucene - Core
thelabdude opened a new pull request #328:
URL: https://github.com/apache/lucene/pull/328
Port from https://github.com/apache/solr/pull/318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
thelabdude opened a new pull request #2586:
URL: https://github.com/apache/lucene-solr/pull/2586
Backport of https://github.com/apache/lucene-solr/pull/2585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
thelabdude merged pull request #2586:
URL: https://github.com/apache/lucene-solr/pull/2586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
[
https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-10128:
--
Summary: large indexing slowdown after increasing HNSW beam width (was:
increased HN
ChrisHegarty opened a new pull request #329:
URL: https://github.com/apache/lucene/pull/329
# Description
It is currently not possible for custom merge policies to add additional
diagnostics.
# Solution
Add a new method, `SegmentInfo::addDiagnostics`, that allows to add
[
https://issues.apache.org/jira/browse/LUCENE-10124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422257#comment-17422257
]
Adrien Grand commented on LUCENE-10124:
---
I'm getting similar disk usage between t
Adrien Grand created LUCENE-10133:
-
Summary: Specialize write path for sorted doc values
Key: LUCENE-10133
URL: https://issues.apache.org/jira/browse/LUCENE-10133
Project: Lucene - Core
Issue
jpountz opened a new pull request #330:
URL: https://github.com/apache/lucene/pull/330
The min value, the max value, the GCD and the set of unique values don't need
to be computed on sorted doc values.
--
This is an automated message from the Apache Git Service.
To respond to the messa
jpountz merged pull request #327:
URL: https://github.com/apache/lucene/pull/327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422262#comment-17422262
]
ASF subversion and git services commented on LUCENE-10125:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422263#comment-17422263
]
Adrien Grand commented on LUCENE-10125:
---
I merged the enhancement to see if it ma
dnhatn opened a new pull request #331:
URL: https://github.com/apache/lucene/pull/331
This commit re-introduces the chunk scoring logic in AssertingBulkScorer and
enables it in TestSortOptimization.
I have run 100 iterations over the core tests with this change.
--
This is an automat
mayya-sharipova commented on pull request #326:
URL: https://github.com/apache/lucene/pull/326#issuecomment-930450785
@dnhatn Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mayya-sharipova merged pull request #326:
URL: https://github.com/apache/lucene/pull/326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-un
[
https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422340#comment-17422340
]
ASF subversion and git services commented on LUCENE-10126:
--
Co
uschindler commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r718852626
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
}
uschindler commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r718856191
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
}
jpountz commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r718867031
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
}
jpountz commented on a change in pull request #331:
URL: https://github.com/apache/lucene/pull/331#discussion_r718874053
##
File path:
lucene/core/src/java/org/apache/lucene/search/FilterLeafCollector.java
##
@@ -42,6 +42,11 @@ public void collect(int doc) throws IOException {
uschindler opened a new pull request #332:
URL: https://github.com/apache/lucene/pull/332
Another variant of #327
It may be better from optimization standpoint, because it uses a hard typed
MethodHandle casting the long to correct type. The MH can be passed as constant
into the loop
uschindler commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r718919001
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
}
mdmarshmallow commented on a change in pull request #304:
URL: https://github.com/apache/lucene/pull/304#discussion_r718921856
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
##
@@ -253,4 +257,92 @@ public FacetResult getTopChildren(
uschindler opened a new pull request #333:
URL: https://github.com/apache/lucene/pull/333
Yet another idea without MethodHandles (although internally it's the same)
but simple functional interface as replacement for #327
--
This is an automated message from the Apache Git Service.
To res
uschindler commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r718935962
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
}
jpountz merged pull request #327:
URL: https://github.com/apache/lucene/pull/327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
danmuzi commented on a change in pull request #285:
URL: https://github.com/apache/lucene/pull/285#discussion_r718565282
##
File path:
lucene/analysis/nori/src/test/org/apache/lucene/analysis/ko/TestKoreanTokenizer.java
##
@@ -592,6 +594,29 @@ public void testCombining() throw
uschindler commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r718852626
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
}
mayya-sharipova commented on pull request #326:
URL: https://github.com/apache/lucene/pull/326#issuecomment-930450785
@dnhatn Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mayya-sharipova merged pull request #326:
URL: https://github.com/apache/lucene/pull/326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-un
thelabdude merged pull request #2586:
URL: https://github.com/apache/lucene-solr/pull/2586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
jpountz commented on a change in pull request #331:
URL: https://github.com/apache/lucene/pull/331#discussion_r718874053
##
File path:
lucene/core/src/java/org/apache/lucene/search/FilterLeafCollector.java
##
@@ -42,6 +42,11 @@ public void collect(int doc) throws IOException {
mdmarshmallow commented on a change in pull request #304:
URL: https://github.com/apache/lucene/pull/304#discussion_r718921856
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
##
@@ -253,4 +257,92 @@ public FacetResult getTopChildren(
[
https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422467#comment-17422467
]
Julie Tibshirani commented on LUCENE-10130:
---
+1 to switch to a better data st
gautamworah96 commented on a change in pull request #304:
URL: https://github.com/apache/lucene/pull/304#discussion_r718007188
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
##
@@ -43,7 +47,7 @@ protected IntTaxonomyFacets(
sup
mikemccand commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r715531456
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/IntersectBlockReader.java
##
@@ -384,15 +390,18 @@ protected AutomatonNextTerm
dnhatn commented on a change in pull request #326:
URL: https://github.com/apache/lucene/pull/326#discussion_r718495134
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestSortOptimization.java
##
@@ -483,6 +484,42 @@ public void testDocSortOptimizationWithAfter()
jpountz commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r718867031
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
}
thelabdude merged pull request #2585:
URL: https://github.com/apache/lucene-solr/pull/2585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
[
https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422467#comment-17422467
]
Julie Tibshirani edited comment on LUCENE-10130 at 9/30/21, 1:03 AM:
dnhatn commented on pull request #331:
URL: https://github.com/apache/lucene/pull/331#issuecomment-930702477
@jpountz Thanks for review + explain. I've addressed your feedback. Can you
please take another look?
--
This is an automated message from the Apache Git Service.
To respond to th
dweiss commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r719102651
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
}
jpountz commented on a change in pull request #327:
URL: https://github.com/apache/lucene/pull/327#discussion_r719106766
##
File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java
##
@@ -94,38 +91,54 @@ private void flush() throws IOException {
}
jpountz commented on a change in pull request #331:
URL: https://github.com/apache/lucene/pull/331#discussion_r719112805
##
File path:
lucene/test-framework/src/java/org/apache/lucene/search/AssertingScorable.java
##
@@ -45,13 +45,41 @@ public static Scorable wrap(Scorable in)
61 matches
Mail list logo
