mikemccand commented on a change in pull request #225:
URL: https://github.com/apache/lucene/pull/225#discussion_r718577915
##########
File path: lucene/core/src/java/org/apache/lucene/search/AutomatonQuery.java
##########
@@ -65,7 +66,19 @@
* @param automaton Automaton to run, terms that are accepted are considered
a match.
*/
public AutomatonQuery(final Term term, Automaton automaton) {
- this(term, automaton, Operations.DEFAULT_DETERMINIZE_WORK_LIMIT);
+ this(term, automaton, ByteRunnable.TYPE.DFA);
+ }
+
+ /**
+ * Create a new AutomatonQuery from an {@link Automaton}. Using specific
type of RunAutomaton
+ *
+ * @param term Term containing field and possibly some pattern structure.
The term text is
+ * ignored.
+ * @param automaton Automaton to run, terms that are accepted are considered
a match.
+ * @param runnableType NFA or DFA
Review comment:
Could you improve these javadocs a bit? And specifically include a
warning that `NFA` has uncertain performance impact?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
