[jira] [Commented] (LUCENE-10079) DocValues new iterator API is missing in migration guide

2021-09-28 Thread Bernhard Scholz (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421232#comment-17421232 ] Bernhard Scholz commented on LUCENE-10079: -- Thanks a lot, I think we will be a

[jira] [Commented] (LUCENE-10125) Investigate indexing throughput regression on NYC Taxis between 2021-04-12 and 2021-05-24

2021-09-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421269#comment-17421269 ] Adrien Grand commented on LUCENE-10125: --- The slowdown for stored fields pointed o

[jira] [Commented] (LUCENE-9484) Allow index sorting to happen after the fact

2021-09-28 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421357#comment-17421357 ] Jan Høydahl commented on LUCENE-9484: - There are commits both to master and branch_8

[jira] [Created] (LUCENE-10127) Minor enhancement to doc values writes

2021-09-28 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10127: - Summary: Minor enhancement to doc values writes Key: LUCENE-10127 URL: https://issues.apache.org/jira/browse/LUCENE-10127 Project: Lucene - Core Issue Type

[jira] [Updated] (LUCENE-10127) Minor enhancement to doc values writes

2021-09-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-10127: -- Description: I was looking at the NYC Taxis benchmark recently, whose indexing bottleneck is

[GitHub] [lucene] jpountz opened a new pull request #325: LUCENE-10127: Minor speedup to doc values writes.

2021-09-28 Thread GitBox
jpountz opened a new pull request #325: URL: https://github.com/apache/lucene/pull/325 This reduces a bit the overhead of writing doc values. On the NYC Taxis benchmark this resulted in ~10% faster merges for doc values. -- This is an automated message from the Apache Git Service. To r

[jira] [Created] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10128: Summary: increased HNSW beam with causes large indexing perf regression Key: LUCENE-10128 URL: https://issues.apache.org/jira/browse/LUCENE-10128 Project: Lucene - Co

[jira] [Commented] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421367#comment-17421367 ] Robert Muir commented on LUCENE-10128: -- I also notice in the stacksize=12 cpu prof

[jira] [Commented] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421372#comment-17421372 ] Robert Muir commented on LUCENE-10128: -- my blind guess on that, is that we might b

[jira] [Updated] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10128: - Attachment: Screen_Shot_2021-09-28_at_09.10.15.png Status: Open (was: Open) > increase

[jira] [Commented] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421375#comment-17421375 ] Robert Muir commented on LUCENE-10128: -- The impact on vectorsearch performance is

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

2021-09-28 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421376#comment-17421376 ] Nhat Nguyen commented on LUCENE-10126: -- [~jpountz] Elasticsearch uses a [chunked|

[jira] [Updated] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10128: - Attachment: LUCENE-10128_remove_sparse_fixed_bitset_reflection.patch > increased HNSW beam with

[jira] [Commented] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421387#comment-17421387 ] Robert Muir commented on LUCENE-10128: -- attached is a trivial patch to remove refl

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

2021-09-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421393#comment-17421393 ] Adrien Grand commented on LUCENE-10126: --- Ah, of course! I had forgotten about thi

[jira] [Commented] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421394#comment-17421394 ] ASF subversion and git services commented on LUCENE-10128: -- Co

[jira] [Created] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-09-28 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10129: Summary: Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])? Key: LUCENE-10129 URL: https://issues.apache.org/jira/browse/LUCENE-10129

[jira] [Commented] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421400#comment-17421400 ] Robert Muir commented on LUCENE-10128: -- I fixed it here, but added a followup to t

[jira] [Commented] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-09-28 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421402#comment-17421402 ] Uwe Schindler commented on LUCENE-10129: +1 It is also no backwards compatibil

[jira] [Commented] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-09-28 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421404#comment-17421404 ] Uwe Schindler commented on LUCENE-10129: The problem is not necessarily the ref

[jira] [Commented] (LUCENE-10125) Investigate indexing throughput regression on NYC Taxis between 2021-04-12 and 2021-05-24

2021-09-28 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421414#comment-17421414 ] Uwe Schindler commented on LUCENE-10125: [~jpountz]: The new benchmarks by Mike

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
mayya-sharipova commented on a change in pull request #324: URL: https://github.com/apache/lucene/pull/324#discussion_r717623319 ## File path: lucene/core/src/test/org/apache/lucene/search/TestSortOptimization.java ## @@ -730,4 +732,52 @@ public void testRandomLong() throws IO

[GitHub] [lucene] mayya-sharipova commented on pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
mayya-sharipova commented on pull request #324: URL: https://github.com/apache/lucene/pull/324#issuecomment-929275183 @dnhatn Thanks for spotting this bug. I was wondering if instead of `NumericComparator`, we should make this change in `DefaultBulkScorer::score(LeafCollector collector, Bi

[jira] [Commented] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-09-28 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421423#comment-17421423 ] Dawid Weiss commented on LUCENE-10129: -- +1. > Add RamUsageEstimator shallowSizeOf

[jira] [Created] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2021-09-28 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10130: Summary: HnswGraph could make use of a SparseFixedBitSet.getAndSet Key: LUCENE-10130 URL: https://issues.apache.org/jira/browse/LUCENE-10130 Project: Lucene - Core

[jira] [Commented] (LUCENE-10128) increased HNSW beam with causes large indexing perf regression

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421434#comment-17421434 ] Robert Muir commented on LUCENE-10128: -- I opened LUCENE-10130 related to the bitse

[jira] [Commented] (LUCENE-10125) Investigate indexing throughput regression on NYC Taxis between 2021-04-12 and 2021-05-24

2021-09-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421452#comment-17421452 ] Adrien Grand commented on LUCENE-10125: --- [~uschindler] I'm seeing a 5% speedup at

[GitHub] [lucene] jpountz merged pull request #325: LUCENE-10127: Minor speedup to doc values writes.

2021-09-28 Thread GitBox
jpountz merged pull request #325: URL: https://github.com/apache/lucene/pull/325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] jpountz merged pull request #322: LUCENE-10125: Speed up computation of exceptions.

2021-09-28 Thread GitBox
jpountz merged pull request #322: URL: https://github.com/apache/lucene/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] jpountz commented on pull request #322: LUCENE-10125: Speed up computation of exceptions.

2021-09-28 Thread GitBox
jpountz commented on pull request #322: URL: https://github.com/apache/lucene/pull/322#issuecomment-929337085 @gsmiller I merged this change in order to be able to iterate quickly on the NYC Taxis benchmark, but if you have feedback about the change, I'll be happy to address it in a differ

[jira] [Commented] (LUCENE-10125) Investigate indexing throughput regression on NYC Taxis between 2021-04-12 and 2021-05-24

2021-09-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421456#comment-17421456 ] ASF subversion and git services commented on LUCENE-10125: -- Co

[jira] [Commented] (LUCENE-10127) Minor enhancement to doc values writes

2021-09-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421454#comment-17421454 ] ASF subversion and git services commented on LUCENE-10127: -- Co

[jira] [Commented] (LUCENE-10125) Investigate indexing throughput regression on NYC Taxis between 2021-04-12 and 2021-05-24

2021-09-28 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421477#comment-17421477 ] Uwe Schindler commented on LUCENE-10125: bq. Uwe Schindler I'm seeing a 5% spee

[jira] [Commented] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-09-28 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421481#comment-17421481 ] Uwe Schindler commented on LUCENE-10129: Can we also do someting for reference

[jira] [Comment Edited] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-09-28 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421481#comment-17421481 ] Uwe Schindler edited comment on LUCENE-10129 at 9/28/21, 4:01 PM: ---

[GitHub] [lucene] mayya-sharipova commented on pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
mayya-sharipova commented on pull request #324: URL: https://github.com/apache/lucene/pull/324#issuecomment-929369296 Sorry, I've realized it may not be easy to change things in DefaultBulkScorer::score. I am ok with the current approach as well, but we also need to add these changes in `D

[jira] [Commented] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421485#comment-17421485 ] Robert Muir commented on LUCENE-10129: -- There is already a fast Object[] one, whic

[jira] [Commented] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-09-28 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421488#comment-17421488 ] Uwe Schindler commented on LUCENE-10129: OK. I was afraid this one may not be c

[jira] [Commented] (LUCENE-10125) Investigate indexing throughput regression on NYC Taxis between 2021-04-12 and 2021-05-24

2021-09-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421491#comment-17421491 ] Adrien Grand commented on LUCENE-10125: --- FWIW I've been checking out April commit

[jira] [Commented] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421493#comment-17421493 ] Robert Muir commented on LUCENE-10129: -- {noformat} public org.apache.lucene.util

[jira] [Commented] (LUCENE-10125) Investigate indexing throughput regression on NYC Taxis between 2021-04-12 and 2021-05-24

2021-09-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421499#comment-17421499 ] Adrien Grand commented on LUCENE-10125: --- Here are timings in millis. I have two n

[jira] [Commented] (LUCENE-10129) Add RamUsageEstimator shallowSizeOf(long[]) overload that just calls sizeOf(long[])?

2021-09-28 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421501#comment-17421501 ] Uwe Schindler commented on LUCENE-10129: OK, then let's only add the alias over

[GitHub] [lucene] msokolov commented on a change in pull request #322: LUCENE-10125: Speed up computation of exceptions.

2021-09-28 Thread GitBox
msokolov commented on a change in pull request #322: URL: https://github.com/apache/lucene/pull/322#discussion_r717756811 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java ## @@ -59,24 +60,30 @@ static boolean allEqual(long[] l) { /** Encode

[GitHub] [lucene] jpountz commented on a change in pull request #322: LUCENE-10125: Speed up computation of exceptions.

2021-09-28 Thread GitBox
jpountz commented on a change in pull request #322: URL: https://github.com/apache/lucene/pull/322#discussion_r717760225 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java ## @@ -59,24 +60,30 @@ static boolean allEqual(long[] l) { /** Encode 1

[jira] [Commented] (LUCENE-10125) Investigate indexing throughput regression on NYC Taxis between 2021-04-12 and 2021-05-24

2021-09-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421512#comment-17421512 ] Adrien Grand commented on LUCENE-10125: --- For the record I ran async profiler excl

[GitHub] [lucene] dnhatn commented on pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
dnhatn commented on pull request #324: URL: https://github.com/apache/lucene/pull/324#issuecomment-929485273 @jpountz @mayya-sharipova Thanks for reviews. I think this is ready again. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
mayya-sharipova commented on a change in pull request #324: URL: https://github.com/apache/lucene/pull/324#discussion_r717832090 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java ## @@ -271,30 +271,7 @@ public void visit(int docID,

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
mayya-sharipova commented on a change in pull request #324: URL: https://github.com/apache/lucene/pull/324#discussion_r717833807 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java ## @@ -271,30 +271,7 @@ public void visit(int docID,

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
mayya-sharipova commented on a change in pull request #324: URL: https://github.com/apache/lucene/pull/324#discussion_r717833807 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java ## @@ -271,30 +271,7 @@ public void visit(int docID,

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
mayya-sharipova commented on a change in pull request #324: URL: https://github.com/apache/lucene/pull/324#discussion_r717833807 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java ## @@ -271,30 +271,7 @@ public void visit(int docID,

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
mayya-sharipova commented on a change in pull request #324: URL: https://github.com/apache/lucene/pull/324#discussion_r717839238 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java ## @@ -271,30 +271,7 @@ public void visit(int docID,

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
mayya-sharipova commented on a change in pull request #324: URL: https://github.com/apache/lucene/pull/324#discussion_r717839238 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java ## @@ -271,30 +271,7 @@ public void visit(int docID,

[GitHub] [lucene] dnhatn commented on a change in pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
dnhatn commented on a change in pull request #324: URL: https://github.com/apache/lucene/pull/324#discussion_r717864552 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java ## @@ -271,30 +271,7 @@ public void visit(int docID, byte[] pa

[GitHub] [lucene] dnhatn commented on pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
dnhatn commented on pull request #324: URL: https://github.com/apache/lucene/pull/324#issuecomment-929557401 Thanks Mayya for reviewing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [lucene] dnhatn merged pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
dnhatn merged pull request #324: URL: https://github.com/apache/lucene/pull/324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

2021-09-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421627#comment-17421627 ] ASF subversion and git services commented on LUCENE-10126: -- Co

[GitHub] [lucene] jpountz merged pull request #320: LUCENE-10123: Handling of singletons in DocValuesConsumer.

2021-09-28 Thread GitBox
jpountz merged pull request #320: URL: https://github.com/apache/lucene/pull/320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] mayya-sharipova commented on pull request #315: Disk write and read of hnsw graph

2021-09-28 Thread GitBox
mayya-sharipova commented on pull request #315: URL: https://github.com/apache/lucene/pull/315#issuecomment-928298036 @msokolov Thanks a lot for your review. I've tried to address your comments in the second comment. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] gsmiller merged pull request #2584: LUCENE-10070: Skip deleted documents during facet counting for all documents

2021-09-28 Thread GitBox
gsmiller merged pull request #2584: URL: https://github.com/apache/lucene-solr/pull/2584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [lucene] jpountz commented on a change in pull request #322: LUCENE-10125: Speed up computation of exceptions.

2021-09-28 Thread GitBox
jpountz commented on a change in pull request #322: URL: https://github.com/apache/lucene/pull/322#discussion_r717760225 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java ## @@ -59,24 +60,30 @@ static boolean allEqual(long[] l) { /** Encode 1

[GitHub] [lucene] jpountz merged pull request #325: LUCENE-10127: Minor speedup to doc values writes.

2021-09-28 Thread GitBox
jpountz merged pull request #325: URL: https://github.com/apache/lucene/pull/325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] gsmiller commented on a change in pull request #320: LUCENE-10123: Handling of singletons in DocValuesConsumer.

2021-09-28 Thread GitBox
gsmiller commented on a change in pull request #320: URL: https://github.com/apache/lucene/pull/320#discussion_r717012176 ## File path: lucene/core/src/java/org/apache/lucene/index/DocValues.java ## @@ -157,97 +157,12 @@ public int getValueCount() { /** An empty SortedNume

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
mayya-sharipova commented on a change in pull request #324: URL: https://github.com/apache/lucene/pull/324#discussion_r717623319 ## File path: lucene/core/src/test/org/apache/lucene/search/TestSortOptimization.java ## @@ -730,4 +732,52 @@ public void testRandomLong() throws IO

[GitHub] [lucene] jpountz commented on a change in pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
jpountz commented on a change in pull request #324: URL: https://github.com/apache/lucene/pull/324#discussion_r717275045 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java ## @@ -292,7 +293,11 @@ public long cost() { @Over

[GitHub] [lucene] jpountz merged pull request #322: LUCENE-10125: Speed up computation of exceptions.

2021-09-28 Thread GitBox
jpountz merged pull request #322: URL: https://github.com/apache/lucene/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] dnhatn commented on pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
dnhatn commented on pull request #324: URL: https://github.com/apache/lucene/pull/324#issuecomment-929485273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [lucene] msokolov commented on a change in pull request #322: LUCENE-10125: Speed up computation of exceptions.

2021-09-28 Thread GitBox
msokolov commented on a change in pull request #322: URL: https://github.com/apache/lucene/pull/322#discussion_r717756811 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java ## @@ -59,24 +60,30 @@ static boolean allEqual(long[] l) { /** Encode

[GitHub] [lucene] jpountz commented on a change in pull request #320: LUCENE-10123: Handling of singletons in DocValuesConsumer.

2021-09-28 Thread GitBox
jpountz commented on a change in pull request #320: URL: https://github.com/apache/lucene/pull/320#discussion_r716936132 ## File path: lucene/core/src/java/org/apache/lucene/index/DocValues.java ## @@ -157,97 +157,12 @@ public int getValueCount() { /** An empty SortedNumer

[GitHub] [lucene] dnhatn merged pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
dnhatn merged pull request #324: URL: https://github.com/apache/lucene/pull/324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #315: Disk write and read of hnsw graph

2021-09-28 Thread GitBox
mayya-sharipova commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r717053652 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -77,13 +80,23 @@ Lucene90Hn

[GitHub] [lucene] jpountz commented on pull request #322: LUCENE-10125: Speed up computation of exceptions.

2021-09-28 Thread GitBox
jpountz commented on pull request #322: URL: https://github.com/apache/lucene/pull/322#issuecomment-929337085 @gsmiller I merged this change in order to be able to iterate quickly on the NYC Taxis benchmark, but if you have feedback about the change, I'll be happy to address it in a differ

[GitHub] [lucene] mayya-sharipova commented on pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
mayya-sharipova commented on pull request #324: URL: https://github.com/apache/lucene/pull/324#issuecomment-929275183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [lucene] dnhatn commented on a change in pull request #324: LUCENE-10126: Fix competitiveIterator wrongly skip documents

2021-09-28 Thread GitBox
dnhatn commented on a change in pull request #324: URL: https://github.com/apache/lucene/pull/324#discussion_r717864552 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java ## @@ -271,30 +271,7 @@ public void visit(int docID, byte[] pa

[GitHub] [lucene] jpountz commented on pull request #320: LUCENE-10123: Handling of singletons in DocValuesConsumer.

2021-09-28 Thread GitBox
jpountz commented on pull request #320: URL: https://github.com/apache/lucene/pull/320#issuecomment-928907986 Thanks for the review @gsmiller ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [lucene] xiaoshi2013 commented on pull request #301: LUCENE-10100: configuration items of the alg file are adapted to the …

2021-09-28 Thread GitBox
xiaoshi2013 commented on pull request #301: URL: https://github.com/apache/lucene/pull/301#issuecomment-928628191 Hi @jpountz, can you review this pr? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-solr] gsmiller closed pull request #2577: LUCENE-10070: Skip deleted documents during facet counting for all documents

2021-09-28 Thread GitBox
gsmiller closed pull request #2577: URL: https://github.com/apache/lucene-solr/pull/2577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [lucene] gsmiller merged pull request #323: Move CHANGES entry for LUCENE-10070 under 8.11 after backport

2021-09-28 Thread GitBox
gsmiller merged pull request #323: URL: https://github.com/apache/lucene/pull/323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene] jtibshirani commented on pull request #315: Disk write and read of hnsw graph

2021-09-28 Thread GitBox
jtibshirani commented on pull request #315: URL: https://github.com/apache/lucene/pull/315#issuecomment-929588721 I'm not an expert in designing formats, but this looks good to me overall! I left some minor comments. > EG I saw Julie changed the default beam-width to 100, which is fi

[GitHub] [lucene] jtibshirani commented on a change in pull request #315: Disk write and read of hnsw graph

2021-09-28 Thread GitBox
jtibshirani commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r717773659 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsFormat.java ## @@ -69,10 +99,12 @@ static final String META

[jira] [Created] (LUCENE-10131) Release wizard for 8x fails to generate Backcompat Indexes for unstable branch (main)

2021-09-28 Thread Timothy Potter (Jira)
Timothy Potter created LUCENE-10131: --- Summary: Release wizard for 8x fails to generate Backcompat Indexes for unstable branch (main) Key: LUCENE-10131 URL: https://issues.apache.org/jira/browse/LUCENE-10131

[jira] [Commented] (LUCENE-10131) Release wizard for 8x fails to generate Backcompat Indexes for unstable branch (main)

2021-09-28 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421785#comment-17421785 ] Timothy Potter commented on LUCENE-10131: - Here's the command the releaseWizard

[GitHub] [lucene] gautamworah96 commented on a change in pull request #304: LUCENE 10080 Added FixedBitSet for one counts when counting taxonomy facet labels

2021-09-28 Thread GitBox
gautamworah96 commented on a change in pull request #304: URL: https://github.com/apache/lucene/pull/304#discussion_r718007188 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java ## @@ -43,7 +47,7 @@ protected IntTaxonomyFacets( sup

[GitHub] [lucene] gautamworah96 commented on a change in pull request #304: LUCENE 10080 Added FixedBitSet for one counts when counting taxonomy facet labels

2021-09-28 Thread GitBox
gautamworah96 commented on a change in pull request #304: URL: https://github.com/apache/lucene/pull/304#discussion_r718007188 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java ## @@ -43,7 +47,7 @@ protected IntTaxonomyFacets( sup

[GitHub] [lucene] gautamworah96 commented on a change in pull request #304: LUCENE 10080 Added FixedBitSet for one counts when counting taxonomy facet labels

2021-09-28 Thread GitBox
gautamworah96 commented on a change in pull request #304: URL: https://github.com/apache/lucene/pull/304#discussion_r718007188 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java ## @@ -43,7 +47,7 @@ protected IntTaxonomyFacets( sup

[jira] [Updated] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10130: - Attachment: LUCENE-10130.patch > HnswGraph could make use of a SparseFixedBitSet.getAndSet > --

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

2021-09-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421829#comment-17421829 ] ASF subversion and git services commented on LUCENE-10126: -- Co

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

2021-09-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421894#comment-17421894 ] Robert Muir commented on LUCENE-10126: -- this latest commit caused 45 test failures

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

2021-09-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421895#comment-17421895 ] ASF subversion and git services commented on LUCENE-10126: -- Co