mayya-sharipova commented on a change in pull request #324:
URL: https://github.com/apache/lucene/pull/324#discussion_r717833807
##########
File path:
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java
##########
@@ -271,30 +271,7 @@ public void visit(int docID, byte[] packedValue) {
@Override
public DocIdSetIterator competitiveIterator() {
- if (enableSkipping == false) return null;
- return new DocIdSetIterator() {
- private int docID = -1;
-
- @Override
- public int nextDoc() throws IOException {
- return advance(docID + 1);
- }
-
- @Override
- public int docID() {
- return docID;
- }
-
- @Override
- public long cost() {
- return competitiveIterator.cost();
- }
-
- @Override
- public int advance(int target) throws IOException {
- return docID = competitiveIterator.advance(target);
- }
- };
+ return enableSkipping ? competitiveIterator : null;
Review comment:
In `DefaultBulkScorer:score`, we get:
```java
DocIdSetIterator competitiveIterator = collector.competitiveIterator();
```
If we use your current change, we will always get the same object, and even
if `competitiveIterator` gets updated we will get the same object, while we
want to get a new updated competitive iterator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
