[GitHub] [lucene] gautamworah96 commented on a change in pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-09-02 Thread GitBox
gautamworah96 commented on a change in pull request #242: URL: https://github.com/apache/lucene/pull/242#discussion_r700700949 ## File path: lucene/core/src/java/org/apache/lucene/search/FilterWeight.java ## @@ -67,4 +67,9 @@ public Scorer scorer(LeafReaderContext context) thro

[GitHub] [lucene] jpountz commented on a change in pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-09-02 Thread GitBox
jpountz commented on a change in pull request #242: URL: https://github.com/apache/lucene/pull/242#discussion_r700872648 ## File path: lucene/core/src/test/org/apache/lucene/search/TestBooleanQuery.java ## @@ -736,6 +737,49 @@ public void testReqOptPropagatesApproximations() th

[GitHub] [lucene] rmuir commented on pull request #275: LUCENE-10083: Analyzer and stemmer for Telugu language

2021-09-02 Thread GitBox
rmuir commented on pull request #275: URL: https://github.com/apache/lucene/pull/275#issuecomment-911508052 looking good! fyi, I just recently saw this test resource for telugu language: https://github.com/castorini/mr.tydi in their paper, they had to run with the whitespaceanalyzer

[jira] [Commented] (LUCENE-9662) CheckIndex should be concurrent

2021-09-02 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408746#comment-17408746 ] Michael McCandless commented on LUCENE-9662: Whoa, look [how much faster {{C

[GitHub] [lucene] mayya-sharipova commented on pull request #267: LUCENE-10054 Handle hierarchy in graph construction and search

2021-09-02 Thread GitBox
mayya-sharipova commented on pull request #267: URL: https://github.com/apache/lucene/pull/267#issuecomment-911574890 @msokolov Thanks for explanation. Your idea is clear to me and makes sense, and I will implement it in the following PR. I was just thinking if having only `level0Node[]`

[GitHub] [lucene] mayya-sharipova edited a comment on pull request #267: LUCENE-10054 Handle hierarchy in graph construction and search

2021-09-02 Thread GitBox
mayya-sharipova edited a comment on pull request #267: URL: https://github.com/apache/lucene/pull/267#issuecomment-911574890 @msokolov Thanks for the explanation. Your idea is clear to me and makes sense, and I will implement it in the following PR. I was just thinking if having only `le

[GitHub] [lucene] mayya-sharipova edited a comment on pull request #267: LUCENE-10054 Handle hierarchy in graph construction and search

2021-09-02 Thread GitBox
mayya-sharipova edited a comment on pull request #267: URL: https://github.com/apache/lucene/pull/267#issuecomment-911574890 @msokolov Thanks for the explanation. Your idea is clear to me and makes sense, and I will implement it in the following PR. I was just thinking if having only `le

[GitHub] [lucene] mikemccand merged pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-09-02 Thread GitBox
mikemccand merged pull request #179: URL: https://github.com/apache/lucene/pull/179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Commented] (LUCENE-9476) Add a bulk ordinal->FacetLabel API

2021-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408765#comment-17408765 ] ASF subversion and git services commented on LUCENE-9476: - Commi

[GitHub] [lucene] msokolov commented on pull request #267: LUCENE-10054 Handle hierarchy in graph construction and search

2021-09-02 Thread GitBox
msokolov commented on pull request #267: URL: https://github.com/apache/lucene/pull/267#issuecomment-911588395 > Extra work: need to do binary search to map node0 ids to the current level's node ids for search to start. Should not be that bad, as we use eps.length = 1 for levels > 0.

[GitHub] [lucene] mikemccand commented on pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-09-02 Thread GitBox
mikemccand commented on pull request #179: URL: https://github.com/apache/lucene/pull/179#issuecomment-911588393 Merged! @gautamworah96 I think we should backport this one to 8.x? It is just adding a faster API. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (LUCENE-9662) CheckIndex should be concurrent

2021-09-02 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408766#comment-17408766 ] Michael McCandless commented on LUCENE-9662: Hmm, it looks like we didn't fi

[jira] [Created] (LUCENE-10084) Rewrite DocValuesFieldExistsQuery to a MatchAllDocsQuery when docCount == maxDoc

2021-09-02 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10084: - Summary: Rewrite DocValuesFieldExistsQuery to a MatchAllDocsQuery when docCount == maxDoc Key: LUCENE-10084 URL: https://issues.apache.org/jira/browse/LUCENE-10084

[jira] [Created] (LUCENE-10085) Implement Weight#count on DocValuesFieldExistsQuery

2021-09-02 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10085: - Summary: Implement Weight#count on DocValuesFieldExistsQuery Key: LUCENE-10085 URL: https://issues.apache.org/jira/browse/LUCENE-10085 Project: Lucene - Core

[GitHub] [lucene] mayya-sharipova commented on pull request #267: LUCENE-10054 Handle hierarchy in graph construction and search

2021-09-02 Thread GitBox
mayya-sharipova commented on pull request #267: URL: https://github.com/apache/lucene/pull/267#issuecomment-911636658 @jtibshirani > Maybe we could at least prevent ml from being 0 so we could remove the flat graph code path? This would be a nice simplification and I can't think of

[GitHub] [lucene] mayya-sharipova opened a new pull request #277: LUCENE-10040 Correct TestHnswGraph.testSearchWithAcceptOrds

2021-09-02 Thread GitBox
mayya-sharipova opened a new pull request #277: URL: https://github.com/apache/lucene/pull/277 If we set numSeed = 10, this test fails sometimes because it may mark expected results docs (from 0 to 9) as deleted which don't end up being retrieved, resulting in a lower than expected re

[GitHub] [lucene] mayya-sharipova edited a comment on pull request #267: LUCENE-10054 Handle hierarchy in graph construction and search

2021-09-02 Thread GitBox
mayya-sharipova edited a comment on pull request #267: URL: https://github.com/apache/lucene/pull/267#issuecomment-911636658 @jtibshirani > Maybe we could at least prevent ml from being 0 so we could remove the flat graph code path? This would be a nice simplification and I can't th

[GitHub] [lucene] mayya-sharipova edited a comment on pull request #267: LUCENE-10054 Handle hierarchy in graph construction and search

2021-09-02 Thread GitBox
mayya-sharipova edited a comment on pull request #267: URL: https://github.com/apache/lucene/pull/267#issuecomment-911636658 @jtibshirani > Maybe we could at least prevent ml from being 0 so we could remove the flat graph code path? This would be a nice simplification and I can't th

[GitHub] [lucene] mayya-sharipova edited a comment on pull request #267: LUCENE-10054 Handle hierarchy in graph construction and search

2021-09-02 Thread GitBox
mayya-sharipova edited a comment on pull request #267: URL: https://github.com/apache/lucene/pull/267#issuecomment-911636658 @jtibshirani > Maybe we could at least prevent ml from being 0 so we could remove the flat graph code path? This would be a nice simplification and I can't th

[jira] [Commented] (LUCENE-9959) Can we remove threadlocals of stored fields and term vectors

2021-09-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408921#comment-17408921 ] Adrien Grand commented on LUCENE-9959: -- [~zacharymorn] Any concerns with reverting?

[GitHub] [lucene] rmuir merged pull request #275: LUCENE-10083: Analyzer and stemmer for Telugu language

2021-09-02 Thread GitBox
rmuir merged pull request #275: URL: https://github.com/apache/lucene/pull/275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Commented] (LUCENE-10083) Telugu analyzer

2021-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408942#comment-17408942 ] ASF subversion and git services commented on LUCENE-10083: -- Co

[jira] [Commented] (LUCENE-10083) Telugu analyzer

2021-09-02 Thread Vinod Singh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408957#comment-17408957 ] Vinod Singh commented on LUCENE-10083: -- Pull request is merged. Now this ticket sh

[jira] [Commented] (LUCENE-10083) Telugu analyzer

2021-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408959#comment-17408959 ] ASF subversion and git services commented on LUCENE-10083: -- Co

[jira] [Commented] (LUCENE-10083) Telugu analyzer

2021-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408962#comment-17408962 ] ASF subversion and git services commented on LUCENE-10083: -- Co

[jira] [Commented] (LUCENE-10083) Telugu analyzer

2021-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408961#comment-17408961 ] ASF subversion and git services commented on LUCENE-10083: -- Co

[jira] [Resolved] (LUCENE-10083) Telugu analyzer

2021-09-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10083. -- Fix Version/s: 8.10 main (9.0) Resolution: Fixed Thanks [~vi...@vin

[jira] [Commented] (LUCENE-10083) Telugu analyzer

2021-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408960#comment-17408960 ] ASF subversion and git services commented on LUCENE-10083: -- Co

[jira] [Commented] (LUCENE-10035) Simple text codec add multi level skip list data

2021-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408968#comment-17408968 ] ASF subversion and git services commented on LUCENE-10035: -- Co

[jira] [Commented] (LUCENE-10035) Simple text codec add multi level skip list data

2021-09-02 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408975#comment-17408975 ] Adrien Grand commented on LUCENE-10035: --- I just fixed the CHANGES entry, thanks [

[GitHub] [lucene] mayya-sharipova opened a new pull request #278: LUCENE-10063 CorrecttestRandomWithUpdatesAndGraph

2021-09-02 Thread GitBox
mayya-sharipova opened a new pull request #278: URL: https://github.com/apache/lucene/pull/278 Correct BaseKnnVectorsFormatTestCase - Make sure that k > 0 for knn search - Make sure that k doesn't exceed the number of live docs Relates to #262 -- This is an automated mess

[GitHub] [lucene] mayya-sharipova commented on pull request #278: LUCENE-10063 Correct BaseKnnVectorsFormatTestCase.randomWithUpdatesAndGraph

2021-09-02 Thread GitBox
mayya-sharipova commented on pull request #278: URL: https://github.com/apache/lucene/pull/278#issuecomment-911891450 We got the following test failure, as k gets equals to 0: ./gradlew test --tests TestPerFieldKnnVectorsFormat.testRandomWithUpdatesAndGraph -Dtests.seed=186A5AC2377

[jira] [Commented] (LUCENE-10080) Use a bit set to count long-tail of singleton FacetLabels?

2021-09-02 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409027#comment-17409027 ] Greg Miller commented on LUCENE-10080: -- Thanks [~rcmuir], this all makes sense. I

[GitHub] [lucene] msokolov commented on a change in pull request #278: LUCENE-10063 Correct BaseKnnVectorsFormatTestCase.randomWithUpdatesAndGraph

2021-09-02 Thread GitBox
msokolov commented on a change in pull request #278: URL: https://github.com/apache/lucene/pull/278#discussion_r701382708 ## File path: lucene/test-framework/src/java/org/apache/lucene/index/BaseKnnVectorsFormatTestCase.java ## @@ -853,16 +854,25 @@ public void testRandomWithU

[GitHub] [lucene] HoustonPutman opened a new pull request #279: Fix gpg key download in release wizard.

2021-09-02 Thread GitBox
HoustonPutman opened a new pull request #279: URL: https://github.com/apache/lucene/pull/279 Old URL to check the apache id gpg key is no longer available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] mayya-sharipova merged pull request #278: LUCENE-10063 Correct BaseKnnVectorsFormatTestCase.randomWithUpdatesAndGraph

2021-09-02 Thread GitBox
mayya-sharipova merged pull request #278: URL: https://github.com/apache/lucene/pull/278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Commented] (LUCENE-10063) SimpleTextKnnVectorsReader.search needs an implementation

2021-09-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409106#comment-17409106 ] ASF subversion and git services commented on LUCENE-10063: -- Co

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #2564: Fix gpg key download in release wizard.

2021-09-02 Thread GitBox
HoustonPutman opened a new pull request #2564: URL: https://github.com/apache/lucene-solr/pull/2564 Old URL to check the apache id gpg key is no longer available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene-solr] HoustonPutman merged pull request #2564: Fix gpg key download in release wizard.

2021-09-02 Thread GitBox
HoustonPutman merged pull request #2564: URL: https://github.com/apache/lucene-solr/pull/2564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [lucene] HoustonPutman merged pull request #279: Fix gpg key download in release wizard.

2021-09-02 Thread GitBox
HoustonPutman merged pull request #279: URL: https://github.com/apache/lucene/pull/279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[GitHub] [lucene] gautamworah96 commented on a change in pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-09-02 Thread GitBox
gautamworah96 commented on a change in pull request #242: URL: https://github.com/apache/lucene/pull/242#discussion_r701468588 ## File path: lucene/core/src/test/org/apache/lucene/search/TestTermQuery.java ## @@ -103,6 +103,39 @@ public void testCreateWeightDoesNotSeekIfScores

[GitHub] [lucene] gautamworah96 commented on a change in pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-09-02 Thread GitBox
gautamworah96 commented on a change in pull request #242: URL: https://github.com/apache/lucene/pull/242#discussion_r701468588 ## File path: lucene/core/src/test/org/apache/lucene/search/TestTermQuery.java ## @@ -103,6 +103,39 @@ public void testCreateWeightDoesNotSeekIfScores

[GitHub] [lucene] zacharymorn opened a new pull request #280: Revert "LUCENE-9959: Add non thread local based API for term vector reader usage (#180)"

2021-09-02 Thread GitBox
zacharymorn opened a new pull request #280: URL: https://github.com/apache/lucene/pull/280 # Description Revert "LUCENE-9959: Add non thread local based API for term vector reader usage (#180)" This reverts commit 180cfa241b133c75c31daf3628db4979c949f7f6. # Chec

[jira] [Commented] (LUCENE-9959) Can we remove threadlocals of stored fields and term vectors

2021-09-02 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409181#comment-17409181 ] Zach Chen commented on LUCENE-9959: --- Hi [~jpountz], sorry for the delay here, somehow

[GitHub] [lucene] zacharymorn opened a new pull request #281: LUCENE-9662: Update concurrent index checking usage instructions

2021-09-02 Thread GitBox
zacharymorn opened a new pull request #281: URL: https://github.com/apache/lucene/pull/281 # Description Update concurrent index checking usage instructions # Sample output ``` > Task :lucene:core:CheckIndex.main() FAILED ERROR: index path not specified

[jira] [Commented] (LUCENE-9662) CheckIndex should be concurrent

2021-09-02 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409182#comment-17409182 ] Zach Chen commented on LUCENE-9662: --- {quote}Of course, this is on [ridiculously concur

[jira] [Comment Edited] (LUCENE-9662) CheckIndex should be concurrent

2021-09-02 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409182#comment-17409182 ] Zach Chen edited comment on LUCENE-9662 at 9/3/21, 1:06 AM: