jpountz commented on a change in pull request #242:
URL: https://github.com/apache/lucene/pull/242#discussion_r689339399
##
File path: lucene/core/src/java/org/apache/lucene/search/Weight.java
##
@@ -174,6 +174,31 @@ public BulkScorer bulkScorer(LeafReaderContext context)
thro
[
https://issues.apache.org/jira/browse/LUCENE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399608#comment-17399608
]
Adrien Grand commented on LUCENE-10014:
---
Sorry for the delay, I'm currently away
[
https://issues.apache.org/jira/browse/LUCENE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399712#comment-17399712
]
Michael McCandless commented on LUCENE-10014:
-
Thanks [~weizijun] – I'll ha
mikemccand commented on pull request #2551:
URL: https://github.com/apache/lucene-solr/pull/2551#issuecomment-899462512
Thanks @glawson0 -- I'll try to push soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
[
https://issues.apache.org/jira/browse/LUCENE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399722#comment-17399722
]
Michael McCandless commented on LUCENE-10014:
-
OK patch looks good to me –
msokolov opened a new pull request #243:
URL: https://github.com/apache/lucene/pull/243
This includes the commits from the `lucene-solr/master-deprecations` branch
that merged cleanly. I also made a start at fixing some uninteresting
deprecation warnings by either fixing or suppressing.
[
https://issues.apache.org/jira/browse/LUCENE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399731#comment-17399731
]
ASF subversion and git services commented on LUCENE-10014:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399740#comment-17399740
]
Michael Sokolov commented on LUCENE-8638:
-
I opened a PR with the easy changes f
[
https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399740#comment-17399740
]
Michael Sokolov edited comment on LUCENE-8638 at 8/16/21, 12:55 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399740#comment-17399740
]
Michael Sokolov edited comment on LUCENE-8638 at 8/16/21, 12:56 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399740#comment-17399740
]
Michael Sokolov edited comment on LUCENE-8638 at 8/16/21, 12:57 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399740#comment-17399740
]
Michael Sokolov edited comment on LUCENE-8638 at 8/16/21, 12:58 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399744#comment-17399744
]
ASF subversion and git services commented on LUCENE-10014:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-10014:
Fix Version/s: 8.10
9.0
Resolution: Fixed
Sta
mikemccand commented on a change in pull request #241:
URL: https://github.com/apache/lucene/pull/241#discussion_r689517013
##
File path:
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java
##
@@ -43,9 +43,9 @@ public float compare(float[] v1, float[] v2
mikemccand merged pull request #2551:
URL: https://github.com/apache/lucene-solr/pull/2551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
mikemccand commented on pull request #2551:
URL: https://github.com/apache/lucene-solr/pull/2551#issuecomment-899536443
Thanks @glawson0!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
[
https://issues.apache.org/jira/browse/LUCENE-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399759#comment-17399759
]
ASF subversion and git services commented on LUCENE-9963:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399760#comment-17399760
]
ASF subversion and git services commented on LUCENE-9963:
-
Commi
jtibshirani merged pull request #239:
URL: https://github.com/apache/lucene/pull/239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
[
https://issues.apache.org/jira/browse/LUCENE-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399772#comment-17399772
]
ASF subversion and git services commented on LUCENE-10040:
--
Co
jtibshirani opened a new pull request #244:
URL: https://github.com/apache/lucene/pull/244
The simple text codec doesn't support kNN searches, so the test will fail
when
we randomly chose to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message
jtibshirani commented on a change in pull request #241:
URL: https://github.com/apache/lucene/pull/241#discussion_r689652805
##
File path: lucene/demo/src/java/org/apache/lucene/demo/SearchFiles.java
##
@@ -242,4 +266,54 @@ public static void doPagingSearch(
}
}
jtibshirani merged pull request #244:
URL: https://github.com/apache/lucene/pull/244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
[
https://issues.apache.org/jira/browse/LUCENE-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399820#comment-17399820
]
ASF subversion and git services commented on LUCENE-9614:
-
Commi
jtibshirani commented on pull request #235:
URL: https://github.com/apache/lucene/pull/235#issuecomment-899643050
I noticed a couple tiny things after you merged: e48be68, 29ed390.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
[
https://issues.apache.org/jira/browse/LUCENE-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399829#comment-17399829
]
ASF subversion and git services commented on LUCENE-9614:
-
Commi
gautamworah96 commented on a change in pull request #242:
URL: https://github.com/apache/lucene/pull/242#discussion_r689713492
##
File path: lucene/core/src/java/org/apache/lucene/search/Weight.java
##
@@ -174,6 +174,27 @@ public BulkScorer bulkScorer(LeafReaderContext context)
msokolov commented on pull request #244:
URL: https://github.com/apache/lucene/pull/244#issuecomment-899735409
Nice catch - I assume there was a test failure somewhere? Thanks for fixing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
msokolov commented on a change in pull request #241:
URL: https://github.com/apache/lucene/pull/241#discussion_r689807080
##
File path:
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java
##
@@ -43,9 +43,9 @@ public float compare(float[] v1, float[] v2)
msokolov commented on a change in pull request #241:
URL: https://github.com/apache/lucene/pull/241#discussion_r689807176
##
File path: lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java
##
@@ -36,6 +36,7 @@
/** TestKnnVectorQuery tests KnnVectorQuery. */
p
msokolov commented on a change in pull request #241:
URL: https://github.com/apache/lucene/pull/241#discussion_r689807397
##
File path: lucene/demo/src/java/org/apache/lucene/demo/IndexFiles.java
##
@@ -201,6 +235,18 @@ static void indexDoc(IndexWriter writer, Path file, long
msokolov commented on a change in pull request #241:
URL: https://github.com/apache/lucene/pull/241#discussion_r689815437
##
File path: lucene/demo/src/java/org/apache/lucene/demo/SearchFiles.java
##
@@ -242,4 +266,54 @@ public static void doPagingSearch(
}
}
}
+
msokolov commented on a change in pull request #241:
URL: https://github.com/apache/lucene/pull/241#discussion_r689815756
##
File path: lucene/demo/src/java/org/apache/lucene/demo/SearchFiles.java
##
@@ -242,4 +266,54 @@ public static void doPagingSearch(
}
}
}
+
msokolov commented on a change in pull request #241:
URL: https://github.com/apache/lucene/pull/241#discussion_r689822979
##
File path: lucene/demo/src/java/org/apache/lucene/demo/SearchFiles.java
##
@@ -242,4 +266,54 @@ public static void doPagingSearch(
}
}
}
+
msokolov commented on a change in pull request #241:
URL: https://github.com/apache/lucene/pull/241#discussion_r689827096
##
File path: lucene/demo/src/java/org/apache/lucene/demo/knn/KnnVectorDict.java
##
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
msokolov commented on a change in pull request #241:
URL: https://github.com/apache/lucene/pull/241#discussion_r689903690
##
File path: lucene/demo/src/java/org/apache/lucene/demo/knn/KnnVectorDict.java
##
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
msokolov commented on a change in pull request #241:
URL: https://github.com/apache/lucene/pull/241#discussion_r689904039
##
File path: lucene/demo/src/java/org/apache/lucene/demo/SearchFiles.java
##
@@ -242,4 +266,54 @@ public static void doPagingSearch(
}
}
}
+
msokolov commented on pull request #241:
URL: https://github.com/apache/lucene/pull/241#issuecomment-899917516
Thanks for all the great comments! I incorporated changes to address and
think the demo will be much clearer for them.
--
This is an automated message from the Apache Git Servic
39 matches
Mail list logo
