jpountz commented on a change in pull request #242: URL: https://github.com/apache/lucene/pull/242#discussion_r689339399
########## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ########## @@ -174,6 +174,31 @@ public BulkScorer bulkScorer(LeafReaderContext context) throws IOException { return new DefaultBulkScorer(scorer); } + /** + * Counts the number of documents that match a given {@link Weight#parentQuery} in a leaf. The Review comment: We might need to be explicit that deleted documents are ignored, since this is not the case for other Weight APIs like {{Weight#scorer}}. ```suggestion * Counts the number of live documents that match a given {@link Weight#parentQuery} in a leaf. The ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org