[GitHub] [lucene] msokolov commented on pull request #241: LUCENE-10016: Added KnnVector index/query support to demo

2021-08-14 Thread GitBox
msokolov commented on pull request #241: URL: https://github.com/apache/lucene/pull/241#issuecomment-898904915 I fixed a few small issues, and plan to merge after the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Updated] (LUCENE-8638) Remove deprecated code in main

2021-08-14 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov updated LUCENE-8638: Summary: Remove deprecated code in main (was: Remove deprecated code in master) > Remove

[jira] [Commented] (LUCENE-8638) Remove deprecated code in main

2021-08-14 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399265#comment-17399265 ] Michael Sokolov commented on LUCENE-8638: - I'm a little unclear why we opted to

[GitHub] [lucene] gsmiller commented on a change in pull request #233: LUCENE-10045: Extend ConjunctionUtils to support LongValues and DoubleValues

2021-08-14 Thread GitBox
gsmiller commented on a change in pull request #233: URL: https://github.com/apache/lucene/pull/233#discussion_r689010760 ## File path: lucene/core/src/java/org/apache/lucene/search/Values.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] gsmiller commented on a change in pull request #233: LUCENE-10045: Extend ConjunctionUtils to support LongValues and DoubleValues

2021-08-14 Thread GitBox
gsmiller commented on a change in pull request #233: URL: https://github.com/apache/lucene/pull/233#discussion_r689011053 ## File path: lucene/core/src/java/org/apache/lucene/search/Values.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [lucene] zacharymorn commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

2021-08-14 Thread GitBox
zacharymorn commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r689035631 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollectorManager.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software F

[jira] [Commented] (LUCENE-10002) Remove IndexSearcher#search(Query,Collector) in favor of IndexSearcher#search(Query,CollectorManager)

2021-08-14 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399305#comment-17399305 ] Zach Chen commented on LUCENE-10002: {quote}NiceĀ [~zacharymorn]! Quite a large chan