[jira] [Commented] (LUCENE-10030) [DrillSidewaysScorer] redundant score() calculations in doQueryFirstScoring

[ https://issues.apache.org/jira/browse/LUCENE-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387972#comment-17387972 ] Grigoriy Troitskiy commented on LUCENE-10030: - Yes, It would be great to ba

[GitHub] [lucene] jpountz commented on a change in pull request #226: LUCENE-10036: Add factory method to ScoreCachingWrappingScorer that ensures unnecessary wrapping doesn't occur

jpountz commented on a change in pull request #226: URL: https://github.com/apache/lucene/pull/226#discussion_r677348827 ## File path: lucene/core/src/test/org/apache/lucene/search/TestScoreCachingWrappingScorer.java ## @@ -156,4 +156,28 @@ public void testGetScores() throws E

[GitHub] [lucene] mikemccand commented on pull request #220: LUCENE-9450: Use BinaryDocValue fields in the taxonomy index based on the existing index version

mikemccand commented on pull request #220: URL: https://github.com/apache/lucene/pull/220#issuecomment-887472869 Also, to be clear, even though the opening comment says the PR implemented option 1, it has now iterated onto option 2 (switching based on the index created version metadata).

[GitHub] [lucene] mikemccand commented on a change in pull request #220: LUCENE-9450: Use BinaryDocValue fields in the taxonomy index based on the existing index version

mikemccand commented on a change in pull request #220: URL: https://github.com/apache/lucene/pull/220#discussion_r677406777 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestBackwardsCompatibility.java ## @@ -49,13 +49,8 @@ // // Then mov

[jira] [Commented] (LUCENE-10034) Vectors NeighborQueue MIN/MAX heap reversed?

[ https://issues.apache.org/jira/browse/LUCENE-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388054#comment-17388054 ] Mayya Sharipova commented on LUCENE-10034: -- Tomoko and Michael, thank you for

[jira] [Commented] (LUCENE-10030) [DrillSidewaysScorer] redundant score() calculations in doQueryFirstScoring

[ https://issues.apache.org/jira/browse/LUCENE-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388092#comment-17388092 ] Michael McCandless commented on LUCENE-10030: - bq. Btw, should we have adde

[jira] [Comment Edited] (LUCENE-10034) Vectors NeighborQueue MIN/MAX heap reversed?

[ https://issues.apache.org/jira/browse/LUCENE-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388054#comment-17388054 ] Mayya Sharipova edited comment on LUCENE-10034 at 7/27/21, 2:35 PM: -

[GitHub] [lucene] gsmiller commented on a change in pull request #226: LUCENE-10036: Add factory method to ScoreCachingWrappingScorer that ensures unnecessary wrapping doesn't occur

gsmiller commented on a change in pull request #226: URL: https://github.com/apache/lucene/pull/226#discussion_r677530466 ## File path: lucene/core/src/test/org/apache/lucene/search/TestScoreCachingWrappingScorer.java ## @@ -156,4 +156,28 @@ public void testGetScores() throws

[GitHub] [lucene] gsmiller merged pull request #226: LUCENE-10036: Add factory method to ScoreCachingWrappingScorer that ensures unnecessary wrapping doesn't occur

gsmiller merged pull request #226: URL: https://github.com/apache/lucene/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-10036) Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap another ScoreCachingWrappingScorer

[ https://issues.apache.org/jira/browse/LUCENE-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388119#comment-17388119 ] ASF subversion and git services commented on LUCENE-10036: -- Co

[GitHub] [lucene-solr] gsmiller merged pull request #2534: LUCENE-10036: Add factory method to ScoreCachingWrappingScorer that ensures unnecessary wrapping doesn't occur

gsmiller merged pull request #2534: URL: https://github.com/apache/lucene-solr/pull/2534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Commented] (LUCENE-10036) Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap another ScoreCachingWrappingScorer

[ https://issues.apache.org/jira/browse/LUCENE-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388120#comment-17388120 ] ASF subversion and git services commented on LUCENE-10036: -- Co

[GitHub] [lucene] mikemccand commented on a change in pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

mikemccand commented on a change in pull request #225: URL: https://github.com/apache/lucene/pull/225#discussion_r677506600 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/NFARunAutomaton.java ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [lucene] jpountz opened a new pull request #227: LUCENE-10033: Encode numeric doc values and ordinals of SORTED(_SET) doc values in blocks.

jpountz opened a new pull request #227: URL: https://github.com/apache/lucene/pull/227 This moves doc values to an approach that is more similar to postings, where values are grouped in blocks of 128 values that are compressed together. Decoding a single value requires decoding the ent

[jira] [Commented] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388178#comment-17388178 ] Adrien Grand commented on LUCENE-10033: --- I opened a PR with this idea. Queries th

[jira] [Commented] (LUCENE-10030) [DrillSidewaysScorer] redundant score() calculations in doQueryFirstScoring

[ https://issues.apache.org/jira/browse/LUCENE-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388181#comment-17388181 ] Greg Miller commented on LUCENE-10030: -- Yeah [~gtroitskiy], I caught the missing C

[GitHub] [lucene] zhaih commented on a change in pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

zhaih commented on a change in pull request #225: URL: https://github.com/apache/lucene/pull/225#discussion_r677666989 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/NFARunAutomaton.java ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [lucene] gautamworah96 commented on a change in pull request #220: LUCENE-9450: Use BinaryDocValue fields in the taxonomy index based on the existing index version

gautamworah96 commented on a change in pull request #220: URL: https://github.com/apache/lucene/pull/220#discussion_r677669790 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java ## @@ -475,8 +477,15 @@ private int addCat

[GitHub] [lucene] zhaih commented on a change in pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

zhaih commented on a change in pull request #225: URL: https://github.com/apache/lucene/pull/225#discussion_r677669213 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/NFARunAutomaton.java ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundati

[jira] [Resolved] (LUCENE-10036) Ensure ScoreCachingWrappingScorer doesn't unnecessarily wrap another ScoreCachingWrappingScorer

[ https://issues.apache.org/jira/browse/LUCENE-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10036. -- Fix Version/s: 8.10 main (9.0) Resolution: Fixed > Ensure ScoreCach

[GitHub] [lucene-solr] gautamworah96 commented on pull request #2521: Backport LUCENE-9948 LUCENE-9964

gautamworah96 commented on pull request #2521: URL: https://github.com/apache/lucene-solr/pull/2521#issuecomment-887734156 @gsmiller Yes. I think the change is simple enough to be coded manually. Git did not allow direct cherry picking due to conflicts and that is why I suggested that I ba

[GitHub] [lucene] gautamworah96 commented on a change in pull request #220: LUCENE-9450: Use BinaryDocValue fields in the taxonomy index based on the existing index version

gautamworah96 commented on a change in pull request #220: URL: https://github.com/apache/lucene/pull/220#discussion_r677794298 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java ## @@ -164,9 +159,16 @@ public DirectoryTa

[jira] [Created] (LUCENE-10037) Explore a single scoring implementation in DrillSidewaysScorer

Greg Miller created LUCENE-10037: Summary: Explore a single scoring implementation in DrillSidewaysScorer Key: LUCENE-10037 URL: https://issues.apache.org/jira/browse/LUCENE-10037 Project: Lucene - Co

[GitHub] [lucene] mrkm4ntr opened a new pull request #228: Remove impossible assert condition

mrkm4ntr opened a new pull request #228: URL: https://github.com/apache/lucene/pull/228 # Description DWPTs that have not same deleteQueue with flushingQueue are already filtered. # Checklist Please review the following and check all that apply: - [x]

[jira] [Updated] (LUCENE-10037) Explore a single scoring implementation in DrillSidewaysScorer

[ https://issues.apache.org/jira/browse/LUCENE-10037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller updated LUCENE-10037: - Issue Type: Task (was: Improvement) > Explore a single scoring implementation in DrillSideways

[GitHub] [lucene] mikemccand commented on a change in pull request #220: LUCENE-9450: Use BinaryDocValue fields in the taxonomy index based on the existing index version

mikemccand commented on a change in pull request #220: URL: https://github.com/apache/lucene/pull/220#discussion_r677908217 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java ## @@ -475,8 +477,15 @@ private int addCatego

[GitHub] [lucene] dnhatn commented on pull request #228: Remove impossible assert condition

dnhatn commented on pull request #228: URL: https://github.com/apache/lucene/pull/228#issuecomment-887965341 @mrkm4ntr I think we can remove the assertion entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene] mrkm4ntr commented on pull request #228: Remove unnecessary assertion

mrkm4ntr commented on pull request #228: URL: https://github.com/apache/lucene/pull/228#issuecomment-887970592 @dnhatn Thanks! I removed the assertion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (LUCENE-10035) Simple text codec add multi level skip list data

[ https://issues.apache.org/jira/browse/LUCENE-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wuda updated LUCENE-10035: -- Issue Type: Wish (was: New Feature) > Simple text codec add multi level skip list data > -

[GitHub] [lucene] glawson0 commented on pull request #157: LUCENE-9963 Fix issue with FlattenGraphFilter throwing exceptions from holes

glawson0 commented on pull request #157: URL: https://github.com/apache/lucene/pull/157#issuecomment-888027281 We have been using this change internally for a few weeks now. We no longer encounter the `ArrayIndexOutOfBounds` exceptions that we were previously experiencing. Depending on the