[GitHub] [lucene] jpountz commented on pull request #207: LUCENE-9855: Rename nn search vector format

jpountz commented on pull request #207: URL: https://github.com/apache/lucene/pull/207#issuecomment-882303249 Sounds good @mocobeta I'll merge shortly. A new question is whether `VectorSimilarityFunction` needs renaming now that it's been extracted out from `VectorValues`. -- This

[GitHub] [lucene] jpountz merged pull request #213: LUCENE-10016: Remove VectorValues#getSimilarityFunction.

jpountz merged pull request #213: URL: https://github.com/apache/lucene/pull/213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

[ https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383101#comment-17383101 ] ASF subversion and git services commented on LUCENE-10016: -- Co

[GitHub] [lucene] rmuir commented on pull request #216: Introduce DocTermVectors in lieu of Fields.

rmuir commented on pull request #216: URL: https://github.com/apache/lucene/pull/216#issuecomment-882337507 what are all these commits just adding more public classes for no reason?: TermVectors, now DocTermVectors -1: Full stop. -- This is an automated message from the Apache Git

[jira] [Commented] (LUCENE-9959) Can we remove threadlocals of stored fields and term vectors

[ https://issues.apache.org/jira/browse/LUCENE-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383126#comment-17383126 ] Robert Muir commented on LUCENE-9959: - I don't think we should do this anymore. Some

[jira] [Resolved] (LUCENE-9959) Can we remove threadlocals of stored fields and term vectors

[ https://issues.apache.org/jira/browse/LUCENE-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9959. - Resolution: Won't Fix was a terrible idea that just made APIs worse: I tried having some sympath

[GitHub] [lucene] rmuir commented on pull request #205: LUCENE-9959: Rename TermVectorsReader to TermVectorsReaderBase

rmuir commented on pull request #205: URL: https://github.com/apache/lucene/pull/205#issuecomment-882345193 -1 to these renames that solve no api problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] rmuir commented on pull request #137: LUCENE-9955: Reduced state of stored fields readers.

rmuir commented on pull request #137: URL: https://github.com/apache/lucene/pull/137#issuecomment-882345781 -1 to this code change which started all the new public classes/renaming problems -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

[ https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383271#comment-17383271 ] Adrien Grand commented on LUCENE-10016: --- +1 I believe that we need to have a no-p

[jira] [Commented] (LUCENE-9959) Can we remove threadlocals of stored fields and term vectors

[ https://issues.apache.org/jira/browse/LUCENE-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383314#comment-17383314 ] David Smiley commented on LUCENE-9959: -- Rob, please don't needlessly personalize yo

[GitHub] [lucene] dnhatn commented on a change in pull request #214: LUCENE-10027 provide leaf sorter from commit

dnhatn commented on a change in pull request #214: URL: https://github.com/apache/lucene/pull/214#discussion_r672315261 ## File path: lucene/core/src/java/org/apache/lucene/index/DirectoryReader.java ## @@ -122,6 +122,23 @@ public static DirectoryReader open(final IndexCommit

[jira] [Created] (LUCENE-10029) Can we make refreshes cheaper via two-phase refresh?

Adrien Grand created LUCENE-10029: - Summary: Can we make refreshes cheaper via two-phase refresh? Key: LUCENE-10029 URL: https://issues.apache.org/jira/browse/LUCENE-10029 Project: Lucene - Core

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383402#comment-17383402 ] Michael Gibney commented on LUCENE-10023: - Thanks for the clarification, Adrien

[GitHub] [lucene-solr] gsmiller commented on pull request #2521: Backport LUCENE-9948 LUCENE-9964

gsmiller commented on pull request #2521: URL: https://github.com/apache/lucene-solr/pull/2521#issuecomment-882695741 @gautamworah96 I don't think we want to make this non-backwards compatible change (LUCENE-9948) in 8.10. I think we need to wait for 9.0 for that. This is just what I've ga

[jira] [Commented] (LUCENE-9450) Taxonomy index should use DocValues not StoredFields

[ https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383532#comment-17383532 ] Gautam Worah commented on LUCENE-9450: -- That makes sense to me. Naive question: If

[jira] [Comment Edited] (LUCENE-9450) Taxonomy index should use DocValues not StoredFields

[ https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383532#comment-17383532 ] Gautam Worah edited comment on LUCENE-9450 at 7/20/21, 12:10 AM: -

[jira] [Commented] (LUCENE-9450) Taxonomy index should use DocValues not StoredFields

[ https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383683#comment-17383683 ] Mayya Sharipova commented on LUCENE-9450: - I am not familiar how taxonomy works,