glawson0 commented on a change in pull request #157:
URL: https://github.com/apache/lucene/pull/157#discussion_r655951001
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/core/FlattenGraphFilter.java
##
@@ -284,27 +316,27 @@ public boolean incrementToke
dsmiley commented on pull request #192:
URL: https://github.com/apache/lucene/pull/192#issuecomment-865475628
This has come up not just once but twice. Even then I suspect maybe a third
might be somewhere ;-)
https://issues.apache.org/jira/browse/LUCENE-9203
Discuss in JIRA.
--
Th
glawson0 commented on a change in pull request #157:
URL: https://github.com/apache/lucene/pull/157#discussion_r655951001
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/core/FlattenGraphFilter.java
##
@@ -284,27 +316,27 @@ public boolean incrementToke
Alan Woodward created LUCENE-10011:
--
Summary: PassageScorer could take proximity of terms into account
Key: LUCENE-10011
URL: https://issues.apache.org/jira/browse/LUCENE-10011
Project: Lucene - Core
glawson0 commented on pull request #157:
URL: https://github.com/apache/lucene/pull/157#issuecomment-865702423
Thanks for the explanation. I think I understand how to do the `Automaton`
to `TokenStream` now.
--
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/LUCENE-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367125#comment-17367125
]
Alan Woodward commented on LUCENE-10011:
Given that Passage#getLength() is only
Karl Wright created LUCENE-10012:
Summary: Cache concurrency for GeoStandardPath is poorly designed
Key: LUCENE-10012
URL: https://issues.apache.org/jira/browse/LUCENE-10012
Project: Lucene - Core
rmuir commented on pull request #192:
URL: https://github.com/apache/lucene/pull/192#issuecomment-865739432
and similar to those previous 2 times, where it turned out to be a bad idea,
i think it might be here too. why is this method needed? if we expose it, it
will make it harder to switc
NazerkeBS commented on pull request #2278:
URL: https://github.com/apache/lucene-solr/pull/2278#issuecomment-865763786
closing this PR and I will create another PR on the main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
NazerkeBS closed pull request #2278:
URL: https://github.com/apache/lucene-solr/pull/2278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/LUCENE-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367172#comment-17367172
]
ASF subversion and git services commented on LUCENE-10012:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Wright resolved LUCENE-10012.
--
Fix Version/s: main (9.0)
Resolution: Fixed
> Cache concurrency for GeoStandardPath is
mikemccand commented on a change in pull request #191:
URL: https://github.com/apache/lucene/pull/191#discussion_r656099284
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
##
@@ -162,8 +164,14 @@ private void count(String field, List
matc
[
https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367239#comment-17367239
]
ASF subversion and git services commented on LUCENE-9981:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367241#comment-17367241
]
ASF subversion and git services commented on LUCENE-9981:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-9981.
Fix Version/s: 8.10
main (9.0)
Resolution: Fixed
OK, fix
mikemccand commented on pull request #190:
URL: https://github.com/apache/lucene/pull/190#issuecomment-865903164
Hmm, is there some reason for not back-porting the change to 8.10? In
general if a change can be safely backported (does not break APIs), we should
bias/err towards doing so.
[
https://issues.apache.org/jira/browse/LUCENE-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367247#comment-17367247
]
Michael McCandless commented on LUCENE-9902:
Thanks for catching this [~mayy
mikemccand commented on pull request #163:
URL: https://github.com/apache/lucene/pull/163#issuecomment-865908030
> > Thanks @zhaih this looks great -- I think it's ready! Have you confirmed
that `gradle check` passes?
>
> Thank you for reviewing it! Yeah `gradle check` passed.
jpountz commented on pull request #186:
URL: https://github.com/apache/lucene/pull/186#issuecomment-865931038
> Is it really only for cases where the same value appears many times, or
the field was used as a primary or near-primary index sort field?
You are guessing it right. This mi
glawson0 commented on pull request #157:
URL: https://github.com/apache/lucene/pull/157#issuecomment-865943363
Changed 3 parts of flatten graph filter
1) don't call freeBefore when we finish a hole src node. Hole src nodes can
mean something hasn't been accounted for correctly so calling
glawson0 commented on pull request #157:
URL: https://github.com/apache/lucene/pull/157#issuecomment-865954873
For additional testing I've built a few indexes and played some queries
against them. I didn't find any changes to latency or memory usage. Depending
on the data set used there wa
mikemccand commented on pull request #186:
URL: https://github.com/apache/lucene/pull/186#issuecomment-865973829
> > Is it really only for cases where the same value appears many times, or
the field was used as a primary or near-primary index sort field?
>
> You are guessing it right
[
https://issues.apache.org/jira/browse/LUCENE-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Thistlethwaite updated LUCENE-5169:
-
Reporter: Adrien Grand (was: mygithubit)
> UniDic 2.1.2 support for Japanese To
[
https://issues.apache.org/jira/browse/LUCENE-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367326#comment-17367326
]
Chris Thistlethwaite commented on LUCENE-5169:
--
Original reporter was mygit
[
https://issues.apache.org/jira/browse/LUCENE-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367328#comment-17367328
]
Michael McCandless commented on LUCENE-10010:
-
Yeah, +1 to explore this!
I
[
https://issues.apache.org/jira/browse/LUCENE-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367338#comment-17367338
]
Michael McCandless commented on LUCENE-9204:
{quote}I hope it's ok to post t
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866013290
There is no fix for the JDK 17 issues with garbage collection and disabled
tiered compilation. From Java 18 on we can use the new MemoryCopy class to do
bulk copies. It also sup
uschindler edited a comment on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866013290
There is no fix for the JDK 17 issues with garbage collection and disabled
tiered compilation. From Java 18 on we can use the new MemoryCopy class to do
bulk copies. It a
Arvind Kumar Sahu created LUCENE-10013:
--
Summary: Document contains at least one immense term in field
(whose UTF8 encoding is longer than the max length 32766)
Key: LUCENE-10013
URL: https://issues.apache.or
[
https://issues.apache.org/jira/browse/LUCENE-10013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367401#comment-17367401
]
Michael McCandless commented on LUCENE-10013:
-
Hello, yes the fix for LUCEN
mikemccand commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866046843
> @mikemccand It would be better to have the tool respect
`RUNTIME_JAVA_HOME` like gradlew does.
+1, that sounds like a good idea! Maybe open an issue in `luceneutil`
di
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866054411
Hi @mikemccand,
I will open a few more issues in luceneutil. The way how it invokes the JVM
is not like it is done in production:
- `-Xbatch` as default doesn't help for r
uschindler edited a comment on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866054411
Hi @mikemccand,
I will open a few more issues in luceneutil. The way how it invokes the JVM
is not like it is done in production:
- `-Xbatch` as default doesn't hel
uschindler edited a comment on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866054411
Hi @mikemccand,
I will open a few more issues in luceneutil. The way how it invokes the JVM
is not like it is done in production:
- `-Xbatch` as default doesn't hel
mikemccand commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866067673
> I have no idea why the facetting stuff at the beginning of the bench
output is so badly behaving with MMapDirectory#v2 on top of project panama,
I'll ignore this for now. Mayb
mikemccand commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866073550
> So in general the benchmark should mimic real-live.
+1 -- nightly benchmarks already overrides this (poor) default, so let's fix
`constants.py` to not pass `-Xbatch` nor
mikemccand commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866078727
> So the benchmarking will stay noisy unless we use JMH.
Maybe we should switch `luceneutil` to JMH? Or, poach ideas from it? How
is it reducing JVM/hotspot noise withou
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866087762
Hi @mikemccand,
> > I have no idea why the facetting stuff at the beginning of the bench
output is so badly behaving with MMapDirectory#v2 on top of project panama,
I'll
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866088334
> > So the benchmarking will stay noisy unless we use JMH.
>
> Maybe we should switch `luceneutil` to JMH? Or, poach ideas from it? How
is it reducing JVM/hotspot noise wi
uschindler edited a comment on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866087762
Hi @mikemccand,
> > I have no idea why the facetting stuff at the beginning of the bench
output is so badly behaving with MMapDirectory#v2 on top of project panama
uschindler edited a comment on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866087762
Hi @mikemccand,
> > I have no idea why the facetting stuff at the beginning of the bench
output is so badly behaving with MMapDirectory#v2 on top of project panama
mikemccand commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866097083
> This was negotiated today 👍
>
> To read the whole story check here: [openjdk/panama-foreign#555
(comment)](https://github.com/openjdk/panama-foreign/pull/555#issueco
[
https://issues.apache.org/jira/browse/LUCENE-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367488#comment-17367488
]
Michael McCandless commented on LUCENE-10010:
-
{quote}NFA traversal is not
dnhatn commented on pull request #192:
URL: https://github.com/apache/lucene/pull/192#issuecomment-866107179
Sorry, I didn't search for the existing issues before opening this PR. My
need is a stronger upper type bound than DocIdSetIterator for docValues
iterators. I am okay to close this
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866112156
> > This was negotiated today 👍
> > To read the whole story check here: [openjdk/panama-foreign#555
(comment)](https://github.com/openjdk/panama-foreign/pull/555#issuecomment-
cpoerschke opened a new pull request #2514:
URL: https://github.com/apache/lucene-solr/pull/2514
Since `solr/main` no longer has the equivalent typos this pull request is
for `lucene-solr/branch_8x` only.
--
This is an automated message from the Apache Git Service.
To respond to the mess
mikemccand commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866119211
> The problem with luceneutil is also that it respawns a JVM multiple times.
Hmm, we added multiple JVMs long ago precisely because HotSpot was so
unpredictable. I.e. we
[
https://issues.apache.org/jira/browse/LUCENE-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367506#comment-17367506
]
Mayya Sharipova commented on LUCENE-9902:
-
[~gworah] [~mikemccand] Sorry for n
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866142054
> > The problem with luceneutil is also that it respawns a JVM multiple
times.
>
> Hmm, we added multiple JVMs long ago precisely because HotSpot was so
unpredictable. I.
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866144962
Here are the berlinbuzzwords slides about this:
https://2021.berlinbuzzwords.de/sites/berlinbuzzwords.de/files/2021-06/The%20future%20of%20Lucene%27s%20MMapDirectory.pdf
--
Th
[
https://issues.apache.org/jira/browse/LUCENE-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367524#comment-17367524
]
Robert Muir commented on LUCENE-10010:
--
I think the main difference between the ar
[
https://issues.apache.org/jira/browse/LUCENE-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367564#comment-17367564
]
ASF subversion and git services commented on LUCENE-10012:
--
Co
rmuir commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-866272233
> Hmm, we added multiple JVMs long ago precisely because HotSpot was so
unpredictable. I.e. we had clear examples where HotSpot would paint itself into
a corner, compiling e.g. readV
dnhatn closed pull request #192:
URL: https://github.com/apache/lucene/pull/192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
magibney opened a new pull request #193:
URL: https://github.com/apache/lucene/pull/193
Iterators over subSources of DisjunctionIntervalsSource may return elements
in indeterminate order, requiring explicit sorting to make toString() output
stable across equivalent instances.
--
This is
madrob commented on pull request #193:
URL: https://github.com/apache/lucene/pull/193#issuecomment-866509951
I wish I had thought of this when making
https://github.com/apache/solr/pull/117
looks slick
--
This is an automated message from the Apache Git Service.
To respond to
57 matches
Mail list logo
