[GitHub] [lucene] bruno-roustant commented on a change in pull request #163: LUCENE-9983: Stop sorting determinize powersets unnecessarily

2021-06-01 Thread GitBox
bruno-roustant commented on a change in pull request #163: URL: https://github.com/apache/lucene/pull/163#discussion_r643116749 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/StateSet.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [lucene] bruno-roustant commented on a change in pull request #163: LUCENE-9983: Stop sorting determinize powersets unnecessarily

2021-06-01 Thread GitBox
bruno-roustant commented on a change in pull request #163: URL: https://github.com/apache/lucene/pull/163#discussion_r643113793 ## File path: lucene/core/build.gradle ## @@ -20,6 +20,8 @@ apply plugin: 'java-library' description = 'Lucene core library' dependencies { + imp

[jira] [Commented] (LUCENE-9937) ann-benchmarks results for HNSW search

2021-06-01 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355161#comment-17355161 ] Michael Sokolov commented on LUCENE-9937: - I ran some further tests using hnswli

[GitHub] [lucene-solr] madrob merged pull request #2500: SOLR-14978 OOM Killer in Foreground

2021-06-01 Thread GitBox
madrob merged pull request #2500: URL: https://github.com/apache/lucene-solr/pull/2500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [lucene] gautamworah96 commented on a change in pull request #138: LUCENE-9956: Make getBaseQuery, getDrillDownQueries API from DrillDownQuery public

2021-06-01 Thread GitBox
gautamworah96 commented on a change in pull request #138: URL: https://github.com/apache/lucene/pull/138#discussion_r642711788 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java ## @@ -170,16 +185,36 @@ private BooleanQuery getBooleanQuery() {

[GitHub] [lucene] gautamworah96 commented on a change in pull request #138: LUCENE-9956: Make getBaseQuery, getDrillDownQueries API from DrillDownQuery public

2021-06-01 Thread GitBox
gautamworah96 commented on a change in pull request #138: URL: https://github.com/apache/lucene/pull/138#discussion_r642711762 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java ## @@ -170,16 +185,36 @@ private BooleanQuery getBooleanQuery() {

[GitHub] [lucene] gsmiller commented on pull request #138: LUCENE-9956: Make getBaseQuery, getDrillDownQueries API from DrillDownQuery public

2021-06-01 Thread GitBox
gsmiller commented on pull request #138: URL: https://github.com/apache/lucene/pull/138#issuecomment-852283912 Looks great. Thanks @gautamworah96! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene] gsmiller merged pull request #138: LUCENE-9956: Make getBaseQuery, getDrillDownQueries API from DrillDownQuery public

2021-06-01 Thread GitBox
gsmiller merged pull request #138: URL: https://github.com/apache/lucene/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[jira] [Commented] (LUCENE-9956) Make getBaseQuery API from DrillDownQuery public

2021-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355227#comment-17355227 ] ASF subversion and git services commented on LUCENE-9956: - Commi

[jira] [Resolved] (LUCENE-9956) Make getBaseQuery API from DrillDownQuery public

2021-06-01 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-9956. - Fix Version/s: main (9.0) Resolution: Fixed Thanks [~gworah]! > Make getBaseQuery API fr

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-06-01 Thread Nick Knize (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355256#comment-17355256 ] Nick Knize commented on LUCENE-9981: bq. Even with no API break, I don't want these

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-06-01 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355273#comment-17355273 ] Michael McCandless commented on LUCENE-9981: Thanks everyone, I'll push to {

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355275#comment-17355275 ] ASF subversion and git services commented on LUCENE-9981: - Commi

[GitHub] [lucene] gsmiller merged pull request #143: LUCENE-9962: Allow DrillSideways sub-classes to provide their own "drill down" facet counting implementation (or null).

2021-06-01 Thread GitBox
gsmiller merged pull request #143: URL: https://github.com/apache/lucene/pull/143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[jira] [Commented] (LUCENE-9962) DrillSideways users should be able to opt-out of "drill down" facet collecting

2021-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355308#comment-17355308 ] ASF subversion and git services commented on LUCENE-9962: - Commi

[jira] [Updated] (LUCENE-9970) provide apps details about why TooManyClauses was thrown

2021-06-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated LUCENE-9970: --- Attachment: LUCENE-9970.patch Assignee: Chris M. Hostetter Status: Open

[jira] [Commented] (LUCENE-9950) Support both single- and multi-value string fields in facet counting (non-taxonomy based approaches)

2021-06-01 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355413#comment-17355413 ] Greg Miller commented on LUCENE-9950: - Thanks for adding your additional insights an

[GitHub] [lucene] jtibshirani opened a new pull request #164: LUCENE-9905: Allow Lucene90Codec to be configured with a per-field vector format

2021-06-01 Thread GitBox
jtibshirani opened a new pull request #164: URL: https://github.com/apache/lucene/pull/164 Previously only AssertingCodec could handle a per-field vector format. This PR also strengthens the checks in TestPerFieldVectorFormat. -- This is an automated message from the Apache Git Servic

[jira] [Commented] (LUCENE-9976) WANDScorer assertion error in ensureConsistent

2021-06-01 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355476#comment-17355476 ] Zach Chen commented on LUCENE-9976: --- Hmm this test actually passed for me: {code:java}

[GitHub] [lucene] glawson0 commented on a change in pull request #157: LUCENE-9963 Fix issue with FlattenGraphFilter throwing exceptions from holes

2021-06-01 Thread GitBox
glawson0 commented on a change in pull request #157: URL: https://github.com/apache/lucene/pull/157#discussion_r643674911 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/core/FlattenGraphFilter.java ## @@ -193,14 +194,25 @@ private boolean releaseBuffe

[jira] [Commented] (LUCENE-9976) WANDScorer assertion error in ensureConsistent

2021-06-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355511#comment-17355511 ] Dawid Weiss commented on LUCENE-9976: - Hi [~zacharymorn]! Hmm... I optimistically as