bruno-roustant commented on a change in pull request #163:
URL: https://github.com/apache/lucene/pull/163#discussion_r643113793
##########
File path: lucene/core/build.gradle
##########
@@ -20,6 +20,8 @@ apply plugin: 'java-library'
description = 'Lucene core library'
dependencies {
+ implementation 'com.carrotsearch:hppc'
Review comment:
According to the stats you shared @zhaih in the Jira issue, there are 3
times more get (inc/dec) & removal than entry additions. If there are less than
2M states then IntIntWormMap should be more efficient.
I suggest that you benchmark with IntIntHashMap and IntIntWormMap (with your
existing tests) and take the most appropriate.
Edit: actually maybe a simple array is working? (see the question in the
Operations comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
