iverase opened a new pull request #72:
URL: https://github.com/apache/lucene/pull/72
Replaces the usages of PackedInts#getReaderNoHeader with
DirecReader#getInstance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
[
https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317121#comment-17317121
]
Robert Muir commented on LUCENE-9914:
-
FYI: For the jflex we want the unicode versio
[
https://issues.apache.org/jira/browse/LUCENE-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317137#comment-17317137
]
Robert Muir commented on LUCENE-9913:
-
[~julietibs] I haven't dug into this test/fai
[
https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317138#comment-17317138
]
Uwe Schindler commented on LUCENE-9914:
---
See the groovy script that creates the fi
rmuir merged pull request #70:
URL: https://github.com/apache/lucene/pull/70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contac
[
https://issues.apache.org/jira/browse/LUCENE-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317140#comment-17317140
]
ASF subversion and git services commented on LUCENE-9911:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-9911.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> enable ecjLint unusedExceptionParameter
> -
[
https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317145#comment-17317145
]
Robert Muir commented on LUCENE-9914:
-
yes, that one looks great: I think a similar
[
https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317153#comment-17317153
]
Dawid Weiss commented on LUCENE-9914:
-
It does get a bit more complex if we want to
dweiss commented on pull request #71:
URL: https://github.com/apache/lucene/pull/71#issuecomment-815782744
Thanks Robert. I'll go through these benchmark files and correct them so
that they work. It is a bit worrying that nobody noticed they're broken. :)
Anybody using these at all?
--
[
https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317155#comment-17317155
]
Uwe Schindler commented on LUCENE-9914:
---
That's really fast. The reason why I did
Robert Muir created LUCENE-9916:
---
Summary: generateUnicodeProps doesn't work according to
instructions, always SKIPPED
Key: LUCENE-9916
URL: https://issues.apache.org/jira/browse/LUCENE-9916
Project: Lu
[
https://issues.apache.org/jira/browse/LUCENE-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317159#comment-17317159
]
Dawid Weiss commented on LUCENE-9916:
-
Run with --rerun-tasks if you want to force r
gsmiller commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609667950
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
[
https://issues.apache.org/jira/browse/LUCENE-9872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317169#comment-17317169
]
ASF subversion and git services commented on LUCENE-9872:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317173#comment-17317173
]
Dawid Weiss commented on LUCENE-9916:
-
I corrected the checksum configuration code -
[
https://issues.apache.org/jira/browse/LUCENE-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9916.
-
Resolution: Fixed
> generateUnicodeProps doesn't work according to instructions, always SKIPPED
[
https://issues.apache.org/jira/browse/LUCENE-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317175#comment-17317175
]
Dawid Weiss commented on LUCENE-9916:
-
The "convention" to force-run any task(s) is
rmuir commented on pull request #71:
URL: https://github.com/apache/lucene/pull/71#issuecomment-815809836
> Thanks Robert. I'll go through these benchmark files and correct them so
that they work. It is a bit worrying that nobody noticed they're broken. :)
Anybody using these at all?
[
https://issues.apache.org/jira/browse/LUCENE-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317192#comment-17317192
]
Robert Muir commented on LUCENE-9916:
-
[~dweiss] I realize this looks like just a ge
rmuir commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609691366
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
i
[
https://issues.apache.org/jira/browse/LUCENE-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317196#comment-17317196
]
Dawid Weiss commented on LUCENE-9916:
-
I think tests.txt mentions the convention cle
gsmiller commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609697557
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
gsmiller commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609699872
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
gsmiller commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609697557
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
gsmiller commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609697557
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
rmuir opened a new pull request #73:
URL: https://github.com/apache/lucene/pull/73
This probably isn't most efficient or the best, but its a start.
Some notes:
* Using these steps to "force regenerate" results in local diffs. These look
to be hashmap ordering differences or simila
gsmiller commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609697557
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
rmuir commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609724812
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
i
jpountz commented on pull request #69:
URL: https://github.com/apache/lucene/pull/69#issuecomment-815845326
> I think we leave the implementation as is and hope that we can do
something better with more explicit vectorization support in the future
(Sorry replying here as Github preve
gsmiller commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609733110
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
gsmiller commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609733110
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
rmuir commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609750704
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
i
uschindler commented on pull request #73:
URL: https://github.com/apache/lucene/pull/73#issuecomment-815870339
I have a question: why do we need this "tidy" at end of command line? If it
is always required, it could be triffered automatically?
I know this is unrelated to the document
uschindler commented on a change in pull request #73:
URL: https://github.com/apache/lucene/pull/73#discussion_r609763034
##
File path: help/regeneration.txt
##
@@ -0,0 +1,23 @@
+Regeneration
+
+
+Lucene makes use of some generated code (e.g. jflex tokenizers).
+
+E
uschindler edited a comment on pull request #73:
URL: https://github.com/apache/lucene/pull/73#issuecomment-815870339
I have a question: why do we need this "tidy" at end of command line? If it
is always required, it could be triggered automatically?
I know this is unrelated to the d
rmuir commented on a change in pull request #73:
URL: https://github.com/apache/lucene/pull/73#discussion_r609772375
##
File path: help/regeneration.txt
##
@@ -0,0 +1,23 @@
+Regeneration
+
+
+Lucene makes use of some generated code (e.g. jflex tokenizers).
+
+Exampl
[
https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317245#comment-17317245
]
ASF subversion and git services commented on LUCENE-9827:
-
Commi
Adrien Grand created LUCENE-9917:
Summary: Reduce block size for BEST_COMPRESSION
Key: LUCENE-9917
URL: https://issues.apache.org/jira/browse/LUCENE-9917
Project: Lucene - Core
Issue Type: Im
[
https://issues.apache.org/jira/browse/LUCENE-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9913.
--
Resolution: Fixed
Argh, it is a bug in bulk merges due to numChunks not being propagated on th
dweiss commented on a change in pull request #73:
URL: https://github.com/apache/lucene/pull/73#discussion_r609801705
##
File path: help/regeneration.txt
##
@@ -0,0 +1,23 @@
+Regeneration
+
+
+Lucene makes use of some generated code (e.g. jflex tokenizers).
+
+Examp
dweiss commented on a change in pull request #73:
URL: https://github.com/apache/lucene/pull/73#discussion_r609807318
##
File path: help/regeneration.txt
##
@@ -0,0 +1,23 @@
+Regeneration
+
+
+Lucene makes use of some generated code (e.g. jflex tokenizers).
+
+Examp
dweiss commented on a change in pull request #73:
URL: https://github.com/apache/lucene/pull/73#discussion_r609808709
##
File path: help/regeneration.txt
##
@@ -0,0 +1,23 @@
+Regeneration
+
+
+Lucene makes use of some generated code (e.g. jflex tokenizers).
+
+Examp
uschindler commented on a change in pull request #73:
URL: https://github.com/apache/lucene/pull/73#discussion_r609817750
##
File path: help/regeneration.txt
##
@@ -0,0 +1,23 @@
+Regeneration
+
+
+Lucene makes use of some generated code (e.g. jflex tokenizers).
+
+E
uschindler commented on a change in pull request #73:
URL: https://github.com/apache/lucene/pull/73#discussion_r609819216
##
File path: help/regeneration.txt
##
@@ -0,0 +1,23 @@
+Regeneration
+
+
+Lucene makes use of some generated code (e.g. jflex tokenizers).
+
+E
dweiss commented on pull request #73:
URL: https://github.com/apache/lucene/pull/73#issuecomment-815914300
Leave this patch open, Robert. There is one more non-trivial bit (checksum
saving) that I need to explain there - I'll do it once I get back home.
--
This is an automated message fr
janhoy closed pull request #2082:
URL: https://github.com/apache/lucene-solr/pull/2082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
gsmiller commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609945080
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
[
https://issues.apache.org/jira/browse/LUCENE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317379#comment-17317379
]
Robert Muir commented on LUCENE-9917:
-
do you mean BEST_SPEED here?
> Reduce block
rmuir commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609952804
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
i
Greg Miller created LUCENE-9918:
---
Summary: Can PForUtil be further auto-vectorized?
Key: LUCENE-9918
URL: https://issues.apache.org/jira/browse/LUCENE-9918
Project: Lucene - Core
Issue Type: Ta
gsmiller commented on a change in pull request #69:
URL: https://github.com/apache/lucene/pull/69#discussion_r609959666
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java
##
@@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {
rmuir commented on pull request #73:
URL: https://github.com/apache/lucene/pull/73#issuecomment-816036750
sure, please anyone push improvements, i just wanted to get it started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
gsmiller commented on pull request #69:
URL: https://github.com/apache/lucene/pull/69#issuecomment-816040529
@jpountz
> +1 Let go with whichever of `arr[i] = IDENTITY_PLUS_ONE[i] * val + base`
or `arr[i] = (i+1) * val + base` runs fastest in your micro benchmark. We can
still impro
dweiss commented on pull request #73:
URL: https://github.com/apache/lucene/pull/73#issuecomment-816110667
I pushed a commit - sorry for being verbose. Hope this will helps you (and
others) understand how I think it should work. Not every task is incremental
yet (and I didn't clarify that)
rmuir commented on pull request #73:
URL: https://github.com/apache/lucene/pull/73#issuecomment-816171377
super-helpful, thank you @dweiss !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/LUCENE-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317473#comment-17317473
]
Greg Miller commented on LUCENE-9918:
-
I've setup a microbenchmark project over
[he
[
https://issues.apache.org/jira/browse/LUCENE-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317493#comment-17317493
]
Greg Miller commented on LUCENE-9918:
-
I think my (fairly naive) question here is ma
[
https://issues.apache.org/jira/browse/LUCENE-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317494#comment-17317494
]
Greg Miller commented on LUCENE-9918:
-
I'll also mention that [~rcmuir] has some tho
jtibshirani opened a new pull request #74:
URL: https://github.com/apache/lucene/pull/74
We accidentally kept the old names when creating the new format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
60 matches
Mail list logo
