[jira] [Commented] (LUCENE-9855) Reconsider codec name VectorFormat

2021-04-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314734#comment-17314734 ] Robert Muir commented on LUCENE-9855: - the "strategy" is a huge antipattern. lets sp

[jira] [Commented] (LUCENE-9855) Reconsider codec name VectorFormat

2021-04-05 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314794#comment-17314794 ] Tomoko Uchida commented on LUCENE-9855: --- {quote}right now its too difficult to imp

[jira] [Commented] (LUCENE-9902) Update faceting API to use modern Java features

2021-04-05 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314853#comment-17314853 ] Michael McCandless commented on LUCENE-9902: {quote}I wonder if we need a sp

[jira] [Commented] (LUCENE-9903) Search is not working while migrating Lucene 3.6.2 to 8.7.0

2021-04-05 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314858#comment-17314858 ] Michael McCandless commented on LUCENE-9903: Lots of things changed between

[jira] [Commented] (LUCENE-9850) Explore PFOR for Doc ID delta encoding (instead of FOR)

2021-04-05 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314865#comment-17314865 ] Michael McCandless commented on LUCENE-9850: Impressive results!  And I love

[GitHub] [lucene] mikemccand commented on pull request #56: LUCENE-9883: Turn on ecj missingEnumCaseDespiteDefault setting

2021-04-05 Thread GitBox
mikemccand commented on pull request #56: URL: https://github.com/apache/lucene/pull/56#issuecomment-813397017 Thank you for looking into backporting! I think it's fine to leave this as 9.x / Lucene only. -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Updated] (LUCENE-9573) Add back compat tests for VectorFormat to TestBackwardsCompatibility

2021-04-05 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-9573: --- Fix Version/s: (was: main (9.0)) 9.1 > Add back compat tests

[jira] [Commented] (LUCENE-9573) Add back compat tests for VectorFormat to TestBackwardsCompatibility

2021-04-05 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314874#comment-17314874 ] Michael McCandless commented on LUCENE-9573: Sorry, yes, you are right [~jpo

[jira] [Commented] (LUCENE-9855) Reconsider codec name VectorFormat

2021-04-05 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314876#comment-17314876 ] Tomoko Uchida commented on LUCENE-9855: --- I understand the vector search is a kind

[jira] [Commented] (LUCENE-9857) Skip cache building if IndexOrDocValuesQuery choose the dvQuery

2021-04-05 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314879#comment-17314879 ] Feng Guo commented on LUCENE-9857: -- Thank you for the reply! I'm so sorry that i did no

[GitHub] [lucene] gf2121 closed pull request #29: LUCENE-9857: Skip cache building if IndexOrDocValuesQuery choose the dvQuery

2021-04-05 Thread GitBox
gf2121 closed pull request #29: URL: https://github.com/apache/lucene/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[jira] [Resolved] (LUCENE-9857) Skip cache building if IndexOrDocValuesQuery choose the dvQuery

2021-04-05 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo resolved LUCENE-9857. -- Resolution: Fixed > Skip cache building if IndexOrDocValuesQuery choose the dvQuery >

[jira] [Commented] (LUCENE-9889) Lucene (unexpected ) fsync on existing segments

2021-04-05 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314885#comment-17314885 ] Michael McCandless commented on LUCENE-9889: Thank you for opening this issu

[jira] [Commented] (LUCENE-9892) Ensure @since tag for public classes

2021-04-05 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314886#comment-17314886 ] Michael McCandless commented on LUCENE-9892: Hi [~tomoko], I saw the discuss

[jira] [Commented] (LUCENE-9857) Skip cache building if IndexOrDocValuesQuery choose the dvQuery

2021-04-05 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314949#comment-17314949 ] Julie Tibshirani commented on LUCENE-9857: -- No problem! > Skip cache building

[GitHub] [lucene] dweiss merged pull request #63: LUCENE-9901: UnicodeData.java has no regeneration task

2021-04-05 Thread GitBox
dweiss merged pull request #63: URL: https://github.com/apache/lucene/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[jira] [Commented] (LUCENE-9901) UnicodeData.java has no regeneration task

2021-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315014#comment-17315014 ] ASF subversion and git services commented on LUCENE-9901: - Commi

[jira] [Resolved] (LUCENE-9901) UnicodeData.java has no regeneration task

2021-04-05 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9901. - Fix Version/s: main (9.0) Resolution: Fixed > UnicodeData.java has no regeneration task >

[jira] [Commented] (LUCENE-9855) Reconsider codec name VectorFormat

2021-04-05 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315067#comment-17315067 ] Michael Sokolov commented on LUCENE-9855: - OK, naming is hard! I think it will h

[jira] [Commented] (LUCENE-9850) Explore PFOR for Doc ID delta encoding (instead of FOR)

2021-04-05 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315066#comment-17315066 ] Greg Miller commented on LUCENE-9850: - Thanks [~mikemccand]! For starters, yes—all t

[GitHub] [lucene] gsmiller commented on a change in pull request #62: LUCENE-9902 Minor fixes to the faceting API

2021-04-05 Thread GitBox
gsmiller commented on a change in pull request #62: URL: https://github.com/apache/lucene/pull/62#discussion_r607302178 ## File path: lucene/CHANGES.txt ## @@ -287,7 +287,10 @@ Other API Changes - -(No changes) + +* LUCENE-9902: Change the getValue metho

[GitHub] [lucene] gautamworah96 commented on a change in pull request #62: LUCENE-9902 Minor fixes to the faceting API

2021-04-05 Thread GitBox
gautamworah96 commented on a change in pull request #62: URL: https://github.com/apache/lucene/pull/62#discussion_r607372040 ## File path: lucene/CHANGES.txt ## @@ -287,7 +287,10 @@ Other API Changes - -(No changes) + +* LUCENE-9902: Change the getValue

[GitHub] [lucene] gsmiller commented on a change in pull request #62: LUCENE-9902 Minor fixes to the faceting API

2021-04-05 Thread GitBox
gsmiller commented on a change in pull request #62: URL: https://github.com/apache/lucene/pull/62#discussion_r607379305 ## File path: lucene/CHANGES.txt ## @@ -287,7 +287,10 @@ Other API Changes - -(No changes) + +* LUCENE-9902: Change the getValue metho

[GitHub] [lucene] jtibshirani commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-04-05 Thread GitBox
jtibshirani commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r607396127 ## File path: lucene/MIGRATE.md ## @@ -358,11 +358,21 @@ Rather, an IllegalArgumentException shall be thrown. This is introduced for bett defence and to

[jira] [Created] (LUCENE-9905) Revise approach to specifying NN algorithm

2021-04-05 Thread Julie Tibshirani (Jira)
Julie Tibshirani created LUCENE-9905: Summary: Revise approach to specifying NN algorithm Key: LUCENE-9905 URL: https://issues.apache.org/jira/browse/LUCENE-9905 Project: Lucene - Core Is

[jira] [Updated] (LUCENE-9905) Revise approach to specifying NN algorithm

2021-04-05 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-9905: - Description: In LUCENE-9322 we decided that the new vectors API shouldn’t assume a part

[jira] [Commented] (LUCENE-9855) Reconsider codec name VectorFormat

2021-04-05 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315184#comment-17315184 ] Julie Tibshirani commented on LUCENE-9855: -- Quick note: I spun off LUCENE-9905

[jira] [Updated] (LUCENE-9906) TestIndexSorting.testAddIndexesWithDeletionsAndDirectory can throw error

2021-04-05 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-9906: - Issue Type: Test (was: Improvement) > TestIndexSorting.testAddIndexesWithDeletionsAndDi

[jira] [Created] (LUCENE-9906) TestIndexSorting.testAddIndexesWithDeletionsAndDirectory can throw error

2021-04-05 Thread Julie Tibshirani (Jira)
Julie Tibshirani created LUCENE-9906: Summary: TestIndexSorting.testAddIndexesWithDeletionsAndDirectory can throw error Key: LUCENE-9906 URL: https://issues.apache.org/jira/browse/LUCENE-9906 Proj

[jira] [Updated] (LUCENE-9906) TestIndexSorting.testAddIndexesWithDeletionsAndDirectory can throw error

2021-04-05 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-9906: - Description: This reproduced for me on {{branch_8x}} , but I couldn't reproduce on {{mai

[jira] [Updated] (LUCENE-9855) Reconsider codec name VectorFormat

2021-04-05 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-9855: -- Fix Version/s: main (9.0) > Reconsider codec name VectorFormat > -