dweiss commented on pull request #38:
URL: https://github.com/apache/lucene/pull/38#issuecomment-805602084
bq. IMO it is arguably strange that AttributeSource "crawls" up the class
hierarchy but not the interfaces too?
It is strange and counterintuitive to me. I think all interfaces
uschindler commented on pull request #38:
URL: https://github.com/apache/lucene/pull/38#issuecomment-805693830
>> IMO it is arguably strange that AttributeSource "crawls" up the class
hierarchy but not the interfaces too?
>
> It is strange and counterintuitive to me. I think all inte
uschindler edited a comment on pull request #38:
URL: https://github.com/apache/lucene/pull/38#issuecomment-805693830
>> IMO it is arguably strange that AttributeSource "crawls" up the class
hierarchy but not the interfaces too?
>
> It is strange and counterintuitive to me. I think a
uschindler edited a comment on pull request #38:
URL: https://github.com/apache/lucene/pull/38#issuecomment-805693830
>> IMO it is arguably strange that AttributeSource "crawls" up the class
hierarchy but not the interfaces too?
>
> It is strange and counterintuitive to me. I think a
mayya-sharipova commented on a change in pull request #32:
URL: https://github.com/apache/lucene/pull/32#discussion_r600414533
##
File path: lucene/core/src/java/org/apache/lucene/index/BaseCompositeReader.java
##
@@ -231,4 +239,13 @@ protected final int readerBase(int readerIn
mayya-sharipova commented on a change in pull request #32:
URL: https://github.com/apache/lucene/pull/32#discussion_r600414930
##
File path:
lucene/core/src/java/org/apache/lucene/index/LiveIndexWriterConfig.java
##
@@ -91,6 +92,9 @@
/** The sort order to use to write merge
mayya-sharipova commented on pull request #32:
URL: https://github.com/apache/lucene/pull/32#issuecomment-805766649
@mikemccand Thanks a lot for your feedback, addressed in
34da11d80d30c1d4a418066edfadce0dde3379ae
--
This is an automated message from the Apache Git Service.
To respond to
uschindler commented on pull request #38:
URL: https://github.com/apache/lucene/pull/38#issuecomment-805773997
To finalize the discussion here: Should we maybe merge this PR and leave the
other fixes to a specific discussion issue?
--
This is an automated message from the Apache Git Serv
rmuir commented on pull request #28:
URL: https://github.com/apache/lucene/pull/28#issuecomment-805814747
Thanks @jpountz for the commit! Code is simpler and does fine with testing I
have thrown at it. If anything, it seems faster. I indexed 1M docs (flushing
every doc), It went 20% faster
[
https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307828#comment-17307828
]
Uwe Schindler commented on LUCENE-9864:
---
+1
> Enforce @Override annotation with e
rmuir commented on a change in pull request #15:
URL: https://github.com/apache/lucene/pull/15#discussion_r600505701
##
File path:
lucene/analysis/icu/src/java/org/apache/lucene/analysis/icu/ICUTransformCharFilterFactory.java
##
@@ -0,0 +1,338 @@
+/*
+ * Licensed to the Apache
rmuir commented on pull request #15:
URL: https://github.com/apache/lucene/pull/15#issuecomment-805850393
@magibney I think this is really close to being merged? When testing against
current `main`, the new static analysis checks complain about a piece of dead
code in the Factory (I added
gsmiller commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r600513254
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -388,6 +434,42 @@ private void processFacetFields(
}
}
+ privat
gsmiller commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r600514785
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -388,6 +434,42 @@ private void processFacetFields(
}
}
+ privat
gsmiller commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r600516372
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -388,6 +434,42 @@ private void processFacetFields(
}
}
+ privat
[
https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307909#comment-17307909
]
Robert Muir commented on LUCENE-9863:
-
I think my issue is that there is no agreed-u
dweiss opened a new pull request #39:
URL: https://github.com/apache/lucene/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
Dawid Weiss created LUCENE-9865:
---
Summary: Reduce unnecessary bla-bla-bla in top-level readme file
Key: LUCENE-9865
URL: https://issues.apache.org/jira/browse/LUCENE-9865
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307914#comment-17307914
]
Robert Muir commented on LUCENE-9863:
-
As an example, I opened this issue because of
asfgit merged pull request #35:
URL: https://github.com/apache/lucene/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please conta
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307915#comment-17307915
]
ASF subversion and git services commented on LUCENE-9862:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307916#comment-17307916
]
ASF subversion and git services commented on LUCENE-9862:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9862.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> gradlew regenerate doesnt invoke jflexStand
[
https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307920#comment-17307920
]
Uwe Schindler commented on LUCENE-9863:
---
The problem I see is Gradle vs. Groovy. I
[
https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307925#comment-17307925
]
Robert Muir commented on LUCENE-9863:
-
Also given there is no standard, i tend to le
[
https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307927#comment-17307927
]
Dawid Weiss commented on LUCENE-9863:
-
Would the code formatter help though?... Anyw
[
https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307931#comment-17307931
]
Dawid Weiss commented on LUCENE-9863:
-
bq. Such stuff my horrify groovy fans, but ha
Robert Muir created LUCENE-9866:
---
Summary: regenerate kuromoji dict in regenerate
Key: LUCENE-9866
URL: https://issues.apache.org/jira/browse/LUCENE-9866
Project: Lucene - Core
Issue Type: Task
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307938#comment-17307938
]
Robert Muir commented on LUCENE-9862:
-
Thank you for the improvements here [~dweiss]
[
https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307946#comment-17307946
]
Robert Muir commented on LUCENE-9863:
-
I agree, I don't want to sound like a complai
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307947#comment-17307947
]
Dawid Weiss commented on LUCENE-9862:
-
It was ported from ant, not everything was sh
[
https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307950#comment-17307950
]
Dawid Weiss commented on LUCENE-9863:
-
bq. I just feel guilty "throwing a lot of iss
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307951#comment-17307951
]
Robert Muir commented on LUCENE-9862:
-
Yes, that one triggered the OOM killer on my
[
https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307960#comment-17307960
]
Dawid Weiss commented on LUCENE-9862:
-
I remember looking at why it needs such a lar
dweiss merged pull request #39:
URL: https://github.com/apache/lucene/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please conta
[
https://issues.apache.org/jira/browse/LUCENE-9865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9865.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> Reduce unnecessary bla-bla-bla in top-level
[
https://issues.apache.org/jira/browse/LUCENE-9865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307977#comment-17307977
]
ASF subversion and git services commented on LUCENE-9865:
-
Commi
uschindler commented on pull request #38:
URL: https://github.com/apache/lucene/pull/38#issuecomment-806011084
I added some Javadocs.
@rmuir and I discussed also if we should require a TermToBytesRefAttribute
be available on a tokenstream before sending to IndexWriter. I implemnted t
uschindler merged pull request #38:
URL: https://github.com/apache/lucene/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308040#comment-17308040
]
ASF subversion and git services commented on LUCENE-9856:
-
Commi
uschindler commented on a change in pull request #32:
URL: https://github.com/apache/lucene/pull/32#discussion_r600711473
##
File path: lucene/core/src/java/org/apache/lucene/index/BaseCompositeReader.java
##
@@ -46,6 +47,7 @@
*/
public abstract class BaseCompositeReader ext
magibney commented on pull request #15:
URL: https://github.com/apache/lucene/pull/15#issuecomment-806055837
Great! yes this is looking pretty good from my perspective too. (I forgot to
address the `hoistFilter` method rename -- thanks for catching that).
I'm curious what you'll make
uschindler commented on a change in pull request #15:
URL: https://github.com/apache/lucene/pull/15#discussion_r600761769
##
File path:
lucene/analysis/icu/src/test/org/apache/lucene/analysis/icu/TestICUTransformCharFilter.java
##
@@ -0,0 +1,423 @@
+/*
+ * Licensed to the Apac
mayya-sharipova commented on a change in pull request #32:
URL: https://github.com/apache/lucene/pull/32#discussion_r600786082
##
File path: lucene/core/src/java/org/apache/lucene/index/BaseCompositeReader.java
##
@@ -46,6 +47,7 @@
*/
public abstract class BaseCompositeReade
magibney commented on a change in pull request #15:
URL: https://github.com/apache/lucene/pull/15#discussion_r600788632
##
File path:
lucene/analysis/icu/src/test/org/apache/lucene/analysis/icu/TestICUTransformCharFilter.java
##
@@ -0,0 +1,423 @@
+/*
+ * Licensed to the Apache
rmuir commented on pull request #15:
URL: https://github.com/apache/lucene/pull/15#issuecomment-806079907
> I'm curious what you'll make of
[0d8c001](https://github.com/apache/lucene/commit/0d8c001d88bda373fe321550a452c4dd53a3af74)
... the previous state was kind of weird because we were o
[
https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-9856.
-
Resolution: Fixed
Thanks [~uschindler] for cleaning up the long tail here!
> Improve static ana
magibney commented on pull request #15:
URL: https://github.com/apache/lucene/pull/15#issuecomment-806168671
Ah, I see. Thanks @rmuir for the extra context wrt FCC/FCD/NFKC_CF. I recall
when I checked to see what was actually there it was exactly as you said:
mostly NFC/NFD, a handful of N
uschindler commented on a change in pull request #15:
URL: https://github.com/apache/lucene/pull/15#discussion_r600864899
##
File path:
lucene/analysis/icu/src/test/org/apache/lucene/analysis/icu/TestICUTransformCharFilter.java
##
@@ -0,0 +1,423 @@
+/*
+ * Licensed to the Apac
uschindler commented on a change in pull request #32:
URL: https://github.com/apache/lucene/pull/32#discussion_r600866870
##
File path: lucene/core/src/java/org/apache/lucene/index/BaseCompositeReader.java
##
@@ -46,6 +47,7 @@
*/
public abstract class BaseCompositeReader ext
magibney commented on a change in pull request #15:
URL: https://github.com/apache/lucene/pull/15#discussion_r600869251
##
File path:
lucene/analysis/icu/src/test/org/apache/lucene/analysis/icu/TestICUTransformCharFilter.java
##
@@ -0,0 +1,423 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308215#comment-17308215
]
Greg Miller commented on LUCENE-9850:
-
Thanks for the pointer [~rcmuir]! I'll give t
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308216#comment-17308216
]
Greg Miller commented on LUCENE-9850:
-
I ran a luceneutil benchmark comparing my PFO
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308225#comment-17308225
]
Greg Miller commented on LUCENE-9850:
-
Just looking at the indexes produced by the l
Alexander L created LUCENE-9867:
---
Summary: CorruptIndexException after failed segment merge caused
by No space left on device
Key: LUCENE-9867
URL: https://issues.apache.org/jira/browse/LUCENE-9867
Proj
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander L updated LUCENE-9867:
Description:
A failed segment merge caused by "No space left on device" can't be recovered
and Lu
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander L updated LUCENE-9867:
Description:
Failed segment merge caused by "No space left on device" can't be recovered and
Luce
rmuir commented on pull request #15:
URL: https://github.com/apache/lucene/pull/15#issuecomment-806297526
Thank you, ICU side looks good! Let's just take care of
BaseTokenStreamTestCase and then I think we are ready to merge. I'm sorry this
PR has taken so embarrassingly long. Thank you @m
zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r600992558
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -388,6 +434,42 @@ private void processFacetFields(
}
}
+ pri
zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r600993992
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -388,6 +434,42 @@ private void processFacetFields(
}
}
+ pri
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander L updated LUCENE-9867:
Description:
Failed segment merge caused by "No space left on device" can't be recovered and
Luce
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander L updated LUCENE-9867:
Description:
Failed segment merge caused by "No space left on device" can't be recovered and
Luce
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander L updated LUCENE-9867:
Description:
Failed segment merge caused by "No space left on device" can't be recovered and
Luce
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander L updated LUCENE-9867:
Description:
Failed segment merge caused by "No space left on device" can't be recovered and
Luce
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308339#comment-17308339
]
Robert Muir commented on LUCENE-9867:
-
[~sqshq] you really shouldn't see FileNotFoun
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 4:44 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L commented on LUCENE-9867:
-
[~rcmuir], thank you for the quick response!
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 4:45 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander L updated LUCENE-9867:
Description:
Failed segment merge caused by "No space left on device" can't be recovered and
Luce
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander L updated LUCENE-9867:
Description:
Failed segment merge caused by "No space left on device" can't be recovered and
Luce
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 4:49 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 4:50 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 4:51 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 4:52 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 4:52 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 4:55 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 4:56 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 4:58 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 5:04 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 5:10 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 5:12 AM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308363#comment-17308363
]
Alexander L edited comment on LUCENE-9867 at 3/25/21, 5:13 AM:
---
zacharymorn opened a new pull request #40:
URL: https://github.com/apache/lucene/pull/40
# Description / Solution
Enforce @Override with ecj configuration
# Tests
Passed `./gradlew check`
# Checklist
Please review the following and check all that apply:
[
https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308402#comment-17308402
]
Zach Chen commented on LUCENE-9864:
---
Hi [~rcmuir] [~uschindler], I've opened a PR to e
84 matches
Mail list logo
