rmuir commented on pull request #15: URL: https://github.com/apache/lucene/pull/15#issuecomment-805850393
@magibney I think this is really close to being merged? When testing against current `main`, the new static analysis checks complain about a piece of dead code in the Factory (I added a comment). I also would like to still rename that `optimizeForCommonCase` to something more descriptive such as `hoistFilter` or similar. Finally, the new test (testNormalizationOptimizationOnAvailableIDs) should be marked `@Nightly` because it takes a very long time (not your fault, just the reality of what it is doing). It will still do what we need, as it will still detect any problems on ICU upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
