asalamon74 commented on pull request #2309:
URL: https://github.com/apache/lucene-solr/pull/2309#issuecomment-778613952
Yes, the invocation is longer with this patch, on the other hand we avoid
using an external library so the .gradle file is shorter.
We only require that SHA-1 is su
epugh commented on a change in pull request #2306:
URL: https://github.com/apache/lucene-solr/pull/2306#discussion_r575665009
##
File path:
solr/contrib/scripting/src/test/org/apache/solr/scripting/xslt/XSLTUpdateRequestHandlerTest.java
##
@@ -39,11 +38,17 @@
import org.junit
epugh commented on pull request #2306:
URL: https://github.com/apache/lucene-solr/pull/2306#issuecomment-778617013
Thanks for getting your hands dirty @dsmiley and making these changes, they
LGTM.
This is an automated messa
uschindler commented on a change in pull request #2306:
URL: https://github.com/apache/lucene-solr/pull/2306#discussion_r575675351
##
File path:
solr/contrib/scripting/src/java/org/apache/solr/scripting/xslt/XSLTUpdateRequestHandler.java
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed t
dsmiley commented on a change in pull request #2306:
URL: https://github.com/apache/lucene-solr/pull/2306#discussion_r575675609
##
File path:
solr/contrib/scripting/src/java/org/apache/solr/scripting/xslt/XSLTUpdateRequestHandler.java
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to t
uschindler commented on pull request #2306:
URL: https://github.com/apache/lucene-solr/pull/2306#issuecomment-778630343
> @uschindler if you want to push up an example/make the change the way you
are thinking, I'm 100% happy to have that! Your Java skillz are way beyond
mine, and while I s
dsmiley commented on pull request #2306:
URL: https://github.com/apache/lucene-solr/pull/2306#issuecomment-778632312
> Sorry, my father died on Thursday.
Wow; so sorry to hear! I fear the same for my own Dad; I can't take his
existence for granted so I'll be visiting him tomorrow.
epugh commented on pull request #2306:
URL: https://github.com/apache/lucene-solr/pull/2306#issuecomment-778641991
Sorry to hear that news @uschindler
I did a pass through the Ref Guide to document how to use the XSLT stuff,
and more explicitly called out the sample `.xsl` files
dsmiley commented on pull request #2306:
URL: https://github.com/apache/lucene-solr/pull/2306#issuecomment-778648072
> So, if we aren't changing the name of the Java class in this PR, then I
think we just need to update the Upgrade to Solr 9 page, and we're good to go?
+1
-
[
https://issues.apache.org/jira/browse/SOLR-15152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284268#comment-17284268
]
David Smiley commented on SOLR-15152:
-
RE compress; I'd rather we not and let the use
[
https://issues.apache.org/jira/browse/SOLR-15152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-15152:
Labels: NestedDocuments (was: )
> Export Tool should export nested docs cleanly in .json, .jsonl,
dsmiley commented on a change in pull request #2356:
URL: https://github.com/apache/lucene-solr/pull/2356#discussion_r575699438
##
File path:
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java
##
@@ -1935,21 +1935,22 @@ public void testChildDoctransformer()
dweiss commented on pull request #2362:
URL: https://github.com/apache/lucene-solr/pull/2362#issuecomment-778675424
Hi Robert. Added an experimental task foo with initial steps downloading the
matching ICU source package. Have to go again - family. But it should be doable
to compile it fro
zacharymorn commented on pull request #2342:
URL: https://github.com/apache/lucene-solr/pull/2342#issuecomment-778678349
> If such a situation arises folks will have the ability to write a custom
proxy listener with the ability to switch, add and/or remove delegates. This
keeps the freedom
[
https://issues.apache.org/jira/browse/SOLR-15145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284313#comment-17284313
]
ASF subversion and git services commented on SOLR-15145:
Commit 6
dsmiley merged pull request #2358:
URL: https://github.com/apache/lucene-solr/pull/2358
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284329#comment-17284329
]
ASF subversion and git services commented on LUCENE-9762:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284341#comment-17284341
]
David Smiley commented on LUCENE-9762:
--
I think my assessment is incorrect.
The do
[
https://issues.apache.org/jira/browse/LUCENE-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284344#comment-17284344
]
ASF subversion and git services commented on LUCENE-9762:
-
Commi
dsmiley opened a new pull request #2365:
URL: https://github.com/apache/lucene-solr/pull/2365
When same doc visited twice and when the query is TPI based, an exception
can be thrown. We need to ensure the internal TPI.matches() is never called
repeatedly.
---
dsmiley commented on pull request #2358:
URL: https://github.com/apache/lucene-solr/pull/2358#issuecomment-778735554
As explained in the JIRA issue, I reverted and filed a new PR: #2365
This is an automated message from the A
[
https://issues.apache.org/jira/browse/LUCENE-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-9762:
-
Summary: DoubleValuesSource.fromQuery can fail when doc visited twice
(was: FunctionScoreQuery
22 matches
Mail list logo
