[jira] [Commented] (LUCENE-9686) TestDirectIODirectory#testFloatsUnderflow can fail assertion

2021-01-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275534#comment-17275534 ] Dawid Weiss commented on LUCENE-9686: - Maybe we should just throw EOFException from

[jira] [Commented] (SOLR-8319) NPE when creating pivot

2021-01-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275656#comment-17275656 ] David Smiley commented on SOLR-8319: Is this basically fall-out from the fact that a Q

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2266: SOLR-15120 Reduce duplicated core creation work

2021-01-30 Thread GitBox
dsmiley commented on a change in pull request #2266: URL: https://github.com/apache/lucene-solr/pull/2266#discussion_r567274859 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -3187,20 +3186,29 @@ public void cleanupOldIndexDirectories(boolean reload)

[jira] [Commented] (LUCENE-9713) Did we lose the UTF-8 BOM detection in lucene/CHANGES.txt in gradle migration?

2021-01-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275690#comment-17275690 ] Dawid Weiss commented on LUCENE-9713: - We probably overlooked it somewhere. > Did w

[jira] [Commented] (LUCENE-9711) "gradle precommit" no longer catches accidental package-private APIs?

2021-01-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275693#comment-17275693 ] Dawid Weiss commented on LUCENE-9711: - I think it's the fact the python linter has b

[jira] [Commented] (LUCENE-9686) TestDirectIODirectory#testFloatsUnderflow can fail assertion

2021-01-30 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275703#comment-17275703 ] Zach Chen commented on LUCENE-9686: --- Thanks [~julietibs]!  Hi [~dweiss], thanks for r

[jira] [Comment Edited] (LUCENE-9686) TestDirectIODirectory#testFloatsUnderflow can fail assertion

2021-01-30 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275703#comment-17275703 ] Zach Chen edited comment on LUCENE-9686 at 1/30/21, 7:44 PM: -

[jira] [Commented] (SOLR-15031) NPE caused by FunctionQParser returning a null ValueSource

2021-01-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275704#comment-17275704 ] David Smiley commented on SOLR-15031: - See my comment https://issues.apache.org/jira

[jira] [Commented] (SOLR-15110) Get the date/time functions working in Solr SQL

2021-01-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275707#comment-17275707 ] David Smiley commented on SOLR-15110: - Please use {{java.time}} package for this work

[jira] [Commented] (SOLR-13055) Introduce check to determine "liveliness" of a Solr node

2021-01-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275711#comment-17275711 ] David Smiley commented on SOLR-13055: - I sympathize... the one or two times I've trie

[GitHub] [lucene-solr] madrob commented on a change in pull request #2266: SOLR-15120 Reduce duplicated core creation work

2021-01-30 Thread GitBox
madrob commented on a change in pull request #2266: URL: https://github.com/apache/lucene-solr/pull/2266#discussion_r567320257 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -3187,20 +3186,29 @@ public void cleanupOldIndexDirectories(boolean reload) {

[GitHub] [lucene-solr] madrob commented on a change in pull request #2266: SOLR-15120 Reduce duplicated core creation work

2021-01-30 Thread GitBox
madrob commented on a change in pull request #2266: URL: https://github.com/apache/lucene-solr/pull/2266#discussion_r567320384 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -3187,20 +3186,29 @@ public void cleanupOldIndexDirectories(boolean reload) {

[jira] [Commented] (LUCENE-9711) "gradle precommit" no longer catches accidental package-private APIs?

2021-01-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275761#comment-17275761 ] Robert Muir commented on LUCENE-9711: - That isn't the case. I reverted locally the {

[jira] [Updated] (LUCENE-9711) "gradle precommit" no longer catches accidental package-private APIs?

2021-01-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9711: Attachment: look_ma_no_link.png > "gradle precommit" no longer catches accidental package-private

[jira] [Commented] (LUCENE-9686) TestDirectIODirectory#testFloatsUnderflow can fail assertion

2021-01-30 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275767#comment-17275767 ] Zach Chen commented on LUCENE-9686: --- Hi Dawid, I was able to centralize EOFException t

[jira] [Created] (LUCENE-9714) 8.7 document link is broken

2021-01-30 Thread xiaohuiLiu (Jira)
xiaohuiLiu created LUCENE-9714: -- Summary: 8.7 document link is broken Key: LUCENE-9714 URL: https://issues.apache.org/jira/browse/LUCENE-9714 Project: Lucene - Core Issue Type: Bug Com

[jira] [Commented] (LUCENE-9711) "gradle precommit" no longer catches accidental package-private APIs?

2021-01-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275774#comment-17275774 ] Robert Muir commented on LUCENE-9711: - I looked into this enough to know that I thin

[jira] [Commented] (LUCENE-9711) "gradle precommit" no longer catches accidental package-private APIs?

2021-01-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275776#comment-17275776 ] Robert Muir commented on LUCENE-9711: - I did try checkboxing the eclipse javadocs li