[jira] [Commented] (LUCENE-9047) Directory APIs should be little endian

2020-12-14 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248808#comment-17248808 ] Ignacio Vera commented on LUCENE-9047: -- I am wondering if the best approach for thi

[GitHub] [lucene-solr] vonbox commented on pull request #2118: SOLR-15031: Prevent null being wrapped in a QueryValueSource

2020-12-14 Thread GitBox
vonbox commented on pull request #2118: URL: https://github.com/apache/lucene-solr/pull/2118#issuecomment-744327073 Thanks for the hint. I added a test. This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene-solr] dweiss commented on pull request #2104: SOLR Contribs: Assembly was missing READMEs

2020-12-14 Thread GitBox
dweiss commented on pull request #2104: URL: https://github.com/apache/lucene-solr/pull/2104#issuecomment-744357731 Sorry, I missed this one. I think the includes approach is actually safer - people use all kinds of IDEs, tools and stuff that produces local files which you simply can't pre

[GitHub] [lucene-solr] iverase merged pull request #2131: LUCENE-9552: make sure we don't construct Illegal rectangles due to quantization

2020-12-14 Thread GitBox
iverase merged pull request #2131: URL: https://github.com/apache/lucene-solr/pull/2131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9552) Add a LatLonPoint query that accepts an array of LatLonGeometries

2020-12-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248913#comment-17248913 ] ASF subversion and git services commented on LUCENE-9552: - Commi

[jira] [Commented] (LUCENE-9552) Add a LatLonPoint query that accepts an array of LatLonGeometries

2020-12-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248915#comment-17248915 ] ASF subversion and git services commented on LUCENE-9552: - Commi

[GitHub] [lucene-solr] jpountz commented on a change in pull request #2109: LUCENE-9627: Small refactor of codec classes

2020-12-14 Thread GitBox
jpountz commented on a change in pull request #2109: URL: https://github.com/apache/lucene-solr/pull/2109#discussion_r542333262 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50CompoundFormat.java ## @@ -80,52 +89,46 @@ public void write(Directory d

[GitHub] [lucene-solr] jpountz merged pull request #2139: LUCENE-9636: Extract and operation to get a SIMD optimize

2020-12-14 Thread GitBox
jpountz merged pull request #2139: URL: https://github.com/apache/lucene-solr/pull/2139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9636) Exact and operation to get a SIMD optimize

2020-12-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248956#comment-17248956 ] ASF subversion and git services commented on LUCENE-9636: - Commi

[jira] [Commented] (LUCENE-9636) Exact and operation to get a SIMD optimize

2020-12-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248957#comment-17248957 ] ASF subversion and git services commented on LUCENE-9636: - Commi

[jira] [Commented] (LUCENE-9636) Exact and operation to get a SIMD optimize

2020-12-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248958#comment-17248958 ] ASF subversion and git services commented on LUCENE-9636: - Commi

[jira] [Commented] (LUCENE-9636) Exact and operation to get a SIMD optimize

2020-12-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248955#comment-17248955 ] ASF subversion and git services commented on LUCENE-9636: - Commi

[GitHub] [lucene-solr] jpountz commented on a change in pull request #2126: LUCENE-9628 ScoreMode.TOP_DOCS in bool queries

2020-12-14 Thread GitBox
jpountz commented on a change in pull request #2126: URL: https://github.com/apache/lucene-solr/pull/2126#discussion_r542360145 ## File path: lucene/core/src/java/org/apache/lucene/search/ScoreMode.java ## @@ -73,4 +82,16 @@ public boolean needsScores() { public boolean isEx

[GitHub] [lucene-solr] jpountz commented on pull request #2113: LUCENE-9629: Use computed masks

2020-12-14 Thread GitBox
jpountz commented on pull request #2113: URL: https://github.com/apache/lucene-solr/pull/2113#issuecomment-744426442 @gf2121 do you plan on running a full benchmark as a next step? This is an automated message from the Apache

[GitHub] [lucene-solr] jpountz commented on pull request #2094: LUCENE-9047: Move the Directory APIs to be little endian

2020-12-14 Thread GitBox
jpountz commented on pull request #2094: URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-744450866 Even though the API is not final, it looks like the incubating JDK vector API currently only supports little endian: https://github.com/openjdk/jdk/blob/9b5a2a6b24be140816cb

[jira] [Commented] (LUCENE-9635) BM25FQuery - MultiNormsLeafSimScorer needs to mask long value for long documents

2020-12-14 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249008#comment-17249008 ] Michael McCandless commented on LUCENE-9635: Thank you [~yiluncui] – this in

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2138: LUCENE-9635: BM25FQuery - Mask encoded norm long value in array lookup

2020-12-14 Thread GitBox
mikemccand commented on a change in pull request #2138: URL: https://github.com/apache/lucene-solr/pull/2138#discussion_r542413369 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiNormsLeafSimScorer.java ## @@ -128,7 +128,7 @@ public boolean advanceE

[jira] [Commented] (LUCENE-9047) Directory APIs should be little endian

2020-12-14 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249038#comment-17249038 ] Adrien Grand commented on LUCENE-9047: -- +1 I was looking at the PR and I think that

[GitHub] [lucene-solr] mikemccand commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-14 Thread GitBox
mikemccand commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-744511463 > Is this error showing up in some CI environment / job execution that I can take a further look at? Hmm, I saw this error on running `gradlew precommit` after appl

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-14 Thread GitBox
mikemccand commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r542469154 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -154,14 +146,43 @@ public IndexOutput createOutput(St

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-14 Thread GitBox
mikemccand commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r542469384 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -154,14 +146,43 @@ public IndexOutput createOutput(St

[jira] [Commented] (LUCENE-9047) Directory APIs should be little endian

2020-12-14 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249053#comment-17249053 ] Adrien Grand commented on LUCENE-9047: -- By the way it would be nice if we could als

[jira] [Commented] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249056#comment-17249056 ] Joel Bernstein commented on SOLR-15026: --- May be unrelated but I'm having SSL proble

[jira] [Comment Edited] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249056#comment-17249056 ] Joel Bernstein edited comment on SOLR-15026 at 12/14/20, 3:39 PM: -

[jira] [Comment Edited] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249056#comment-17249056 ] Joel Bernstein edited comment on SOLR-15026 at 12/14/20, 3:39 PM: -

[jira] [Comment Edited] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249056#comment-17249056 ] Joel Bernstein edited comment on SOLR-15026 at 12/14/20, 3:40 PM: -

[GitHub] [lucene-solr] mikemccand commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-14 Thread GitBox
mikemccand commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-744527462 Alas, `gradlew precommit` from the command-line on Linux box is still angry for me: ``` > Task :lucene:misc:compileJava /l/trunk/lucene/misc/src/java/org/apa

[jira] [Commented] (SOLR-12182) Can not switch urlScheme in 7x if there are any cores in the cluster

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249061#comment-17249061 ] Joel Bernstein commented on SOLR-12182: --- Just posted on different ticket but I'll p

[jira] [Comment Edited] (SOLR-12182) Can not switch urlScheme in 7x if there are any cores in the cluster

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249061#comment-17249061 ] Joel Bernstein edited comment on SOLR-12182 at 12/14/20, 3:47 PM: -

[jira] [Comment Edited] (SOLR-12182) Can not switch urlScheme in 7x if there are any cores in the cluster

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249061#comment-17249061 ] Joel Bernstein edited comment on SOLR-12182 at 12/14/20, 3:48 PM: -

[jira] [Commented] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249062#comment-17249062 ] Timothy Potter commented on SOLR-15026: --- Not related to this issue ^ for sure ... s

[jira] [Comment Edited] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249062#comment-17249062 ] Timothy Potter edited comment on SOLR-15026 at 12/14/20, 3:51 PM: -

[jira] [Comment Edited] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249062#comment-17249062 ] Timothy Potter edited comment on SOLR-15026 at 12/14/20, 3:52 PM: -

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2097: LUCENE-9537

2020-12-14 Thread GitBox
mikemccand commented on a change in pull request #2097: URL: https://github.com/apache/lucene-solr/pull/2097#discussion_r542492206 ## File path: lucene/core/src/java/org/apache/lucene/search/IndriQuery.java ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (LUCENE-9632) Replace our TimSort with JDK TimSort

2020-12-14 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249075#comment-17249075 ] Michael McCandless commented on LUCENE-9632: We should at least run `luceneu

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249078#comment-17249078 ] Timothy Potter commented on SOLR-15036: --- [~jbernste] does this {{drill}} expr look

[jira] [Commented] (LUCENE-9406) Make it simpler to track IndexWriter's events

2020-12-14 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249080#comment-17249080 ] Michael McCandless commented on LUCENE-9406: Oh hello [~zacharymorn]! As fa

[GitHub] [lucene-solr] mikemccand commented on pull request #2088: LUCENE-9617: Reset lowestUnassignedFieldNumber in FieldNumbers.clear()

2020-12-14 Thread GitBox
mikemccand commented on pull request #2088: URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-744542544 > > I think this method serves an important purpose/use-case: it lets you efficiently clear the whole index, transactionally, so that e.g. searchers can see the old index

[jira] [Commented] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249081#comment-17249081 ] Joel Bernstein commented on SOLR-15026: --- Here is my start command: {code} bin/solr

[jira] [Comment Edited] (SOLR-12182) Can not switch urlScheme in 7x if there are any cores in the cluster

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249061#comment-17249061 ] Joel Bernstein edited comment on SOLR-12182 at 12/14/20, 4:12 PM: -

[jira] [Comment Edited] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249056#comment-17249056 ] Joel Bernstein edited comment on SOLR-15026 at 12/14/20, 4:12 PM: -

[jira] [Commented] (LUCENE-9624) fix duplicate compute on maxUnpatchedValue

2020-12-14 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249083#comment-17249083 ] Michael McCandless commented on LUCENE-9624: Hmm, I see only the 8.x commit

[jira] [Commented] (LUCENE-9624) fix duplicate compute on maxUnpatchedValue

2020-12-14 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249091#comment-17249091 ] Adrien Grand commented on LUCENE-9624: -- [~mikemccand] I merged a bit quickly from G

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249098#comment-17249098 ] Joel Bernstein commented on SOLR-15036: --- It looks like you've got nulls in the *a_d

[GitHub] [lucene-solr] pbruski opened a new pull request #2143: LUCENE-9021 QueryParser: re-use the LookaheadSuccess exception for branch_8x

2020-12-14 Thread GitBox
pbruski opened a new pull request #2143: URL: https://github.com/apache/lucene-solr/pull/2143 Same as https://github.com/apache/lucene-solr/pull/962, for branch 8.x This is basically the same as https://issues.apache.org/jira/browse/SOLR-11242 , but for Lucene QueryParser # Ch

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-12-14 Thread Przemek Bruski (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249099#comment-17249099 ] Przemek Bruski commented on LUCENE-9021: Done: https://github.com/apache/lucene-

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249101#comment-17249101 ] Timothy Potter commented on SOLR-15036: --- Ok, I have a fix for that issue but the bi

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249104#comment-17249104 ] Joel Bernstein commented on SOLR-15036: --- That's the expected behavior. You need to

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249107#comment-17249107 ] Joel Bernstein commented on SOLR-15036: --- >From the docs: "The drill function read

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249110#comment-17249110 ] Joel Bernstein commented on SOLR-15036: --- >From the test cases: {code} rollup(

[GitHub] [lucene-solr] gf2121 commented on pull request #2113: LUCENE-9629: Use computed masks

2020-12-14 Thread GitBox
gf2121 commented on pull request #2113: URL: https://github.com/apache/lucene-solr/pull/2113#issuecomment-744577425 > @gf2121 do you plan on running a full benchmark as a next step? @jpountz Hi! I am a bit confused about the meaning of `a full benchmark`. There has already been an en

[jira] [Commented] (SOLR-12182) Can not switch urlScheme in 7x if there are any cores in the cluster

2020-12-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249118#comment-17249118 ] Timothy Potter commented on SOLR-12182: --- It's because {{solr.jetty.https.port}} is

[jira] [Commented] (SOLR-12182) Can not switch urlScheme in 7x if there are any cores in the cluster

2020-12-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249133#comment-17249133 ] Timothy Potter commented on SOLR-12182: --- It looks like it is bad BASH logic :P This

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #2144: Fix format indent from 4 to 2 spaces

2020-12-14 Thread GitBox
mayya-sharipova opened a new pull request #2144: URL: https://github.com/apache/lucene-solr/pull/2144 Files in org.apache.lucene.search.comparators package has a wrong indent of 4 spaces instead of 2. This patch fixes only the indent from 4 to correct 2 spaces Backport for PR: #

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #2129: Fix format indent from 4 to 2 spaces

2020-12-14 Thread GitBox
mayya-sharipova commented on pull request #2129: URL: https://github.com/apache/lucene-solr/pull/2129#issuecomment-744587079 @ErickErickson Thanks for your suggestions, and letting me know about LUCENE-9564, I will keep watching this issue. ---

[jira] [Created] (SOLR-15046) bin/solr check to see if solr.jetty.https.port should be set always returns true

2020-12-14 Thread Timothy Potter (Jira)
Timothy Potter created SOLR-15046: - Summary: bin/solr check to see if solr.jetty.https.port should be set always returns true Key: SOLR-15046 URL: https://issues.apache.org/jira/browse/SOLR-15046 Proj

[jira] [Updated] (SOLR-15046) bin/solr check to see if solr.jetty.https.port should be set always returns true

2020-12-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-15046: -- Description: This always returns {{true}} on Mac OS X (not sure about Linux): {code} if [ "$

[jira] [Commented] (SOLR-15046) bin/solr check to see if solr.jetty.https.port should be set always returns true

2020-12-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249139#comment-17249139 ] Timothy Potter commented on SOLR-15046: --- This problem was surfaced by the changes i

[jira] [Commented] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249140#comment-17249140 ] Timothy Potter commented on SOLR-15026: --- See: SOLR-15046 > MiniSolrCloudCluster ca

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249142#comment-17249142 ] Timothy Potter commented on SOLR-15036: --- Thank you! I read that in the docs but it

[GitHub] [lucene-solr] mikemccand commented on pull request #2080: LUCENE-8947: Skip field length accumulation when norms are disabled

2020-12-14 Thread GitBox
mikemccand commented on pull request #2080: URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-744596272 I now understand @rmuir 's concern: because today we force sum of term freq within a single document to fit in `int` (during this `invertState.length` accumulation for no

[GitHub] [lucene-solr] thelabdude opened a new pull request #2145: SOLR-15046: Check if SOLR_SSL_ENABLED strictly equal to true for setting solr.jetty.https.port

2020-12-14 Thread GitBox
thelabdude opened a new pull request #2145: URL: https://github.com/apache/lucene-solr/pull/2145 # Description See JIRA: https://issues.apache.org/jira/browse/SOLR-15046 # Solution Fix bin/solr IF statement. # Tests Manual test using: ``` cd solr

[GitHub] [lucene-solr] thelabdude merged pull request #2145: SOLR-15046: Check if SOLR_SSL_ENABLED strictly equal to true for setting solr.jetty.https.port

2020-12-14 Thread GitBox
thelabdude merged pull request #2145: URL: https://github.com/apache/lucene-solr/pull/2145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (SOLR-15046) bin/solr check to see if solr.jetty.https.port should be set always returns true

2020-12-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter resolved SOLR-15046. --- Fix Version/s: 8.8 Resolution: Fixed > bin/solr check to see if solr.jetty.https.port

[jira] [Commented] (SOLR-15046) bin/solr check to see if solr.jetty.https.port should be set always returns true

2020-12-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249157#comment-17249157 ] ASF subversion and git services commented on SOLR-15046: Commit 9

[jira] [Commented] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-14 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249167#comment-17249167 ] Chris M. Hostetter commented on SOLR-15026: --- {quote}Hi Chris M. Hostetter I act

[jira] [Updated] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-14 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15026: -- Description: MiniSolrCloudCluster makes multiple assumptions related to "SSL" that can

[GitHub] [lucene-solr] rmuir commented on pull request #2080: LUCENE-8947: Skip field length accumulation when norms are disabled

2020-12-14 Thread GitBox
rmuir commented on pull request #2080: URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-744628416 >> Hmm, but I think sumTotalTermFreq, which is per field sum of all totalTermFreq across all terms in that field, could overflow long even today, in and adversarial case. And

[GitHub] [lucene-solr] rmuir commented on pull request #2080: LUCENE-8947: Skip field length accumulation when norms are disabled

2020-12-14 Thread GitBox
rmuir commented on pull request #2080: URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-744629310 > How about decoupling these two problems? First, let's fix the aggregation of totalTermFreq and sumTotalTermFreq to explicitly catch any overflow instead of just doing the da

[GitHub] [lucene-solr] gf2121 commented on pull request #2139: LUCENE-9636: Extract and operation to get a SIMD optimize

2020-12-14 Thread GitBox
gf2121 commented on pull request #2139: URL: https://github.com/apache/lucene-solr/pull/2139#issuecomment-744637612 > This is great. I'm curious if you tested other numbers of bits per value than 15? The `decode15` benchmark result here only wants to tell that we can cause an SIMD o

[GitHub] [lucene-solr] mayya-sharipova merged pull request #2144: Fix format indent from 4 to 2 spaces

2020-12-14 Thread GitBox
mayya-sharipova merged pull request #2144: URL: https://github.com/apache/lucene-solr/pull/2144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #2126: LUCENE-9628 ScoreMode.TOP_DOCS in bool queries

2020-12-14 Thread GitBox
mayya-sharipova commented on pull request #2126: URL: https://github.com/apache/lucene-solr/pull/2126#issuecomment-744672083 @jtibshirani @jpountz Thank you for your review. I've address your feedback in 7e04bdce818c3. Can you please continue the review. -

[jira] [Created] (SOLR-15047) 'collapse' on numeric field treats all docs with '0' in collapse field as part of the null group

2020-12-14 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-15047: - Summary: 'collapse' on numeric field treats all docs with '0' in collapse field as part of the null group Key: SOLR-15047 URL: https://issues.apache.org/jira/browse/SOLR

[jira] [Updated] (SOLR-15047) 'collapse' on numeric field treats all docs with '0' in collapse field as part of the null group

2020-12-14 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15047: -- Attachment: SOLR-15047.patch Assignee: Chris M. Hostetter Status: Open (w

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2020-12-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249387#comment-17249387 ] Timothy Potter commented on SOLR-15036: --- [~jbernste] Does drill only support counti

[jira] [Updated] (SOLR-15045) Commit through curl command is causing delay in issuing commit

2020-12-14 Thread Raj Yadav (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raj Yadav updated SOLR-15045: - Description: Hi All, When we issue commit through curl command, not all the shards are getting `start c

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2132: SOLR-15036: auto- select / rollup / sort / plist over facet expression when using a collection alias with multiple col

2020-12-14 Thread GitBox
muse-dev[bot] commented on a change in pull request #2132: URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r542964749 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/FacetStream.java ## @@ -545,6 +557,18 @@ public void open() throws IOE

[jira] [Created] (SOLR-15048) collapse + query elevation behaves inconsistenty w/ 'null group' docs depending on group head selector

2020-12-14 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-15048: - Summary: collapse + query elevation behaves inconsistenty w/ 'null group' docs depending on group head selector Key: SOLR-15048 URL: https://issues.apache.org/jira/brows

[jira] [Created] (SOLR-15049) Optimize TopLevelJoinQuery "self joins"

2020-12-14 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-15049: -- Summary: Optimize TopLevelJoinQuery "self joins" Key: SOLR-15049 URL: https://issues.apache.org/jira/browse/SOLR-15049 Project: Solr Issue Type: Improvem

[jira] [Updated] (SOLR-15048) collapse + query elevation behaves inconsistenty w/ 'null group' docs depending on group head selector

2020-12-14 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15048: -- Description: while working on SOLR-15047, I realized I wasn't really clear on what the

[jira] [Updated] (SOLR-15048) collapse + query elevation behaves inconsistenty w/ 'null group' docs depending on group head selector

2020-12-14 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15048: -- Attachment: SOLR-15048.patch Status: Open (was: Open) > collapse + query eleva

[jira] [Commented] (SOLR-15047) 'collapse' on numeric field treats all docs with '0' in collapse field as part of the null group

2020-12-14 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249444#comment-17249444 ] Chris M. Hostetter commented on SOLR-15047: --- i started working on this, but am

[GitHub] [lucene-solr] gerlowskija opened a new pull request #2146: SOLR-15049: Add TopLevelJoinQuery optimization for 'self-joins'

2020-12-14 Thread GitBox
gerlowskija opened a new pull request #2146: URL: https://github.com/apache/lucene-solr/pull/2146 # Description TopLevelJoinQuery currently converts ordinals of the "from" field into ordinals of the "to" field, even when the "from" and "to" field are the same and have the same ordin

[GitHub] [lucene-solr] noblepaul merged pull request #2099: SOLR-14977: improved plugin configuration

2020-12-14 Thread GitBox
noblepaul merged pull request #2099: URL: https://github.com/apache/lucene-solr/pull/2099 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-14977) Container plugins need a way to be configured

2020-12-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249462#comment-17249462 ] ASF subversion and git services commented on SOLR-14977: Commit 9

[GitHub] [lucene-solr] noblepaul closed pull request #1071: SOLR-14003: Refactor code to avoid reading state from Replica/Slic

2020-12-14 Thread GitBox
noblepaul closed pull request #1071: URL: https://github.com/apache/lucene-solr/pull/1071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] noblepaul commented on pull request #1071: SOLR-14003: Refactor code to avoid reading state from Replica/Slic

2020-12-14 Thread GitBox
noblepaul commented on pull request #1071: URL: https://github.com/apache/lucene-solr/pull/1071#issuecomment-745026931 Will not fix This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Resolved] (SOLR-14089) Create a ShardStateProvider backed by shard terms

2020-12-14 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-14089. --- Resolution: Won't Fix > Create a ShardStateProvider backed by shard terms > -

[jira] [Resolved] (SOLR-14003) Refactor code to avoid reading state of replica from the data object

2020-12-14 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-14003. --- Resolution: Won't Fix > Refactor code to avoid reading state of replica from the data object >

[jira] [Commented] (SOLR-14781) Remove unused classes

2020-12-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249464#comment-17249464 ] David Smiley commented on SOLR-14781: - Absolutely Gaurav; help out where you please.

[GitHub] [lucene-solr] zacharymorn commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-14 Thread GitBox
zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-745039717 > Alas, `gradlew precommit` from the command-line on Linux box is still angry for me: > > ``` > > Task :lucene:misc:compileJava > /l/trunk/lucene/misc/src/j

[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2020-12-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249484#comment-17249484 ] David Smiley commented on SOLR-14923: - I spent some time on it last weekend, explorin

[jira] [Issue Comment Deleted] (SOLR-11297) Message "Lock held by this virtual machine" during startup. Solr is trying to start some cores twice

2020-12-14 Thread Ritvik Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritvik Sharma updated SOLR-11297: - Comment: was deleted (was: Try to do with replication factor =1 , it will create collection, you

[jira] [Commented] (SOLR-11297) Message "Lock held by this virtual machine" during startup. Solr is trying to start some cores twice

2020-12-14 Thread Ritvik Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249497#comment-17249497 ] Ritvik Sharma commented on SOLR-11297: -- Try to do with replication factor =1 , it wi

[GitHub] [lucene-solr] mkhludnev merged pull request #2143: LUCENE-9021 QueryParser: re-use the LookaheadSuccess exception for branch_8x

2020-12-14 Thread GitBox
mkhludnev merged pull request #2143: URL: https://github.com/apache/lucene-solr/pull/2143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9021) QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

2020-12-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249499#comment-17249499 ] ASF subversion and git services commented on LUCENE-9021: - Commi