[
https://issues.apache.org/jira/browse/SOLR-15008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235982#comment-17235982
]
Radu Gheorghe commented on SOLR-15008:
--
Thanks a lot for replying so quickly, Michae
[
https://issues.apache.org/jira/browse/SOLR-15008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235982#comment-17235982
]
Radu Gheorghe edited comment on SOLR-15008 at 11/20/20, 8:16 AM:
--
[
https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236035#comment-17236035
]
Ilan Ginzburg commented on SOLR-14788:
--
Mark, just to be clear here, I don't +at all
barrotsteindev closed pull request #2043:
URL: https://github.com/apache/lucene-solr/pull/2043
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
dsmiley commented on pull request #1972:
URL: https://github.com/apache/lucene-solr/pull/1972#issuecomment-731182336
This has been ready I think; I'll merge Monday.
This is an automated message from the Apache Git Service.
To
dsmiley commented on pull request #2083:
URL: https://github.com/apache/lucene-solr/pull/2083#issuecomment-731186192
Mike: Wow; it's embarrassing my PR broke that case. Thanks for your review!
I now made init_var_solr occur in the entrypoint, and thus it's guaranteed
to run. Note th
mikemccand commented on a change in pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#discussion_r527730165
##
File path: lucene/core/src/test/org/apache/lucene/index/TestFieldInfos.java
##
@@ -187,4 +187,23 @@ public void testMergedFieldInfos_singleLeaf(
[
https://issues.apache.org/jira/browse/LUCENE-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236195#comment-17236195
]
Erick Erickson commented on LUCENE-5862:
[~elyograg] Can we close this? This is
[
https://issues.apache.org/jira/browse/LUCENE-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236198#comment-17236198
]
Erick Erickson commented on LUCENE-5940:
[~rcmuir] Can we close this? I ran acro
[
https://issues.apache.org/jira/browse/LUCENE-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236199#comment-17236199
]
Erick Erickson commented on LUCENE-2893:
[~rcmuir] Should we close this one too?
[
https://issues.apache.org/jira/browse/SOLR-15008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236213#comment-17236213
]
Michael Gibney commented on SOLR-15008:
---
Thanks for the extra information; I think
mikemccand commented on pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-731222134
> > As long as FieldNumbers.clear() is only called from
IndexWriter.deleteAll(), my understanding is that the safety is provided by the
try (Closeable finalizer = docWrit
mikemccand commented on a change in pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#discussion_r527754432
##
File path: lucene/CHANGES.txt
##
@@ -184,6 +184,9 @@ Bug fixes
* LUCENE-9365: FuzzyQuery was missing matches when prefix length was equal to
t
mikemccand commented on pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-731226197
Maybe we could add a simple unit test here that keeps re-indexing the same
small set of docs with many unique fields, then calls `IW.deleteAll`, many
times? Such that th
mikemccand commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-731234052
> > Second, it is extremely experimental and not clear when it provides
benefits / what risks there are / etc. We need to learn much more about it, in
diverse usage, to h
mikemccand commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-731235020
> I am not sure if we should preserve the native PosixUtil. It's used
nowhere and was only added by @mikemccand back at that time to do more testing.
>
> Nowadays,
mikemccand commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r52826
##
File path: lucene/misc/native/src/main/posix/NativePosixUtil.cpp
##
@@ -102,6 +102,7 @@ JNIEXPORT jint JNICALL
Java_org_apache_lucene_misc_stor
[
https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236249#comment-17236249
]
Mark Robert Miller commented on SOLR-14788:
---
I don’t mean to imply you are TRYI
HoustonPutman commented on a change in pull request #1972:
URL: https://github.com/apache/lucene-solr/pull/1972#discussion_r527814371
##
File path:
solr/contrib/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java
##
@@ -68,7 +66,7 @@
private s
[
https://issues.apache.org/jira/browse/SOLR-15008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236291#comment-17236291
]
Radu Gheorghe commented on SOLR-15008:
--
Ahhh, I feel so stupid because I did try wit
[
https://issues.apache.org/jira/browse/SOLR-15008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236320#comment-17236320
]
Michael Gibney commented on SOLR-15008:
---
Excellent, thanks for reporting back!
{qu
[
https://issues.apache.org/jira/browse/SOLR-15008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236320#comment-17236320
]
Michael Gibney edited comment on SOLR-15008 at 11/20/20, 5:25 PM:
-
dsmiley commented on a change in pull request #1972:
URL: https://github.com/apache/lucene-solr/pull/1972#discussion_r527866190
##
File path:
solr/contrib/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java
##
@@ -68,7 +66,7 @@
private static
[
https://issues.apache.org/jira/browse/LUCENE-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236344#comment-17236344
]
Michael Sokolov commented on LUCENE-9614:
-
{quote}Today the Query API assumes th
megancarey opened a new pull request #2091:
URL: https://github.com/apache/lucene-solr/pull/2091
# Description
Making the UpdateLog **safely** disable-able; without this change, when
UpdateLog is disabled, updates fail silently in "buffering" state.
# Solution
Where
msfroh commented on a change in pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#discussion_r527907408
##
File path: lucene/CHANGES.txt
##
@@ -184,6 +184,9 @@ Bug fixes
* LUCENE-9365: FuzzyQuery was missing matches when prefix length was equal to
the t
msfroh commented on pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-731354457
> Maybe we could add a simple unit test here that keeps re-indexing the same
small set of docs with many unique fields, then calls IW.deleteAll, many times?
Such that the tes
muse-dev[bot] commented on a change in pull request #1972:
URL: https://github.com/apache/lucene-solr/pull/1972#discussion_r527924929
##
File path:
solr/contrib/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/MetricsConfiguration.java
##
@@ -66,13 +81,36 @@ pu
mayya-sharipova commented on pull request #2075:
URL: https://github.com/apache/lucene-solr/pull/2075#issuecomment-731377310
I've caught with @jimczi offline, and we have decided that as all index
segments are sorted in the same way, `TopFieldCollector` should inform
`FieldComparator` ab
mikemccand commented on pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-731398054
OK thanks @msfroh. This indeed sounds like a very inefficient way to test
for this particular bug! But maybe you could mark it `@Monster`, like e.g.
`Test2BBinaryDocVal
Mike Drob created SOLR-15009:
Summary: DirectoryFactory exists masks IOExceptions
Key: SOLR-15009
URL: https://issues.apache.org/jira/browse/SOLR-15009
Project: Solr
Issue Type: Bug
Securit
madrob opened a new pull request #2092:
URL: https://github.com/apache/lucene-solr/pull/2092
https://issues.apache.org/jira/browse/SOLR-15009
This is an automated message from the Apache Git Service.
To respond to the message
dsmiley commented on a change in pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#discussion_r528013594
##
File path: lucene/core/src/test/org/apache/lucene/index/TestFieldInfos.java
##
@@ -187,4 +187,23 @@ public void testMergedFieldInfos_singleLeaf() t
msfroh commented on pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-731461788
I managed to trigger an OutOfMemoryError, at least within my IDE by burning
through 50 million fields, then trying to add one more document and flushing.
Curiously, the
madrob commented on pull request #2092:
URL: https://github.com/apache/lucene-solr/pull/2092#issuecomment-731474367
@dsmiley you might find this interesting based on your other comment about
Path v File
This is an automated
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r528053985
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -72,14 +64,17 @@
* and OS X; other Unixes should w
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r528054089
##
File path:
lucene/test-framework/src/java/org/apache/lucene/store/MockDirectoryWrapper.java
##
@@ -745,7 +745,7 @@ public synchronized IndexIn
zacharymorn commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-731491171
> > I am not sure if we should preserve the native PosixUtil. It's used
nowhere and was only added by @mikemccand back at that time to do more testing.
> > Nowadays, i
zacharymorn commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-731491257
> > > Second, it is extremely experimental and not clear when it provides
benefits / what risks there are / etc. We need to learn much more about it, in
diverse usage, t
zacharymorn edited a comment on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-731491257
> > > Second, it is extremely experimental and not clear when it provides
benefits / what risks there are / etc. We need to learn much more about it, in
diverse u
dweiss commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r528111453
##
File path:
lucene/test-framework/src/java/org/apache/lucene/store/MockDirectoryWrapper.java
##
@@ -745,7 +745,7 @@ public synchronized IndexInput o
41 matches
Mail list logo
