iverase commented on pull request #2059:
URL: https://github.com/apache/lucene-solr/pull/2059#issuecomment-725913962
@nknize Do you have an opinion about this change?
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/LUCENE-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230413#comment-17230413
]
Adrien Grand commented on LUCENE-9569:
--
[~mayyas] Should we add it back now?
> Tem
dweiss commented on a change in pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r521911417
##
File path: .gitignore
##
@@ -8,6 +8,10 @@ build/
/.idea/
#IntelliJ creates this folder, ignore.
/dev-tools/missing-doclet/out/
+*.iml
Review
[
https://issues.apache.org/jira/browse/LUCENE-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9511.
--
Fix Version/s: 8.7
Resolution: Fixed
> Include StoredFieldsWriter in DWPT accounting
>
[
https://issues.apache.org/jira/browse/LUCENE-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand closed LUCENE-9511.
> Include StoredFieldsWriter in DWPT accounting
> -
>
>
dweiss commented on a change in pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r521912140
##
File path: lucene/misc/native/src/main/posix/NativePosixUtil.cpp
##
@@ -38,12 +38,12 @@
#ifdef LINUX
/*
- * Class: org_apache_lucene_store_N
dweiss commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-725917917
> On the other hand, I think these tests will break if run from IDEs. Do we
need to support that in this PR?
Oh, thanks! I'll take a look after I come back from work. I
dweiss commented on pull request #2077:
URL: https://github.com/apache/lucene-solr/pull/2077#issuecomment-725922377
LGTM. Just scratching my head about one thing - the generator has that extra
field now yet the patch doesn't contain diffs for other languages - only
Serbian and Yiddish?
-
[
https://issues.apache.org/jira/browse/SOLR-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230421#comment-17230421
]
ASF subversion and git services commented on SOLR-14975:
Commit c
bruno-roustant closed pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
[
https://issues.apache.org/jira/browse/SOLR-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant resolved SOLR-14975.
---
Resolution: Fixed
Thanks Erick and David for the review!
> Optimize CoreContainer.getAllCore
uschindler commented on pull request #2077:
URL: https://github.com/apache/lucene-solr/pull/2077#issuecomment-725941942
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Ignacio Vera created LUCENE-9606:
Summary: Wrap boolean queries generated by shape fields with a
Constant score query
Key: LUCENE-9606
URL: https://issues.apache.org/jira/browse/LUCENE-9606
Project: L
[
https://issues.apache.org/jira/browse/LUCENE-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230490#comment-17230490
]
Adrien Grand commented on LUCENE-9606:
--
+1
> Wrap boolean queries generated by sha
[
https://issues.apache.org/jira/browse/LUCENE-9508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230497#comment-17230497
]
Simon Willnauer commented on LUCENE-9508:
-
Hey Zach, thanks for opening this. Le
s1monw commented on a change in pull request #2022:
URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r521992111
##
File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java
##
@@ -74,6 +74,18 @@ public BytesRef binaryValue() throws IOException {
[
https://issues.apache.org/jira/browse/LUCENE-9590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230509#comment-17230509
]
Lu Xugang commented on LUCENE-9590:
---
Or as [~dsmiley] said in mail, We could link to
sigram commented on a change in pull request #2065:
URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r522034988
##
File path: solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java
##
@@ -366,7 +381,7 @@ public void m2(SolrQueryRequest req, SolrQuery
sigram commented on a change in pull request #2065:
URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r522039722
##
File path: solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java
##
@@ -114,6 +118,16 @@ public synchronized ApiInfo getPlugin(String
[
https://issues.apache.org/jira/browse/SOLR-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230611#comment-17230611
]
Erick Erickson commented on SOLR-14991:
---
I'll tag these and remove the branch this
[
https://issues.apache.org/jira/browse/SOLR-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230620#comment-17230620
]
ASF subversion and git services commented on SOLR-14983:
Commit 2
[
https://issues.apache.org/jira/browse/SOLR-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230622#comment-17230622
]
ASF subversion and git services commented on SOLR-14983:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-14983:
---
Fix Version/s: 8.8
master (9.0)
Resolution: Fixed
[
https://issues.apache.org/jira/browse/SOLR-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14986:
--
Summary: Add warning to ref guide that using "properties.name" is an expert
option (was: Restr
[
https://issues.apache.org/jira/browse/SOLR-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230628#comment-17230628
]
Cao Manh Dat commented on SOLR-14991:
-
thank you Erick, I am ok on removing that!
>
rmuir commented on pull request #2077:
URL: https://github.com/apache/lucene-solr/pull/2077#issuecomment-726089629
> Just scratching my head about one thing - the generator has that extra
field now yet the patch doesn't contain diffs for other languages - only
Serbian and Yiddish?
@
mikemccand merged pull request #2076:
URL: https://github.com/apache/lucene-solr/pull/2076
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dweiss commented on pull request #2077:
URL: https://github.com/apache/lucene-solr/pull/2077#issuecomment-726091990
This one?
https://github.com/apache/lucene-solr/pull/2077/files#diff-455f29a3b76e17c21dded0a5f1b853145bfa7e6e5f1f36c52012a5f124e14ac2R589
rmuir commented on pull request #2077:
URL: https://github.com/apache/lucene-solr/pull/2077#issuecomment-726092971
There isn't any changes here. It's confusing because its showing a diff of a
patch file, and github is highlighting something in green that isn't a change.
The only thing that
rmuir commented on pull request #2077:
URL: https://github.com/apache/lucene-solr/pull/2077#issuecomment-726094165
It's not your fault, this is why its good to try to work down this patch
file, it is confusing.
This is an au
dweiss commented on pull request #2077:
URL: https://github.com/apache/lucene-solr/pull/2077#issuecomment-726093808
Duh. I see it now... darn, sorry for the noise.
This is an automated message from the Apache Git Service.
To
ErickErickson opened a new pull request #2078:
URL: https://github.com/apache/lucene-solr/pull/2078
Changed both CREATE and ADDREPLICA to just add the warning to the docs. The
JIRA has a long explanation about why fixing it in the code is too
risky/expensive.
gw buildsite succeeds.
mikemccand commented on a change in pull request #2022:
URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r522164296
##
File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java
##
@@ -74,6 +74,18 @@ public BytesRef binaryValue() throws IOException
[
https://issues.apache.org/jira/browse/SOLR-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230681#comment-17230681
]
Erick Erickson commented on SOLR-14986:
---
[~ctargett] [~mdrob] Any comments? It's j
jpountz merged pull request #2069:
URL: https://github.com/apache/lucene-solr/pull/2069
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230700#comment-17230700
]
ASF subversion and git services commented on LUCENE-9378:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230701#comment-17230701
]
ASF subversion and git services commented on LUCENE-9378:
-
Commi
HoustonPutman commented on pull request #2078:
URL: https://github.com/apache/lucene-solr/pull/2078#issuecomment-726206070
I believe you can actually make a warning box in asciidoc via:
```asciidoc
[WARNING]
```
I also prefer "overwriting" or "overridi
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230801#comment-17230801
]
Nico Tonozzi commented on LUCENE-9378:
--
Thank you for the help here folks, and espe
[
https://issues.apache.org/jira/browse/LUCENE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reopened LUCENE-9499:
---
Hi,
since this commit, the Windows builds fail reproducible:
FAILURE: Build failed with an exce
[
https://issues.apache.org/jira/browse/LUCENE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230851#comment-17230851
]
Uwe Schindler edited comment on LUCENE-9499 at 11/12/20, 6:39 PM:
[
https://issues.apache.org/jira/browse/LUCENE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230855#comment-17230855
]
Uwe Schindler commented on LUCENE-9499:
---
And this may be removed, as we have no sp
[
https://issues.apache.org/jira/browse/LUCENE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230907#comment-17230907
]
Uwe Schindler commented on LUCENE-9499:
---
The problem is the following:
{noformat}
[
https://issues.apache.org/jira/browse/LUCENE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230908#comment-17230908
]
Uwe Schindler commented on LUCENE-9499:
---
I think that's caused by LUCENE-9600, wil
[
https://issues.apache.org/jira/browse/LUCENE-9600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reopened LUCENE-9600:
---
I think this caused the bug reported in LUCENE-9499.
> Clean up package name conflicts for misc
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230912#comment-17230912
]
ASF subversion and git services commented on LUCENE-9378:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230911#comment-17230911
]
ASF subversion and git services commented on LUCENE-9378:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230918#comment-17230918
]
Uwe Schindler commented on LUCENE-9600:
---
The problem is caused by this link:
http
[
https://issues.apache.org/jira/browse/LUCENE-9600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230918#comment-17230918
]
Uwe Schindler edited comment on LUCENE-9600 at 11/12/20, 8:33 PM:
[
https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9378.
--
Fix Version/s: 8.8
Resolution: Fixed
> Configurable compression for BinaryDocValues
> -
[
https://issues.apache.org/jira/browse/LUCENE-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayya Sharipova resolved LUCENE-9569.
-
Fix Version/s: 8.7
Resolution: Fixed
> Temporarily disable sort optimization on _
[
https://issues.apache.org/jira/browse/LUCENE-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230994#comment-17230994
]
Mayya Sharipova commented on LUCENE-9569:
-
[~jpountz] Thank you for the reminder
[
https://issues.apache.org/jira/browse/LUCENE-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230997#comment-17230997
]
ASF subversion and git services commented on LUCENE-9569:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230998#comment-17230998
]
ASF subversion and git services commented on LUCENE-9569:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231006#comment-17231006
]
ASF subversion and git services commented on LUCENE-9450:
-
Commi
mikemccand merged pull request #1733:
URL: https://github.com/apache/lucene-solr/pull/1733
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/LUCENE-9600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231029#comment-17231029
]
ASF subversion and git services commented on LUCENE-9600:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-9499.
---
Resolution: Fixed
Fixed by LUCENE-9600.
> Clean up package name conflicts between modules (
[
https://issues.apache.org/jira/browse/LUCENE-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231031#comment-17231031
]
Uwe Schindler edited comment on LUCENE-9499 at 11/12/20, 11:29 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-9600.
---
Resolution: Fixed
This should be fixed now.
> Clean up package name conflicts for misc modu
cpoerschke commented on pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#issuecomment-726414214
Hi @alessandrobenedetti, I returned to this pull request today, both the
changes above and the tests (which I hadn't looked at before). Very
comprehensive test coverage,
cpoerschke commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r522486838
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java
##
@@ -208,55 +216,116 @@ p
cpoerschke commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r522515743
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/interleaving/TeamDraftInterleaving.java
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the A
cpoerschke commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r522516056
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java
##
@@ -210,50 +216,59 @@ pu
[
https://issues.apache.org/jira/browse/SOLR-14928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231069#comment-17231069
]
Ilan Ginzburg commented on SOLR-14928:
--
Just forced push a [new
commit|https://gith
zacharymorn commented on pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-726467539
> > On the other hand, I think these tests will break if run from IDEs. Do
we need to support that in this PR?
>
> Oh, thanks! I'll take a look after I come back f
[
https://issues.apache.org/jira/browse/LUCENE-9508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231109#comment-17231109
]
Zach Chen commented on LUCENE-9508:
---
Hi [~simonw], just to clarify I wasn't the one wh
[
https://issues.apache.org/jira/browse/SOLR-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231113#comment-17231113
]
Noble Paul commented on SOLR-14991:
---
done [~erickerickson]
> tag and remove obsolete b
68 matches
Mail list logo
