sigram commented on a change in pull request #2065:
URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r522039722
##########
File path: solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java
##########
@@ -114,6 +118,16 @@ public synchronized ApiInfo getPlugin(String name) {
return currentPlugins.get(name);
}
+ static class PluginMetaHolder {
+ private final Map<String, Object> original;
+ private final PluginMeta meta;
Review comment:
I know that I can ignore it - my point was that this property is a relic
of the time when we allowed only Api handlers as plugins. Now when non-Api
plugins are first-class citizens half of the time this property doesn't make
sense because it's specific only to Api plugins - so it should not be exposed
as a standard property for all plugins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
