[GitHub] [lucene-solr] dweiss commented on a change in pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

dweiss commented on a change in pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r519315788 ## File path: lucene/native/build.gradle ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

dweiss commented on a change in pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r519320646 ## File path: lucene/native/build.gradle ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2064: LUCENE-9600: Clean up package name conflicts between misc and core modules

mocobeta commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r519355253 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java ## @@ -95,7 +95,7 @@ private static BytesRef toBytesRef(IntsR

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2064: LUCENE-9600: Clean up package name conflicts between misc and core modules

mocobeta commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r519363648 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java ## @@ -95,7 +95,7 @@ private static BytesRef toBytesRef(IntsR

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2064: LUCENE-9600: Clean up package name conflicts between misc and core modules

mocobeta commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r519363648 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java ## @@ -95,7 +95,7 @@ private static BytesRef toBytesRef(IntsR

[GitHub] [lucene-solr] bruno-roustant commented on pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

bruno-roustant commented on pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723568609 I'm looking at optimizing SolrCores.getCoreDescriptors() but actually it would require to add a new TransientSolrCoreCache.getTransientDescriptors() method. This mean

[GitHub] [lucene-solr] ErickErickson commented on pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

ErickErickson commented on pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723577563 David: I’ve no objection to removing all the if (transientHandler==null) tests if we fail on initialization. Bruno: Yeah, I think 9.0 only is the w

[jira] [Created] (SOLR-14990) Reproducing test failure for TestRandomDVFaceting, trunk and 8x

Erick Erickson created SOLR-14990: - Summary: Reproducing test failure for TestRandomDVFaceting, trunk and 8x Key: SOLR-14990 URL: https://issues.apache.org/jira/browse/SOLR-14990 Project: Solr

[jira] [Resolved] (SOLR-9033) SimpleMLTQParserTest failure

[ https://issues.apache.org/jira/browse/SOLR-9033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-9033. -- Resolution: Cannot Reproduce I happened to run across this, none of these seeds fail any more so

[GitHub] [lucene-solr] bruno-roustant commented on pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

bruno-roustant commented on pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723586994 Finally I optimized SolrCore.getCoreDescriptors(). The version in this commit is the one for the 8.x branch - TransientSolrCoreCache.getTransientDescriptors() stays c

[GitHub] [lucene-solr] bruno-roustant commented on pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

bruno-roustant commented on pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723587255 So @dsmiley @ErickErickson do we all agree that we throw an exception in in TransientSolrCoreCacheFactory.newInstance() line 60 and we never return null? ---

[jira] [Commented] (SOLR-14983) Score returned in search request is original score and not reranked score

[ https://issues.apache.org/jira/browse/SOLR-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228076#comment-17228076 ] Krishan commented on SOLR-14983: Thanks [~cpoerschke] for your consideration to add my na

[GitHub] [lucene-solr] thelabdude commented on pull request #2067: SOLR-14987: Reuse HttpSolrClient per node vs. one per Solr core when using CloudSolrStream

thelabdude commented on pull request #2067: URL: https://github.com/apache/lucene-solr/pull/2067#issuecomment-723636169 I don't think the current solution solves the problem of clusters many nodes, you'll still get a bunch of client objects, still investigating what can be done about that

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

dsmiley commented on a change in pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r519473036 ## File path: solr/core/src/java/org/apache/solr/core/SolrCores.java ## @@ -490,21 +492,19 @@ public CoreDescriptor getCoreDescriptor(String coreName)

[GitHub] [lucene-solr] dsmiley commented on pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

dsmiley commented on pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723661590 > So @dsmiley @ErickErickson do we all agree that we throw an exception in in TransientSolrCoreCacheFactory.newInstance() line 60 and we never return null? +1 definite

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

noblepaul commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r519484410 ## File path: solr/core/src/java/org/apache/solr/api/ConfigurablePlugin.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

noblepaul commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r519484574 ## File path: solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java ## @@ -69,7 +72,8 @@ public class ContainerPluginsRegistry imple

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

noblepaul commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r519484697 ## File path: solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java ## @@ -372,9 +396,27 @@ public void init() throws Exception {

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

noblepaul commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r519484410 ## File path: solr/core/src/java/org/apache/solr/api/ConfigurablePlugin.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

noblepaul commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r519484410 ## File path: solr/core/src/java/org/apache/solr/api/ConfigurablePlugin.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

noblepaul commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r519484697 ## File path: solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java ## @@ -372,9 +396,27 @@ public void init() throws Exception {

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

noblepaul commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r519484697 ## File path: solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java ## @@ -372,9 +396,27 @@ public void init() throws Exception {

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2065: SOLR-14977 : ContainerPlugins should be configurable

noblepaul commented on a change in pull request #2065: URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r519495793 ## File path: solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java ## @@ -372,9 +396,27 @@ public void init() throws Exception {

[jira] [Commented] (LUCENE-8982) Make NativeUnixDirectory pure java now that direct IO is possible

[ https://issues.apache.org/jira/browse/LUCENE-8982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228298#comment-17228298 ] Zach Chen commented on LUCENE-8982: --- [~dweiss] Thanks for the suggestion and it makes

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

zacharymorn commented on a change in pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r519500988 ## File path: lucene/native/build.gradle ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contri

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

zacharymorn commented on a change in pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r519501165 ## File path: lucene/native/build.gradle ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contri

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

zacharymorn commented on a change in pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r519501165 ## File path: lucene/native/build.gradle ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contri

[GitHub] [lucene-solr] gautamworah96 commented on pull request #1733: LUCENE-9450 Use BinaryDocValues in the taxonomy writer

gautamworah96 commented on pull request #1733: URL: https://github.com/apache/lucene-solr/pull/1733#issuecomment-723694318 The earlier revision of this PR had backward compatibility test failures after merging because the Lucene codec has changed. I've added a `testCompile` dependency on

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

zacharymorn commented on a change in pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r519505634 ## File path: lucene/native/build.gradle ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contri

[GitHub] [lucene-solr] zacharymorn commented on pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

zacharymorn commented on pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-723700269 > I added some general comments. The code, as it is now, doesn't compile for me on Windows (fails to find includes as they're under win32). Even if I add the includes, i

[jira] [Comment Edited] (SOLR-9188) BlockUnknown property makes inter-node communication impossible

[ https://issues.apache.org/jira/browse/SOLR-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228305#comment-17228305 ] Yevhen Tienkaiev edited comment on SOLR-9188 at 11/9/20, 1:20 AM: --

[jira] [Commented] (SOLR-9188) BlockUnknown property makes inter-node communication impossible

[ https://issues.apache.org/jira/browse/SOLR-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228305#comment-17228305 ] Yevhen Tienkaiev commented on SOLR-9188: [~janhoy] it was related to SOLR-14569 pr

[jira] [Commented] (SOLR-14569) Configuring a shardHandlerFactory on the /select requestHandler results in HTTP 401 when searching on alias in secured Solr

[ https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228310#comment-17228310 ] Yevhen Tienkaiev commented on SOLR-14569: - Please someone review/fix this ASAP pr

[jira] [Created] (LUCENE-9601) Why not use HardLink in indexWriter.addIndexes

zhangchao.es created LUCENE-9601: Summary: Why not use HardLink in indexWriter.addIndexes Key: LUCENE-9601 URL: https://issues.apache.org/jira/browse/LUCENE-9601 Project: Lucene - Core Issue

[jira] [Resolved] (LUCENE-9601) Why not use HardLink in indexWriter.addIndexes

[ https://issues.apache.org/jira/browse/LUCENE-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9601. - Resolution: Not A Problem You can use {{HardlinkCopyDirectoryWrapper}} if you want this, just ta

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

zacharymorn commented on a change in pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r519501165 ## File path: lucene/native/build.gradle ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contri

[jira] [Commented] (SOLR-14788) Solr: The Next Big Thing

[ https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228344#comment-17228344 ] Mark Robert Miller commented on SOLR-14788: --- Okay, the initial work for the Ove